Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f750ab62-7deb-21a1-753e-1ee838386265@amd.com>
Date:   Fri, 12 Aug 2022 13:12:59 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] drm/amdgpu: remove useless condition in
 amdgpu_job_stop_all_jobs_on_sched()
Content-Language: en-US
To:     Andrey Grodzovsky <andrey.grodzovsky@amd.com>,
        Andrey Strachuk <strochuk@ispras.ru>,
        Alex Deucher <alexander.deucher@amd.com>
Cc:     "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, Emma Anholt <emma@anholt.net>,
        Melissa Wen <mwen@igalia.com>,
        Guchun Chen <guchun.chen@amd.com>,
        Surbhi Kakarya <surbhi.kakarya@amd.com>,
        Jack Zhang <Jack.Zhang1@amd.com>,
        Hawking Zhang <Hawking.Zhang@amd.com>,
        Felix Kuehling <Felix.Kuehling@amd.com>,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org
References: <20220719103954.6737-1-strochuk@ispras.ru>
 <fac8ce6e-6f5f-598d-35cc-7bf01ac90f30@amd.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <fac8ce6e-6f5f-598d-35cc-7bf01ac90f30@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?emFqK0dGamV2cW9KSm9vYXZ4U044R1F3SU5ocmxQRXV6VWFtQUYyTGwxK3Vs?=
 =?utf-8?B?dGJFOHQyNUY5OHRTUlpZVDU3blVESkx0QkxFMy94UW96b21nQkJNR2N1QVVs?=
 =?utf-8?B?eWEyL3pxd3ZFcHJWVmxSRkNYejN2UzlhK2FDbjUzTVM4N3VhQmNzdDNBWTNn?=
 =?utf-8?B?V255Y0hFaWhkcTRHL2w1bnNaamxCVEJtWDFyMmtuTXI3QUt4QXlrcU9LYUdB?=
 =?utf-8?B?eFZJSWo5MFcvajVGUVFaMmllamZWQlo1a2dOOTk2ZXgrK00yMmhPTzcyWnhV?=
 =?utf-8?B?Q0FqbEw5T2JpWld3QUx0dUNURjFIQjVvTGZ4S0wvUnRBNnFlajNwdGdnSzAy?=
 =?utf-8?B?QllMTW5vZTVsZXBvTkZlZEdlRUJTTUFvVkRldi93TlRtUjFRSU96UmhrOVdL?=
 =?utf-8?B?S2VrbU9MR1hBZFhCdXRkOHl4SkpyS1MxMklCL1Y5aHJKbTdUTWNFcFJGVkx2?=
 =?utf-8?B?SCtHanl6QWZQbkJJMlEra1hBREYxbTl2cmI1YndUVUF5bWVVWHcrQlVINDU3?=
 =?utf-8?B?Q01HMVRtWTc3dFlwZ25meGtQK3NqNDNEY2UyaDJKKzhyMVYxbkoyTjVPMXBR?=
 =?utf-8?B?cnFIWHFVS2diQi9LZTlxY1QrQWtSOElSM29GSTFFMTI2L1A4NlJSZHhmRm9Q?=
 =?utf-8?B?ellLTENmakNpcjJlc25jdDRka1F0aURnaDhacnVoV3JWR2N5alNuRkQ5Nlgr?=
 =?utf-8?B?dXRQNlhJcFliemtINkN6aTN2UWZMTFM4eG1kWTFxMW83WEh1M1U0R2hRUC9u?=
 =?utf-8?B?OW1CL0xMd3pja1h4bUF2dnU5eDdsR1VhK3lXeU5tSUhtRDE1RVNJM0VvQ1pp?=
 =?utf-8?B?MU9WNldXbE42NUwxenpmNkRlL0FPMkloQlBwMXNjSEkzWGpYQjNPWXBhWFNm?=
 =?utf-8?B?dXl3UVQ5STJQMzJsd0FzbDlndDdvcHNxTjBYRHd4dGlSN053ak5DUUtlVEdj?=
 =?utf-8?B?dWtXOThwNXlIajRLK2RaV1BXTktOZ05IVHdDVXM2anNVeTc4ZCtFcEJ1V0Y4?=
 =?utf-8?B?NVRtQlVDNWhsS0hHcm4vZ2F0OTFWVmZzakVYcC9qT2pWcG5lcGkrWG53T1Jk?=
 =?utf-8?B?VzRRMUJCZHZLdXJSTTdJSm9mYmFlV1pjKzVwNFE3dUdQZnZZcElZZ2FOVzBM?=
 =?utf-8?B?SDVxa0swZkNvdzFKZDJNQWtOdHVyQVhWR3lmME02eWovOTZsRGIwWVg2M2Ja?=
 =?utf-8?B?RVorZ3VzTnFuLzZzL0p6RlhtK0dORVBSSkY1eWY3cmR6N1c4cUc1OTBzc2c5?=
 =?utf-8?B?Qkt0T0tRd05RanB2eTdHZ1dYQ3dzb0RWWng0RFpsUG5hOXJKeGM0RVJqMU5X?=
 =?utf-8?B?Z3UzbWkzZThXWEQ2U2FaQnNUc0w3VGhoeSsxb1hZRTkzTEZSNzFmS3ZBd0ls?=
 =?utf-8?B?T012aFZOUVJTUUNOTFpHam9WK2dWVWo5cEtVUjNBeXpycmo0Njc1amhYWHgx?=
 =?utf-8?B?eUI3dnVobEpZcHk4MkxFT0JjUVBneHlkVFM4enlHUi9laFNxUlRDbWNnV0Jo?=
 =?utf-8?B?V01uSVQ4dmNXVEw3MnloNEdUM1VUQXRCSUNrcnNoQVl3ekpDUlJPb2VjNlpL?=
 =?utf-8?B?VzBacmhYeFZ5VkFGVWdpdDlydDhUMGNEQktvajFwZDE5QWZjRlRRdGZvUTBr?=
 =?utf-8?B?ZDMrazlrWVR4d2tmaFhkZTUyUDNOcVh4RFUzdTFDc1JXUTk3VEN0aWpGN1Nn?=
 =?utf-8?B?U1ZTcEdQNE52Q1FoU2w4UnpWSlh0R2M0aGJkNVpZUVpuWWdJa2sraHZTL3JS?=
 =?utf-8?B?NVF6bFdrUW44QktSa3ZOU2dYYllxZnFFeTgrbVdvZmZ1UHdmak1mU2NKNjNR?=
 =?utf-8?B?ZVRybWd0aXlpSlJBQldBYXpDcU1tKzFFNTNaK3RRSHpUY3FkS2FqUzJZNzBy?=
 =?utf-8?B?ajZzam00dElsNml6blJDM3R0MjN4V25hUW12Y2JuTzFuYnpBNy82WUdhdDFU?=
 =?utf-8?B?UmNzZDFMcUhNVFp5UE5CZGR4NEdmSytZT2g0M2FDK0JwRUw1c1hwREpEaGhh?=
 =?utf-8?B?MjcvMFNFZFl3L0x1dDJOY2NaMnBkcFhtdFZMNVNxNDFmb2syY0h1MHgzOE1O?=
 =?utf-8?B?UlcwQ3ZGcENkRFZ0b0JFSUpNaEpMbFRZZWNXMlk2Q0Y5VmZoL1Zjb3ZweHA0?=
 =?utf-8?Q?r3MXh23DwGMQ2oPqxceq241YO?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b641b37-3c03-40cd-7de1-08da7c53a1cd
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2022 11:13:06.8043
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oH2NzpPxptp6o2Kd56++0CPVMyNWHbaTwTJbuNb9ShhCVTE9LTkMmyUJ6udu8KMA
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1831
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

@Alex was that one already picked up?

Am 25.07.22 um 18:40 schrieb Andrey Grodzovsky:
> Reviewed-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
>
> Andrey
>
> On 2022-07-19 06:39, Andrey Strachuk wrote:
>> Local variable 'rq' is initialized by an address
>> of field of drm_sched_job, so it does not make
>> sense to compare 'rq' with NULL.
>>
>> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>>
>> Signed-off-by: Andrey Strachuk <strochuk@ispras.ru>
>> Fixes: 7c6e68c777f1 ("drm/amdgpu: Avoid HW GPU reset for RAS.")
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 4 ----
>>   1 file changed, 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c 
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
>> index 67f66f2f1809..600401f2a98f 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
>> @@ -285,10 +285,6 @@ void amdgpu_job_stop_all_jobs_on_sched(struct 
>> drm_gpu_scheduler *sched)
>>       /* Signal all jobs not yet scheduled */
>>       for (i = DRM_SCHED_PRIORITY_COUNT - 1; i >= 
>> DRM_SCHED_PRIORITY_MIN; i--) {
>>           struct drm_sched_rq *rq = &sched->sched_rq[i];
>> -
>> -        if (!rq)
>> -            continue;
>> -
>>           spin_lock(&rq->lock);
>>           list_for_each_entry(s_entity, &rq->entities, list) {
>>               while ((s_job = 
>> to_drm_sched_job(spsc_queue_pop(&s_entity->job_queue)))) {