Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp1644436rwb; Fri, 12 Aug 2022 04:43:52 -0700 (PDT) X-Google-Smtp-Source: AA6agR7SIa5HAqh9GsQPIhrgIk0SBXQCcnPyT1tsw9QlBA+RdLX318MV9C+wDrTmLuk8yEC1NOX6 X-Received: by 2002:a05:6402:424d:b0:43e:95d8:eb46 with SMTP id g13-20020a056402424d00b0043e95d8eb46mr3332073edb.306.1660304632244; Fri, 12 Aug 2022 04:43:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660304632; cv=none; d=google.com; s=arc-20160816; b=UxYz/xaMInzyBL/JdvADTs0xZiH9hAmMNDp++9tRT0wTkpd4VtHys8nclrRl2xUXsU q+YcFW6Z08U43hTL0PuvhAdtuntQ7rWiYdLmUiPfLXWRgwdkHdOerkQL+sU5RJ9/OHQr neeVp0OeA+dp1iRlwqPBWoLMGTRnAWDhZ8eVXlAMraPnBgXBQp+H0iFlT491ZKJhj7GA pVZ2bwqUglEmxP4avOzJVG+C0rD6XmKNCh0+3Vq8M8iKM0awYpFZ4JloBBYiEjkfgE8E Szatxu805p1k35UwfixrDMyojDHECUAYkCWb1xqKyOL0pz1PqqPI5uYeT2RN4fFggf7Q puqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=XbW3rClMQd1VZ5y3aEJ9wfyVwkQG6/P5N+J/i4nQkqE=; b=SotZlUVd2zU6nNGgkTjRKN6QN4HwEIrEZs1ygmxg34OGbTewBvCdUPCKDD43bsn4qn 2Xm/F3fF30h1tsIn8NMtF5Gk/erN5SP5I9YeADjqO2IfnEV/h5wFT5miNLtm4aayvzQD gKtrN0zufX79xmel+idnKhRUPMpVHFmdeP/4UNi9iKpyPZ51f/osUtt2IKt4Qje4ZTXv bN57SnDrdSJf/mAFKFP1XkEOZdTVszBhcYfzfmXruFSdNTc8dmxa4bidNLWOlSmigxpm dg0MVYUZdlpCt+Dra7o0DTcUQpd4XClToMRfiWWDOwijd+waiBjbkLDr/LT9oM3yrVX1 cy/g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qw38-20020a1709066a2600b0073046c15d8csi1866772ejc.610.2022.08.12.04.43.22; Fri, 12 Aug 2022 04:43:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234053AbiHLLbu (ORCPT + 99 others); Fri, 12 Aug 2022 07:31:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229739AbiHLLbs (ORCPT ); Fri, 12 Aug 2022 07:31:48 -0400 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CA6EADCCE for ; Fri, 12 Aug 2022 04:31:47 -0700 (PDT) Received: from andrey-lpc.intra.ispras.ru (unknown [93.175.1.152]) by mail.ispras.ru (Postfix) with ESMTPSA id 1767F40737BA; Fri, 12 Aug 2022 11:31:43 +0000 (UTC) From: Andrey Strachuk To: Maarten Lankhorst Cc: Andrey Strachuk , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Geert Uytterhoeven , Helge Deller , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: [PATCH v3] drm/fb-helper: add virtual screen size check to drm_fb_helper_check_var() Date: Fri, 12 Aug 2022 14:30:07 +0300 Message-Id: <20220812113007.224880-1-strochuk@ispras.ru> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Make sure that virtual screen size is not less than physical screen one. Reviewed-by: Geert Uytterhoeven Signed-off-by: Andrey Strachuk --- drivers/gpu/drm/drm_fb_helper.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index 2d4cee6a10ff..ea07c97bc5a9 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -1355,6 +1355,12 @@ int drm_fb_helper_check_var(struct fb_var_screeninfo *var, (drm_format_info_block_height(fb->format, 0) > 1)) return -EINVAL; + /* make sure that virtual resolution >= physical resolution */ + if (var->xres_virtual < var->xres) + var->xres_virtual = var->xres; + if (var->yres_virtual < var->yres) + var->yres_virtual = var->yres; + /* * Changes struct fb_var_screeninfo are currently not pushed back * to KMS, hence fail if different settings are requested. -- 2.25.1