Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <16d50def88afcde1b7323d83e5c9a84d7df0c666.camel@nxp.com>
Subject: Re: [PATCH v3 2/3] drivers: bus: simple-pm-bus: Use clocks
From:   Liu Ying <victor.liu@nxp.com>
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Sascha Hauer <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Saravana Kannan <saravanak@google.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Rob Herring <robh@kernel.org>
Date:   Fri, 12 Aug 2022 20:25:20 +0800
In-Reply-To: <CAMuHMdWLJ4t0GVXNWONwcSWuEBV6EuGTm4a2fumA_8dpD7TQuA@mail.gmail.com>
References: <20220804061133.4110734-1-victor.liu@nxp.com>
         <20220804061133.4110734-3-victor.liu@nxp.com>
         <CAMuHMdWLJ4t0GVXNWONwcSWuEBV6EuGTm4a2fumA_8dpD7TQuA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SjI1UUJHaW5LME03TWJPK050dk9KbkV1SUhpNlk3K2JoZFRzd0lyK25xL29t?=
 =?utf-8?B?V0ZSQmNSNzl6NXdiN3o3ZGwzYlh3OHVvTE5EYlZhTE1VYWxpYXY4OGZHWlA0?=
 =?utf-8?B?WkpKTEQ3SXFwL2JTanBmMVY0ay9VQ1R6WDNiMHVJK3hWV0V0aE5oOGtMWVZl?=
 =?utf-8?B?UERYVXJOdXpKR296c2owL2VqOUJRcGluOVBoaHZzd3lPMGtKVmp0OXdJOVJV?=
 =?utf-8?B?aHZlKzVVYWRxbkI3ellMcDl5TXZla0M2Z0dHYU9lTmNLTndLKzVCL1pRT29v?=
 =?utf-8?B?UktKQjZ0UE01Y1dDZkhady9hUGV2MjVyZEhzYkRReGYrWFBvSi9vOVJmOThv?=
 =?utf-8?B?aC95VXFMcDFrVnBORjI2RC9OcTVDR0NDZjczMFk1bXo2S0NYUjduMjQ2Rmpi?=
 =?utf-8?B?TjVUNzloNjFITnQ4T2U5em04cmFaTk13YXViSTJqTEEweHkxbmJWdlNudjdr?=
 =?utf-8?B?QTFDMk1KSTI2WUhIRmdlTnl4ZXo3bXRKTXQwcEZ0bDlYRmxteHZYTG9XZlIz?=
 =?utf-8?B?MDk1cVJDRnVTRDJZd2ptc0hTMGQvbnZUbzByRWIxeENEeVg3MDRmbmMwOGEv?=
 =?utf-8?B?NitrZmpaUVIzcnFPR24zenRZcUtReVpHaW44aG1OdjhZSUtkUFlSSmZ1SWNp?=
 =?utf-8?B?Ym51TCtCUldrcmdoczZHS2pBL0c4c0dUWlNobTRPTHp4UzNIQlR2c3J5MmZn?=
 =?utf-8?B?T0pvTTRDb1VCYzg3aW1GRHN1Z0pwaVRlcVUyUWlyYnhQcTcrVDc5TGNGalBw?=
 =?utf-8?B?NnhtUWlCdWxCWlZhc0xWTlJWcU5Rb3BuWXFCOVZ5aHFwL3lpRCtIZGJRK2E1?=
 =?utf-8?B?K2VKSWY0aFkxSzlLYXB4bVFibSt0L0E2Tkc1ODhqQ3dMckZYcEFGN1NiYWlQ?=
 =?utf-8?B?dHdVWTBnd3NmY1lJNWV0MzYwK2FwUHd4TDNrSWRLQmxxLzQ1SDFlY2JIZUk4?=
 =?utf-8?B?Wk5VZGRvWmcyRVpWMXg2R2FIRU00NjBwNGV1d1dRK1V1dERkTXZpQXJIVi9Q?=
 =?utf-8?B?N1lCUHNqRGpML0xTdDVVVHRQdFNmYUdPTW5ENU8xdTZjUmcvakxwWklsUk5y?=
 =?utf-8?B?UHA3Yi9GWkdabDVML1hhTTdLdmdmYmpXK1Blanc1eEZSb2Y0eXlLWFdkVVJW?=
 =?utf-8?B?eGJTeVdhdkUycXJJVEJMV3d5SW5YQWpsWEY4cS9rektZc1NyUytaald5YzlE?=
 =?utf-8?B?SU1XOXlyNUdKVEsxdnFwY0RJci91SmJrUFhqb2I3YVk3NzhDaUdQRzEzeVZt?=
 =?utf-8?B?c3RMRUdrUHgwL2FCMmpueHlyTGg5ajE4ZHVJcFFUN205YWZWL3ZjOTByaHJp?=
 =?utf-8?B?WHArS0JXWHhtWHowNDVMZSt0eFBPMGtDKytvSlhNTktVN1RTbU0wK3dtT2tH?=
 =?utf-8?B?MVRWRDZEVE1CNnF4Q1JvdEdnSU41SnJvWXdmdXgvZEN6R1pKSEVRdndzY0o3?=
 =?utf-8?B?WEpYNERUdDFLU2MzMzdSbmQ2djhiTGZNTW0ybXlRR3hxc0l0SUJTRTlyMTJW?=
 =?utf-8?B?L1g4cTkyZjhHanQ2LzduV0RuaE1FaEswcFdScGZwZGc0TUVmR3pHSDJKZjF4?=
 =?utf-8?B?dGkzWXJiL2tnbHhRc3JUYWovMmpCcFhzK2dCTGJab1V3SHh2RlJGQVhPR2c0?=
 =?utf-8?B?TVFoOU5uNjdqbjlMdzJneVFkelpZb0FhTjd6OG1PYjJSVkRMTGFLVzNEK2ZV?=
 =?utf-8?B?anBweXNXZkJmeW9XUlFGNmQ4TStPR2llWC9uZmNvMmNkYi9pMXc3bGZONEVn?=
 =?utf-8?B?Q3Z4aHgzRkY3OUZlclI3MFk5bVQzeUZHYnMvdG9aTG1EVTFxZE9PVFNJK1Vi?=
 =?utf-8?B?QjY5ZUcvT2tPcHc1K0w4SGdobmpQQm9rZWtlUTdtZExKSTcxdG85WHdOVnJ3?=
 =?utf-8?B?ODZzSXZ4L3M5ZSt4eEdldUJkY2o3aHZlUUxnbFk0UFExa1pzRytXRlVOaVQw?=
 =?utf-8?B?MDNzN2QrckJ2Ujl0L1VXeGROTmNwMDZxbHErbUFYZVlsM0pocDdXaUx2Wk5S?=
 =?utf-8?B?d2prQVYyUmM4eHp0VHFTa09Dcm9RU283emthRHBWem1nTkw5cUYvN2FLRVpK?=
 =?utf-8?B?OGM0MzhsV2lkZGlIZ05NQTVPOHZ5aG9hZlQ0bVdkYTFVSXFhdEdwWnVjSW9v?=
 =?utf-8?Q?adf/hKU5tr+KvQJNhP+exQewb?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b1fb1f5b-e609-4120-ed29-08da7c5dbf77
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2022 12:25:31.7456
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1sIO01JEi+HkZm0Opdd7HYehSBG+yfbNxA7iDJFXCHDzdwsqiSW/cwU9URrWHPfEHvcXAC97D7ogBu9l6xSpFA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2665
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Geert,

On Fri, 2022-08-12 at 11:49 +0200, Geert Uytterhoeven wrote:
> On Thu, Aug 4, 2022 at 8:10 AM Liu Ying <victor.liu@nxp.com> wrote:
> > Simple Power-Managed bus controller may need functional clock(s)
> > to be enabled before child devices connected to the bus can be
> > accessed.  Get the clock(s) as a bulk and enable/disable the
> > clock(s) when the bus is being power managed.
> > 
> > One example is that Freescale i.MX8qxp pixel link MSI bus
> > controller
> > needs MSI clock and AHB clock to be enabled before accessing child
> > devices.
> > 
> > Signed-off-by: Liu Ying <victor.liu@nxp.com>
> > ---
> > v1->v3:
> > * No change.
> 
> Thanks for your patch!
> 
> > --- a/drivers/bus/simple-pm-bus.c
> > +++ b/drivers/bus/simple-pm-bus.c
> > @@ -72,6 +89,42 @@ static int simple_pm_bus_remove(struct
> > platform_device *pdev)
> >         return 0;
> >  }
> > 
> > +static int simple_pm_bus_runtime_suspend(struct device *dev)
> > +{
> > +       struct simple_pm_bus *bus = dev_get_drvdata(dev);
> > +
> > +       if (!bus)
> > +               return 0;
> 
> Can this really happen?

Good question. Should not happen in any cases. pm_runtime_init() sets 
runtime_status to RPM_SUSPENDED and needs_force_resume to 0, so
simple_pm_bus_runtime_{suspend,resume} are only called for
simple-pm-bus, not the others. Unless I miss something, I would remove
the check here and ...

> 
> > +
> > +       clk_bulk_disable_unprepare(bus->num_clks, bus->clks);
> > +
> > +       return 0;
> > +}
> > +
> > +static int simple_pm_bus_runtime_resume(struct device *dev)
> > +{
> > +       struct simple_pm_bus *bus = dev_get_drvdata(dev);
> > +       int ret;
> > +
> > +       if (!bus)
> > +               return 0;
> 
> Likewise.

... here.

> 
> > +
> > +       ret = clk_bulk_prepare_enable(bus->num_clks, bus->clks);
> > +       if (ret) {
> > +               dev_err(dev, "failed to enable clocks: %d\n", ret);
> > +               return ret;
> > +       }
> > +
> > +       return 0;
> > +}
> 
> The rest LGTM, so
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks,
Liu Ying