Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jens Axboe <axboe@kernel.dk>
To:     rafaelmendsr@gmail.com, hare@suse.de
Cc:     linux-block@vger.kernel.org, hdanton@sina.com,
        linux-kernel@vger.kernel.org,
        syzbot+31c9594f6e43b9289b25@syzkaller.appspotmail.com
In-Reply-To: <20220811232338.254673-1-rafaelmendsr@gmail.com>
References: <20220811232338.254673-1-rafaelmendsr@gmail.com>
Subject: Re: [PATCH] block: Do not call blk_put_queue() if gendisk allocation fails
Message-Id: <166030813180.891934.12259200339444300073.b4-ty@kernel.dk>
Date:   Fri, 12 Aug 2022 06:42:11 -0600
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Thu, 11 Aug 2022 20:23:37 -0300, Rafael Mendonca wrote:
> Commit 6f8191fdf41d ("block: simplify disk shutdown") removed the call
> to blk_get_queue() during gendisk allocation but missed to remove the
> corresponding cleanup code blk_put_queue() for it. Thus, if the gendisk
> allocation fails, the request_queue refcount gets decremented and
> reaches 0, causing blk_mq_release() to be called with a hctx still
> alive. That triggers a WARNING report, as found by syzkaller:
> 
> [...]

Applied, thanks!

[1/1] block: Do not call blk_put_queue() if gendisk allocation fails
      commit: aa0c680c3aa96a5f9f160d90dd95402ad578e2b0

Best regards,
-- 
Jens Axboe