Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Fri, 12 Aug 2022 16:06:47 +0200
Message-Id: <CM43WTWNP8MM.3145TGVN4208B@otso>
To:     "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
        <linux-arm-msm@vger.kernel.org>
Cc:     <~postmarketos/upstreaming@lists.sr.ht>,
        <phone-devel@vger.kernel.org>, "Andy Gross" <agross@kernel.org>,
        "Bjorn Andersson" <bjorn.andersson@linaro.org>,
        "Konrad Dybcio" <konrad.dybcio@somainline.org>,
        "Rob Herring" <robh+dt@kernel.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        "Matthias Kaehlcke" <mka@chromium.org>
Subject: Re: [PATCH] arm64: dts: qcom: pm6350: add temp sensor and thermal
 zone config
From:   "Luca Weiss" <luca.weiss@fairphone.com>
References: <20220812114421.1195044-1-luca.weiss@fairphone.com>
 <81ae6a31-1f37-a677-f8f8-2340e37d3a63@linaro.org>
In-Reply-To: <81ae6a31-1f37-a677-f8f8-2340e37d3a63@linaro.org>
Precedence: bulk

Hi Krzysztof,

+CC Matthias Kaehlcke (author of patch mentioned further below)

On Fri Aug 12, 2022 at 3:36 PM CEST, Krzysztof Kozlowski wrote:
> On 12/08/2022 14:44, Luca Weiss wrote:
> > Add temp-alarm device tree node and a default configuration for the
> > corresponding thermal zone for this PMIC. Temperatures are based on
> > downstream values.
> >=20
> > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> > ---
> > With this config I'm getting this in dmesg, not sure if it's a warning
> > that should be solved or just an informative warning.
> >=20
> > [    0.268256] spmi-temp-alarm c440000.spmi:pmic@0:temp-alarm@2400: No =
ADC is configured and critical temperature is above the maximum stage 2 thr=
eshold of 140 C! Configuring stage 2 shutdown at 140 C.
> >=20
> > As far as I can tell, based on downstream dts this PMIC doesn't have an
> > ADC.
>
> You configure 145 and driver believes 140 is the limit, so it seems
> warning should be addressed.

Hm...

>
> From where did you get 145 degrees as limit? Downstream DTS?

Yes, downstream dts[0].

From what I can see in the downstream driver, it always disabled this
"software override of stage 2 and 3 shutdowns"[1]

In mainline only since f1599f9e4cd6 ("thermal: qcom-spmi: Use PMIC
thermal stage 2 for critical trip points") this check exists, which is
not part of downstream (wasn't in 4.19 yet), where this software
override tries to get enabled so that thermal core can handle this.

Any suggestion what I can do here? Maybe looking at msm-5.4 sources (and
associated dts) might reveal something..? Maybe newer SoCs/PMICs have a
different config?

Regards
Luca

[0] https://android.googlesource.com/kernel/msm-extra/devicetree/+/refs/hea=
ds/android-msm-barbet-4.19-android12L/qcom/pm6350.dtsi#126
[1] https://gerrit-public.fairphone.software/plugins/gitiles/kernel/msm-4.1=
9/+/refs/heads/kernel/11/fp4/drivers/thermal/qcom-spmi-temp-alarm.c#251

>
> Best regards,
> Krzysztof