Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 12 Aug 2022 10:24:47 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Martin =?utf-8?B?TGnFoWth?= <mliska@suse.cz>
Cc:     linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf: Print debuginfod queries if -v option is used
Message-ID: <YvZUnxjDo0JxeRdE@kernel.org>
References: <2983e2e0-6850-ad59-79d8-efe83b22cffe@suse.cz>
 <325871cf-b71f-6237-8793-82182272ece8@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <325871cf-b71f-6237-8793-82182272ece8@suse.cz>
Precedence: bulk

Em Fri, Aug 12, 2022 at 01:43:53PM +0200, Martin Liška escreveu:
> When ending a perf record session, the querying of a debuginfod
> server can take quite some time. Inform a user about it when
> -v options is used.

Thanks, applied.

- Arnaldo

 
> Signed-off-by: Martin Liska <mliska@suse.cz>
> ---
>  tools/perf/util/build-id.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/build-id.c b/tools/perf/util/build-id.c
> index 0cc68cdd84c8..d1cfce0613ee 100644
> --- a/tools/perf/util/build-id.c
> +++ b/tools/perf/util/build-id.c
> @@ -653,7 +653,9 @@ static char *build_id_cache__find_debug(const char *sbuild_id,
>  
>  #ifdef HAVE_DEBUGINFOD_SUPPORT
>  	if (realname == NULL) {
> -		debuginfod_client* c = debuginfod_begin();
> +		debuginfod_client* c;
> +		pr_debug("Downloading debug info with build id %s\n", sbuild_id);
> +		c = debuginfod_begin();
>  		if (c != NULL) {
>  			int fd = debuginfod_find_debuginfo(c,
>  					(const unsigned char*)sbuild_id, 0,
> -- 
> 2.37.1

-- 

- Arnaldo