Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp1860068rwb; Fri, 12 Aug 2022 08:00:06 -0700 (PDT) X-Google-Smtp-Source: AA6agR5/QmcmayvJgWVy6xi95x/VJYIW78OjKDQYDh/M8aGvPV5x+Twm+8nKHyBJcsoabRxQ8rmG X-Received: by 2002:a17:907:929:b0:731:3bb6:d454 with SMTP id au9-20020a170907092900b007313bb6d454mr2932652ejc.96.1660316406221; Fri, 12 Aug 2022 08:00:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660316406; cv=none; d=google.com; s=arc-20160816; b=FPnQKS8vzwJ1Wr1TvRydpCxbjC4msBzuFiAaitC1csE/c9yI2gVfn4S8GBg7lFCt6e mhmjYbX0IIFK0zVE9Ueb94gABMYDi0Ra7RJeZ5KYjxbIQW/DtPAmWuzzrHdAb1ErhIaF aaMhSBeWAtQSG9r05EUXd/sExLJBt8/YbtfQUCJqaCyzjyKRYOgXB5TxeFq9Vp0X/pQL 0untb2Mqf5lV83XqxZi4E2tSw8qfr9uq0MXZlrYdb0DLK9uSyoIQQQpdynK7DTRLTJ1M wztkFeciC2LCtuWET7drLFBvmGvxXZ9hCB9A+eJ6NdFT+EgUfXQXjg2nU0l68Oj0kmnI oYGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ZE4cCkZbxROOHz/5wltDy/Y6nvpYXY5aOAOz/2fLJ44=; b=IX3N00M0GWXCf4huDOG+bGBIeSk2hop69PpsOA/2nhN6XMgpG/eVh9ydDaVgPpLWzG iKXJUbZEaGf6TVoBlk5JPXOFul6egStd983OzpRJVxl0yOmwLB///H+NY/vhbWcDdK7g Kn+fLRlmNk8oGXcRtznVcRE/QrwIui+fE0yF2zC13DlVN3cZUW7XVMlxSsex6DvNF7Td 0mON51RDundFQaJ9oCL8WbdqTeEFGa/UuGxe/r5fOARegv0KhvOq0HuFVTAkZH5zFJwt pQNmj0063gr5/t8JJ6A6+QEpAMVPWTOAE63bmVTC5dmyH/NSGHKb0dgf3Sflgbshq4wa jxuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=Yi0gsn4G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o16-20020a170906975000b00732989ac0absi2616884ejy.42.2022.08.12.07.59.40; Fri, 12 Aug 2022 08:00:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=Yi0gsn4G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231271AbiHLOqd (ORCPT + 99 others); Fri, 12 Aug 2022 10:46:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237430AbiHLOqb (ORCPT ); Fri, 12 Aug 2022 10:46:31 -0400 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 948F29A94A; Fri, 12 Aug 2022 07:46:30 -0700 (PDT) Received: from zn.tnic (p200300ea971b98b3329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:971b:98b3:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 384A61EC064C; Fri, 12 Aug 2022 16:46:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1660315585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=ZE4cCkZbxROOHz/5wltDy/Y6nvpYXY5aOAOz/2fLJ44=; b=Yi0gsn4GR+2/dcxTJLGyvLnJquvCP2enYPktmOSY+yKWcnm9WSOPESeLz7O7AHCumNC+C1 ZldSCK0EOgHk4x0Xj2bGHWB3W5e7c3NnpsoAWSNihzNiTLwhFQ84SAYtxGNc9yDAGni/zx jvizcxgz9sWb2+CsjxtOhLEUfJjtF5Q= Date: Fri, 12 Aug 2022 16:46:24 +0200 From: Borislav Petkov To: Jia He Cc: Ard Biesheuvel , Len Brown , James Morse , Tony Luck , Mauro Carvalho Chehab , Robert Richter , Robert Moore , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, devel@acpica.org, "Rafael J . Wysocki" , Shuai Xue , Jarkko Sakkinen , linux-efi@vger.kernel.org, nd@arm.com, toshi.kani@hpe.com Subject: Re: [PATCH 1/2] efi/cper: export several helpers for ghes edac to use Message-ID: References: <20220811091713.10427-1-justin.he@arm.com> <20220811091713.10427-2-justin.he@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220811091713.10427-2-justin.he@arm.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 11, 2022 at 09:17:12AM +0000, Jia He wrote: > Before modularizing the ghes_edac codes, we need to export several efi/cper Who's we? Please use passive voice in your commit message: no "we" or "I", etc, and describe your changes in imperative mood. Also, pls read section "2) Describe your changes" in Documentation/process/submitting-patches.rst for more details. Also, see section "Changelog" in Documentation/process/maintainer-tip.rst Bottom line is: personal pronouns are ambiguous in text, especially with so many parties/companies/etc developing the kernel so let's avoid them please. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette