Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp1932139rwb; Fri, 12 Aug 2022 09:04:22 -0700 (PDT) X-Google-Smtp-Source: AA6agR5PmY+bB6S0t6x13kmTDjumBJJa21Q2pPh2yryU1pkcNcCSXmYXdzt5Ifcn81k2qvNIAKOL X-Received: by 2002:a17:907:724b:b0:731:48b3:6fed with SMTP id ds11-20020a170907724b00b0073148b36fedmr3189586ejc.405.1660320262611; Fri, 12 Aug 2022 09:04:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660320262; cv=none; d=google.com; s=arc-20160816; b=uQROpYVIt2Xj3lHBfmTH4lVV7rn3DTl4sNHbm9JWrvgYcl44Rv+sy/rVxwOKmLUDUY flcNc/5qcbH16W3NMR7tEG1hP70v4cZCOQFO/aiXlidPSTmEpffE+EXsh3B+udASeF3z JYwPGeHO3nT69rr6rYqd+yUkGYpY6PmRpC3+/O/Z3dwT1HH+0j6k3833LHmeOzBrYTlU fDvz9Ej3dBCnQr24gM2v7FQeKLLnQpHNWW/AsEWFQAwvKDhPwUO9GPOTqMcNRhGI+eaD I1npYQ7SsCT0gGutsvLkxUHtzFz+tMjfDusy7zWpQiG+dtfPco6g+hzOolgcgJV52k8B BwTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=hqEf11FJbSRO12gzNjyGGnzzu3Dh13mZ7Ss/ZM/qt3w=; b=mXMeSnHYhEj4Y+4Nz/wLN+XiCgmaqVxvnCtc+2YAanE000GDVsNTio47UFV/J87Crv /zVHhF/algem+eVILqTiiVYykjkauLd/1/bWBmUfEBshAvzvByd6RcqsFb5v8348NikV kAKI2UZ4TxvEqpXF6ENjeJjUPvg11Ws+E5QR1zZ9oW45y/OVDhQs8+mB9b8CLC+ptHom GhD8yHOb20x9TD+HJ0ym0iPLFv9adx36RtQC6IC6c4cCBcXyY1UQvpQO/3/n7XYtbZoi tqVT3Vue8jXBNSHVjnqHJNKAB5ThPO4Un5+8FAb7g+3o0j1ptHCNyQ11dRrdd155d9+r 5VRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QUYmnY7l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nd32-20020a17090762a000b007306e4fc2f2si2168812ejc.374.2022.08.12.09.03.55; Fri, 12 Aug 2022 09:04:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QUYmnY7l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238820AbiHLPss (ORCPT + 99 others); Fri, 12 Aug 2022 11:48:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238807AbiHLPsq (ORCPT ); Fri, 12 Aug 2022 11:48:46 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05748A4071 for ; Fri, 12 Aug 2022 08:48:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AE2C8B82471 for ; Fri, 12 Aug 2022 15:48:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DDBE9C433D6; Fri, 12 Aug 2022 15:48:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660319323; bh=cvTUSPVXoJaKfemksKrV/He9kW2/6kMVns4u0Rjwb4U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QUYmnY7lanhhpzrJoziQyLihzTxMt1xP5p04ujfx9cyJTKP8DcRnUv3+Bak3+/Gfd HNHcoqnH2AYZ2+ZlCtR5LuNDF22Uq5TfeYgta0c6W56u5j8b2yHddNaFDilRT+KCVQ 6CpsM9ZSQyDzWs27m6VDnF2ZhuoJJjhZn8tuGX4MUSQJz1emqpFfUC3mkxgXokTXBe j4Qv8zDzfv8vHJtWyOrkVruGH8U3Fa+Q4wzcwtwHbQP2BWMXtkPEM6gap1robX1Y8a 4U3/01qg7xdenf+PK2QRF+msgtnwAmS1TeiO7U9MMhhwG4KANZZHCKWA3SSETVCOOI 9ytSxCl8WKlQQ== From: SeongJae Park To: xiakaixu1987@gmail.com Cc: sj@kernel.org, akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kaixu Xia Subject: Re: [PATCH] mm/damon/core: simplify the parameter passing for region split operation Date: Fri, 12 Aug 2022 15:48:41 +0000 Message-Id: <20220812154841.116570-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <1660290073-26347-1-git-send-email-kaixuxia@tencent.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kaixu, On Fri, 12 Aug 2022 15:41:13 +0800 xiakaixu1987@gmail.com wrote: > From: Kaixu Xia > > The parameter 'struct damon_target *t' is unnecessary in damon region > split operation, so we can remove it. Good finding. But, 't' is used while 'ctx' is unused in 'damon_split_region_at()' and 'damon_split_regions_of'. Below code change is also removing 'ctx', not 't'. Could you please update the commit message for that? Also, please fix the kernel test robot reported issues together: https://lore.kernel.org/damon/202208121823.8YTRPB1J-lkp@intel.com/ Thanks, SJ [...]