Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220812173526.15537-1-tharvey@gateworks.com>
In-Reply-To: <20220812173526.15537-1-tharvey@gateworks.com>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Fri, 12 Aug 2022 14:50:51 -0300
Message-ID: <CAOMZO5B5OMFMjXuM6Lk7iy_f3GnvWC-O_0uEds3jD-5oTtjMZA@mail.gmail.com>
Subject: Re: [PATCH 1/6] arm64: dts: imx8mp-venice-gw74xx: fix CAN STBY polarity
To:     Tim Harvey <tharvey@gateworks.com>
Cc:     Shawn Guo <shawnguo@kernel.org>,
        NXP Linux Team <linux-imx@nxp.com>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Tim,

On Fri, Aug 12, 2022 at 2:35 PM Tim Harvey <tharvey@gateworks.com> wrote:

> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> index 521215520a0f..de17021df53f 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> @@ -123,8 +123,8 @@ reg_can2_stby: regulator-can2-stby {
>                 pinctrl-names = "default";
>                 pinctrl-0 = <&pinctrl_reg_can>;
>                 regulator-name = "can2_stby";
> -               gpio = <&gpio3 19 GPIO_ACTIVE_HIGH>;
> -               enable-active-high;
> +               gpio = <&gpio3 19 GPIO_ACTIVE_LOW>;
> +               enable-active-low;

This 'enable-active-low' property does not exist. Just remove it.