Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <51d4408b-14f5-f6a8-80cf-d23cdb0a7c69@nvidia.com>
Date:   Fri, 12 Aug 2022 11:02:42 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH v4 1/2] mm/gup.c: Don't pass gup_flags to
 check_and_migrate_movable_pages()
Content-Language: en-US
To:     Matthew Wilcox <willy@infradead.org>,
        Alistair Popple <apopple@nvidia.com>
Cc:     linux-mm@kvack.org, akpm@linux-foundation.org,
        linux-kernel@vger.kernel.org,
        "Sierra Guiza, Alejandro (Alex)" <alex.sierra@amd.com>,
        Chaitanya Kulkarni <kch@nvidia.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Felix Kuehling <Felix.Kuehling@amd.com>,
        Jason Gunthorpe <jgg@nvidia.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Muchun Song <songmuchun@bytedance.com>,
        Ralph Campbell <rcampbell@nvidia.com>,
        David Hildenbrand <david@redhat.com>
References: <487960bf67c7273ff5606c76f73bb51271bc7b90.1660269441.git-series.apopple@nvidia.com>
 <YvZOSUrXoeYnuCyg@casper.infradead.org>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <YvZOSUrXoeYnuCyg@casper.infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K0tsRzNSY3M5SjZoSWFGY1ZkcS9aNWlSVFJ3Z040ZU5MYlVOQUNDNm1QL25r?=
 =?utf-8?B?WThvOU94QXIrMHBVOEFJMERnVUw5K3dqMDZDSU4yVlFXMDBybjlaYUR2U0Jq?=
 =?utf-8?B?akNkYk5aVHVBTWl2TStnU2FMcGNOT2FzKzNNSk5Gd2xWb1BHSmpmcFNEZkxG?=
 =?utf-8?B?ODliaXVwNWxpS3pOTk9UaXJVckQ1c0d5cDRFd2h1aVF2aU1oKzYvMXV0aUFu?=
 =?utf-8?B?RE01RVRoRnlOYjQ1V0JEcm5WNE5FVXFDUEljWUFSOTFwUU9qejUzcEFicTVH?=
 =?utf-8?B?N3VlT3ZwbkIrc3R0K1dNRk1kaXdENUlXTHJnY3EwUldTdlRIc3pQalF6aDVI?=
 =?utf-8?B?alBuelJTVUZxWHJMb20rd1hHZ1hZb3ZNRmIrTFlYR3R1N1pPV09qa2hGNXpr?=
 =?utf-8?B?R1hXaDd4YVRQQUFXU1BhQnJrYmxTWXBUbzNVaU9lS3JvV1lrak1ZT1Y4V1dY?=
 =?utf-8?B?LytaL2JRN1ZyT0tMYlVxOFcyUDY4WTJPaFRRT0lXRVgvNnE4U251N2JuRmhB?=
 =?utf-8?B?THVIRDVXbVJGUmxnditJc1RXUVlUcTlHN0xVMlo5WVZiMFkyZ0NQbUpmQ0VH?=
 =?utf-8?B?bitwQU13OVdGUmpQNVNBVWIraHR6SWhpL2VaVzYwM0hES0E3Sjg5UmlyTGNU?=
 =?utf-8?B?dkUyL2hxR2Q3QkdNSXdlMC9FeXdIS2pNVXJ3cFJQbytWbnRTQTl4bFpQdmRi?=
 =?utf-8?B?ZUZVencvT05TcVByVDllV3FxanpabW82WlMzdjdWR0sxZzRXSGZ6TjVhOHp3?=
 =?utf-8?B?QUdqWXg4RWJRWnZUZU5TVmg0amZ2c2pKWHV1WDRVeDNva3lvbDFSUk9TM1F5?=
 =?utf-8?B?aXhKYmNkRTVxUnRxbHpsR2N3bkFnb1JidmhoOU1XTHhLcWEwd0o5a0laaDBn?=
 =?utf-8?B?UkFNeWZEdTFzcyszWm8vQlpzOVFwWWNXTnd3UGhueWhjUXM0YmtuZ1RPYUFJ?=
 =?utf-8?B?VDRhK0FRcEhua2hxcm9YaXBCR3hlZ0wwWlZEUGtTY1BQRWtiZUJHbXdBZ04w?=
 =?utf-8?B?Tkd3NitDR2NabUl2R2tXWHhzUHllZ3NHNVlNaHF1b3pva2VsY1JtZWgzVGlV?=
 =?utf-8?B?TlJ5ME0xMUVER3ZnUWlvOHJxVGd1b3ZScFdnRXNuS0ZNODk4dllZc1BSVzQz?=
 =?utf-8?B?OFpIWm96L1VJcmFPN2EvK2lEaGxMZDdSd0V6TGFNOVZ1SWMvVUo2Qy9TdkFP?=
 =?utf-8?B?ZDVsWDJlNFpkT3Y1ekI1OFhERU81UllFSXpQTzdQdk9ybmFpTFVLd3hJR3Yx?=
 =?utf-8?B?RlV3Q3EwN2tRZVlINEhuYkp3NjM4VG1CN08ySGlhU1FNeHBHeWh0NktNSlRV?=
 =?utf-8?B?cTMvZnBqMm96VVJrTThJcWpxeWFla1lkWTlYY1pKdjlVYzdyVHpCSGh1dzBC?=
 =?utf-8?B?ZmpMODNKc2NSQmlnbHhqVDJMWE1XQnBlQ3cvMzVpd2hSOCs5ZFZoTWxMZkQz?=
 =?utf-8?B?SFUwVHIzbmJPTVU0QmFQdlIydXgxaW1kaS9hazlrd201MmluNnBwSk1hNENt?=
 =?utf-8?B?QkNNbG8vcU5Uc1Iwekx5V3I0OVNTengvenZpT0txTHBOb2hWRGpWblM4V2g0?=
 =?utf-8?B?NHV1M0ovL3lWRTRuc2JGSCtEYnhFelhyYldvUTR6UCtzZmcycmg4cjdGUXhy?=
 =?utf-8?B?MTYzYkVjZVEya2JhOXpBZ2JEMlBOUS9OUEM2bnhwVW1mc2M4eU05cmRSSllq?=
 =?utf-8?B?b3pmR0ZMcnI1ZmxFNEVUQ0NpS0Q4MTlwYXBNNWlzT2RiNzRyWXdBK2tPMzU1?=
 =?utf-8?B?THNZbjI5eHRwUGttZ0RSdnU1WVFsVUZVWjcrd2JFZGpXMlBrYkFzb3ZnSEhI?=
 =?utf-8?B?NWZyczVPSmx0c3ZMUE04WWpIaS9PUXNzd3lUbzVGNm5TbmU2bEZQT200K3oz?=
 =?utf-8?B?Q29Db1NsN0RCVzhlS051UFRwOERoL0hlVE5CYUxLR2h2bkZzQ3ZlT3JVUHY5?=
 =?utf-8?B?NXRPMkpldzFxRVNCY1pENjJ5bGRxTlM0a3JUVjFIL1Rtb3ZESVh6R1NLd3dE?=
 =?utf-8?B?SStGdm5vc0hCeUhGYnFGWFZSeC91bGIzdm8yRUdFb29YZitWbTk2end6THFa?=
 =?utf-8?B?cDhTUlMxeHgzZ1RVMVpYemlhZmlPWklPN2hyelJNWGg4MDYwbTVmaWtPQ1Iw?=
 =?utf-8?Q?WC5ozgK2WLV4gNcuKnySvv6JA?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f884319-71c1-4f4f-0529-08da7c8cdbd8
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2022 18:02:45.4322
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UKWSwu/HuXKJzY58BOJOfKs0IovOM4peGl9KlcRMETbk1zCY68yvxqEFZnfyu7+Y1mUSXaRjzxT3pWt4WEyjLw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3694
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/12/22 05:57, Matthew Wilcox wrote:
> On Fri, Aug 12, 2022 at 12:13:08PM +1000, Alistair Popple wrote:
>> +			get_page(&folio->page);
>> +			unpin_user_page(&folio->page);
> 
> https://lore.kernel.org/linux-mm/YvJddHPZsh7Lwzps@casper.infradead.org/

The above fix shows up in patch 2/2. I noticed during review that
it was applied to a different patch than the one you replied to,
but figured it didn't matter which patch picked up this fix, since
the problem precedes either patch.


thanks,
-- 
John Hubbard
NVIDIA