Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 12 Aug 2022 21:06:31 +0200
From:   Pavel Machek <pavel@ucw.cz>
To:     Yu-Jen Chang <arthurchang09@gmail.com>
Cc:     andy@kernel.org, akinobu.mita@gmail.com, jserv@ccns.ncku.edu.tw,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] Optimize memchr()
Message-ID: <20220812190631.GA1347@bug>
References: <20220710142822.52539-1-arthurchang09@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220710142822.52539-1-arthurchang09@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Precedence: bulk

Hi!

> This patche series optimized "memchr()" and add a macro for 
> "memchr_inv()" so that both funtions can use it to generate bit mask.
> 
> The original implementaion of "memchr()" is based on byte-wise comparison,
> which do not fully use 64-bit or 32-bit register in CPU. We implement a
> word-wise comparison so that at least 4 bytes can be compared at the same
> time. The optimized "memchr()" is nearly 4x faster than the original one
> for long strings. In Linux Kernel, we find that the length of the string

Well... how much slower is it for short strings?

> searched by "memchr()" is up to 512 bytes in drivers/misc/lkdtm/heap.c.
> In our test, the optimized version is about 20% faster if the target
> character is at the end of the string when going through a 512-byte
> string.

"What is the average length passed to memchr" would be more useful question.

Best regards,
								Pavel