Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5256fc4b-437b-f7fb-55b6-abab091e0182@amd.com>
Date:   Fri, 12 Aug 2022 16:54:04 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: Selecting CPUs for queuing work on
Content-Language: en-US
To:     Tejun Heo <tj@kernel.org>
Cc:     Philip Yang <Philip.Yang@amd.com>,
        Lai Jiangshan <jiangshanlai@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>, Dave Airlie <airlied@gmail.com>
References: <82233e68-106f-39e9-b20d-7794eb7a8933@amd.com>
 <Yva4g3V2jAP0NKcY@slm.duckdns.org>
From:   Felix Kuehling <felix.kuehling@amd.com>
Organization: AMD Inc.
In-Reply-To: <Yva4g3V2jAP0NKcY@slm.duckdns.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OExkSmpCV2NBOFdYRFhQaVJGQnpRRWQvcjB3NkpqMDgzLytsMGZOZWx6MjJM?=
 =?utf-8?B?THpuK3phZC9ZMkRZN0QrdzhJZ2xqYVlmZkUrMkdpZExMa2hPVUNLT3lHeGQ4?=
 =?utf-8?B?SDl4VkdSS0lqenIvYkhrRGtVTTlxSis1cVVSb2N5QnhpYk9HRFZpaGdaM0k4?=
 =?utf-8?B?SVlzOW9aWjlUWmVMYVhGSkxXUkRpdEFjaVdUQkp2ZW5lZXVGMHNHUW9xK2VS?=
 =?utf-8?B?WnZUSk8rbWlFOGhhZUdpeXY0dFg1VnJjaGdoWkVZekt3VFdmazUyWUVqYWZm?=
 =?utf-8?B?UlUxdjdYOXFaRmdjVXVsdWx5ZXN0V0IrcUlJV3ZYMEpNdkhVY1BReUxOaHhp?=
 =?utf-8?B?OW5ic05wNk05ZWtJVUlhQjQvRkVOcm5STjhrZGRDeEY3aTAxeVM1djBVOEVm?=
 =?utf-8?B?N0JlQXVUVFRVOHNvV2xENWt4aVJwR21FYTl0Uml1TW15R1BpRXV0YmFvalVR?=
 =?utf-8?B?Q3pFUEIwN0FqL1p6Q1VkTUpBV09ZSWJ3MEY4eE41YlNSai9qRi8rSjVqOXJk?=
 =?utf-8?B?TGxIcjNSbUwreHRhb0pScFo3bVhjOWVlUVVSb3dPaWRRM0pMNTk3ak9PZFFt?=
 =?utf-8?B?N0RHWnJGcGRCRlZPaWpNcUxqM3ozTm9ERUhZcTFlaEJnbEpXRmxoRGR5bmpS?=
 =?utf-8?B?N3g1TFo4QnZYeUkvYlZQVGRDaWZwVzlWTDV1SUtMN3ovSmhjYWN3eVl1ZXJC?=
 =?utf-8?B?dm1aV2xjVnJBSXN0a290c2ZzM1ZvbXFlOEd3LzBIUXE3QjljaFBkQ1dOZ2Q2?=
 =?utf-8?B?ejZNeVlRK2RCam9JTG5JY3g5dDN1c3lHMFhZdWNwTFdKQ3RONGFvYzAzT2pw?=
 =?utf-8?B?T2E1Z2RNNm0wQmVEZVVPV1pvcmxmZ1RTUjVQU2RQUm4rQkgvVXM4RFBhOFNC?=
 =?utf-8?B?cUVXOS9peUU4ZzE5Vks2QVBHaFZBM091TmQ0eFVLbTZ5aS9KUFU4WnVsUDBq?=
 =?utf-8?B?OVVQSXNsUHY2d1Z3RzBnU21BV1hjZm5jMzNPK1llYUJMYUR1Ny9ySFhLK09P?=
 =?utf-8?B?SVlTUGhpZmRqK0NZc2kvM3JGdEVucUF5S3FocWhiQWVZWlFNUnV0RlNnYlha?=
 =?utf-8?B?V1owMzBuMnNoUWVINUp6NzZYd0Q1aEgzOTl3UWhiV1RCN3gzcGw3dUQ2VEFS?=
 =?utf-8?B?NGRqaUxiWEhGU2FzTFh4czFvenE2SE9EeTFJWldXdDJMRjVYb2JwdkNQanFo?=
 =?utf-8?B?L3VOcStlWjNGRE5Qbjc3ajl1UUQzeC9TUVFZd2Vwa3ZtTGtMdFNQeVlwcCs3?=
 =?utf-8?B?R0l4NTVrRlJ4blhsM0J2UmEzR2NGV3hadXNsMnRKVlZTSElMV2x2emdrbFFG?=
 =?utf-8?B?R3kzSVlZMU9GZGhVc0plKzJ6anhFTWpVNTd4MG05Y25mOU5JZWQ0aEx3UDFr?=
 =?utf-8?B?MkRtdlozTlFPYjNqVnRrZ0FodWpOcktDTkJHNmsvL0NWdy9wSHBnKzlhK1NR?=
 =?utf-8?B?bEZtbVZldmkwWGNCaFNMR1ppb2k2a2tzUXc0R0xMeW1oVGlDZUJ2WmJVT0hi?=
 =?utf-8?B?aGNiYWVZdlBIWTBNQmhjd245RHhWczVpekVkTlNqc2M1OFQ1aWRhc012N3RL?=
 =?utf-8?B?dGUweVJSQXg1VEJpeHVqVVVNWnRENkRUQzI2THRYRWxsNE1TR2hyUWdSb3k1?=
 =?utf-8?B?c1Bqd2w2dE52bG1QNjNSbDdNV0NSY1lQVFhhMktuZzd6ODJZeHNQcFZrRGF4?=
 =?utf-8?B?WGVvK3BIQVNsNkM4bWtJNk1KazQxY0ljNXAvdXM1MzRnMTdXRHFCb2U0ZW8x?=
 =?utf-8?B?MkRmcXYzQnJkOHQ2Nk15ZmRMZzFqSHhNQU9RK1ZKcVhvcmJ2c2E2V0s3VUlS?=
 =?utf-8?B?QkF4Wm96L2RJTnUvd0VpWVBpUTFCdzhpdExBbzM2TUxsamE2NE5GQktjdnhS?=
 =?utf-8?B?YXZvVzYyd3VLNWN4NmM1UUZJV0VGUEJ0QzNKZkdsdUxqeWFQY0FqUTUwZlJp?=
 =?utf-8?B?OWJZbld0RlFSM1p1Yjh5WWVEQWZPbWRkYmx3NzNKRkhoeEt6aTk4dHoyVlZr?=
 =?utf-8?B?NmlxOGJIbjFGQ1BFMVRlbWdVQ3UvanlNOUxaLzFZcEFuRXN6M09pYTc0MDVK?=
 =?utf-8?B?UHo1NkE4WTJxWFV2LzFXUmxCK0kyVnNuZEJrR3ZURzBhdkc3S2tYb08zUGg4?=
 =?utf-8?Q?j3A/aTxpqog9d6sythhZT2KXC?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8447ac8d-d800-4b71-0db8-08da7ca4cb85
X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5115.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2022 20:54:05.8259
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZiF9Td4Opd/fDWdP9xi5rPL55gGPgLoF57Jb4rS63Wdculai93PaSvrMFLfcJQkHcO5DXobqYCFFrE1rYVNedw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1201MB0004
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-08-12 16:30, Tejun Heo wrote:
> On Fri, Aug 12, 2022 at 04:26:47PM -0400, Felix Kuehling wrote:
>> Hi workqueue maintainers,
>>
>> In the KFD (amdgpu) driver we found a need to schedule bottom half interrupt
>> handlers on CPU cores different from the one where the top-half interrupt
>> handler runs to avoid the interrupt handler stalling the bottom half in
>> extreme scenarios. See my latest patch that tries to use a different
>> hyperthread on the same CPU core, or falls back to a different core in the
>> same NUMA node if that fails:
>> https://lore.kernel.org/all/20220811190433.1213179-1-Felix.Kuehling@amd.com/
>>
>> Dave pointed out that the driver may not be the best place to implement such
>> logic and suggested that we should have an abstraction, maybe in the
>> workqueue code. Do you feel this is something that could or should be
>> provided by the core workqueue code? Or maybe some other place?
> I'm not necessarily against it. I guess it can be a flag on an unbound wq.
> Do the interrupts move across different CPUs tho? ie. why does this need to
> be a dynamic decision?
In principle, I think IRQ routing to CPUs can change dynamically with 
irqbalance.

If this were a flag, would there be a way to ensure all work queued to 
the same workqueue from the same CPU, or maybe all work associated with 
a work_struct always goes to the same CPU? One of the reasons for my 
latest patch was to get more predictable scheduling of the work to cores 
that are specifically reserved for interrupt handling by the system 
admin. This minimizes CPU scheduling noise that can compound to cause 
real performance issues in large scale distributed applications.

What we need is kind of the opposite of WQ_UNBOUND. As I understand it, 
WQ_UNBOUND can schedule anywhere to maximize concurrency. What we need 
is to schedule to very specific, predictable CPUs. We only have one work 
item per GPU that processes all the interrupts in order, so we don't 
need the concurrency of WQ_UNBOUND.

Regards,
   Felix


>
> Thanks.
>