Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2b44bbd1-6e6f-40d1-73ac-19348d1ef48a@oracle.com>
Date:   Fri, 12 Aug 2022 16:23:20 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.1
Subject: Re: [PATCH v10 1/8] crash: introduce arch/*/asm/crash.h
Content-Language: en-US
To:     Baoquan He <bhe@redhat.com>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org,
        kexec@lists.infradead.org, ebiederm@xmission.com,
        dyoung@redhat.com, vgoyal@redhat.com, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
        hpa@zytor.com, nramas@linux.microsoft.com, thomas.lendacky@amd.com,
        robh@kernel.org, efault@gmx.de, rppt@kernel.org, david@redhat.com,
        sourabhjain@linux.ibm.com, konrad.wilk@oracle.com,
        boris.ostrovsky@oracle.com
References: <20220721181747.1640-1-eric.devolder@oracle.com>
 <20220721181747.1640-2-eric.devolder@oracle.com>
 <YvCCOY+mRshu1tHi@MiWiFi-R3L-srv>
 <52d40562-ee6f-bb89-6d21-2d6baf67053d@oracle.com>
 <YvYhYdV6F2zH4o3X@MiWiFi-R3L-srv>
From:   Eric DeVolder <eric.devolder@oracle.com>
In-Reply-To: <YvYhYdV6F2zH4o3X@MiWiFi-R3L-srv>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QjNIeEphOUpzRWxRMzNUeDl3TzdiMHhRSHk5WU1sWENvOWlNVHNsNjduZTIw?=
 =?utf-8?B?Tnk0LzhWZnpFR1piUXpvc3VQcGRPeTBWeGxNUys1QjRxTEZENmpyb2Z2UUNW?=
 =?utf-8?B?RmlqUFJaYSs3M3VPcC9DSEtaYmxjaXJYVWMyM1IzdnJFUncyMlVxdnVXZDZy?=
 =?utf-8?B?N2hOR1ozbXJ2UEpIOFU4Y3YrSTFyZ1NOWVp2dDF5M3U2Z0lrQk1uSHh4Z2Rl?=
 =?utf-8?B?THN2NW5qODh4R1BGNVpaS1RPU0pNSmFvL3BZN05RVFdmSWpWY2RvU1hMMGhK?=
 =?utf-8?B?NkxxME4xMTU2aTNjUDNvTTBlNnRhd2kzTm1WVU9NRGtSdWQ2N2NINUEvUjB4?=
 =?utf-8?B?NXMxNFQ5dkZ4NC9XSGU5bFNZelMyQ0hzT0JscmRRc0tiVHErajRaQ3o2cWhq?=
 =?utf-8?B?UElRSzFvSExxcDc2REhiYjZxeGVaV0VVSnhrckRva1VQNis0eWJ4YnJ0OXVI?=
 =?utf-8?B?ajE3RVNQODE5aUlMQXlpZFMwS3NKTmlHbkFlbFNyUXphQjhFZEhMVVppN3Ra?=
 =?utf-8?B?ZmIrTmlhSjFHS0tTSk00anJNYjY1cDlOd0Z3MGJIVmpGcCt4aEZsMVVIRHlQ?=
 =?utf-8?B?anhNL01tVTBpTlBvNE1mek0wOGJCd3NIdDl1OG9HQ1Z1RUU0Ry9xQkZqRWdS?=
 =?utf-8?B?UHZVSzdmY1g0eXZsMUt5SGM2SHpwZzU4WUlScmx5R1QyWFpIQVVHeEpRK0tJ?=
 =?utf-8?B?MW03WUpPSkZMVVFSWFRHTjdKbXhROUJGZWw4L2RHdlA2RlhJT1dSajRCMFlL?=
 =?utf-8?B?UFgzNDh5alUxTjRGTGtEZmtiY0xscEFnNzVKM21rZFRPZXRKTFd5bDkzYlQy?=
 =?utf-8?B?ZGdSK1orTWJlOXQrM1l5YjVtWUIwOGdLamJDbEllc21OSE9wK2trcXk1NnJM?=
 =?utf-8?B?MGgyS1pGZ29SWU5jZkUybDIzaW5CaE1WaUd5cVBVVXhtejFxa0ttbXI1VGx1?=
 =?utf-8?B?dEFUYzlFNDFaNVZIdXhiNHcrUmJJbHMvaDdkelhXeml4STBrTlpMcEpaV1hs?=
 =?utf-8?B?NnA2MjBrazA3SXB3ZWhabE1DNElQSTA2WmdaZXFLY2Raa1dGNEpCZVNxaVRt?=
 =?utf-8?B?NGhzbUkzTlVnUlFNaCt4Rlg5Zkw3dXJPVGk1RldEWkhZVEQ5MDIxRkNzZTNR?=
 =?utf-8?B?QXpiUVNBMDZLVEVxcHRiSG1ONGpTSHZzd0x2N3U3T2s3YmlDam9XRGxYUXp5?=
 =?utf-8?B?aHVjbHpGaGhnU3BnMVRyS21MUnlkMW1zMzRNb28xT2NMR0xoOG81TXNwbWZy?=
 =?utf-8?B?YnpLL0cybEkvUHlNMGlBOWh5a0s0cUFRTUNDRGM1bnNRZytGbS9BcDZhYW1t?=
 =?utf-8?B?RE9jYytKblcvWDVvMGhyZzZlY3NreVBWL3VscVBBZnVVc1AwMjR3bVp3bHhT?=
 =?utf-8?B?Rlc3T1dFQ2hBd256ZmZZNWxlSTE2bi8vN0xUdHlPVmpqaVlpb1p1aUs2Um9s?=
 =?utf-8?B?ZCsrelVpQlhEeUJNcERkN1VzVko1S2s0MVdhY3lFN0JzbHp3SjFvbUQycUQ3?=
 =?utf-8?B?NU1DVDJDUzJFRVJnRWQ0NWZxeW1EVUQyakg0VTloc1N5RFM3TzNKSllsTHlO?=
 =?utf-8?B?N0hCN1R2VzNyRkkzbUNzZ1lZWnBRc1lDSlNZeGRHelFVWUpjb0pKUXFvbVdm?=
 =?utf-8?B?V1VlYzNzNVF6YkxiUG5MYlRnOENYWldZZHE5UlhScHhmV1k3YTM4cnExUkNP?=
 =?utf-8?B?Vy8reW9sTFVIdy9HWFRjZXJZbGVBK2VBWi9tVDVXYTBMQWZRRzlocEZIQUFt?=
 =?utf-8?B?NWdSUlFJQWdSSmdLbmZaSklGSnNZNG56cUpJR2I5dndOR2lwQ0hMSi9kNFdQ?=
 =?utf-8?B?bGZmSitCTHFNSENIS3RmNjk5dlE1eENUSndseVBzOGVKT0FCK3UxVnBWUUd2?=
 =?utf-8?B?L0J5bis0a0dpZmg1bDZEYmNMRE1ld2hmZGlrT0s4TkFRbnNKdFlNSnRLTEV4?=
 =?utf-8?B?ZGhjWER0MFBYMWtJczN1UHFGci9EWDEvRit6SUluWlE5NXlKUDRCbHAzL0My?=
 =?utf-8?B?R2doRk1MSGNmWERtT2V0anlXWVhpcWtWdjVJKys0TE1SWlIzUzJoZ1IwV0Rq?=
 =?utf-8?B?SnZnRXQrQ05tUWxkU3pXVXIwU3diaXFZYit3THpWWjF2NWhkSVdwSlZDcjNx?=
 =?utf-8?B?eUVNZmNxZmFrWHZTOTdNZmQ2Uk1KUGxSY1BFQ0NsbkNUK3RzK3R0RHVGaExH?=
 =?utf-8?Q?gcjR3WwB8UQVSFf4pJytCZE=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a35b4d7-fb0d-4046-91b1-08da7ca8e5e5
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4531.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2022 21:23:28.2548
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CtLC3xXRLVtw9k/ewl3IszVRQEO19asj7sX24EbG7DyYzcul8winRa2NpUSGR+7rciHITJeiGnFI2KC0Gd11LPtfU4+1fa5Uzkz2eAyCwgU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB3273
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-12_10,2022-08-11_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0
 spamscore=0 bulkscore=0 adultscore=0 malwarescore=0 mlxscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2207270000 definitions=main-2208120057
X-Proofpoint-GUID: 1IXlxam1LYLNbAA1zSJm06loF3qvGJX6
X-Proofpoint-ORIG-GUID: 1IXlxam1LYLNbAA1zSJm06loF3qvGJX6
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/12/22 04:46, Baoquan He wrote:
> On 08/08/22 at 10:18am, Eric DeVolder wrote:
>>
>>
>> On 8/7/22 22:25, Baoquan He wrote:
>>> Hi Eric,
>>>
>>> On 07/21/22 at 02:17pm, Eric DeVolder wrote:
>>>> The use of __weak is being eliminated within kexec sources.
>>>> The technique uses macros mapped onto inline functions in
>>>> order to replace __weak.
>>>>
>>>> This patchset was using __weak and so in order to replace
>>>> __weak, this patch introduces arch/*/asm/crash.h, patterned
>>>> after how kexec is moving away from __weak and to the macro
>>>> definitions.
>>>
>>> Are you going to replace __weak in kexec of arll ARCHes? I don't see
>>> your point why all these empty header files are introduced. Wondering
>>> what's impacted if not adding these empty files?
>>
>> Hi Baoquan,
>> In this patchset, to file include/linux/crash_core.h I added the line #include <asm/crash.h>.
>> I patterned this after how include/linux/kexec.h does #include <asm/kexec.h>.
> 
> I am sorry, Eric, it looks not so good. I understand you want to pattern
> asm/kexe.h, but we need consider reality. Introducing a dozen of empty
> header file and not being able to tell when they will be filled doesn't
> make sense.
> 
> Includig <asm/crash.h> where needed is much simpler. I doubt if your way
> can pass other reviewers' line. Can you reconsider?

If I include <asm/crash.h> where needed, which is kernel/crash_core.c, then the other archs will 
fail build if that file doesn't exist. A couple of options, which do you think is better to pursue?

- use asm/kexec.h instead of asm/crash.h; it appears all the architectures already have this file in 
place

- go ahead and put the appropriate crash macros/inline functions into each arch asm/crash.h so that 
the files are not just empty, and leave the use of asm/crash.h

Or perhaps you see a better alternative?

Thanks!
eric


> 
> diff --git a/kernel/crash_core.c b/kernel/crash_core.c
> index 77f5f3591760..b0577bdcc491 100644
> --- a/kernel/crash_core.c
> +++ b/kernel/crash_core.c
> @@ -15,6 +15,7 @@
>   
>   #include <asm/page.h>
>   #include <asm/sections.h>
> +#include <asm/crash.h>
>   
>   #include <crypto/sha1.h>
>