Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp126677rwb; Fri, 12 Aug 2022 15:59:45 -0700 (PDT) X-Google-Smtp-Source: AA6agR6czLtKFdglq8Wpx9wG9+jGPz4Vaq2qPf9y7zR317nZcfDXHwnLf+//B7MYBzT+4TPwchjw X-Received: by 2002:a05:6402:190d:b0:43d:f64f:9a0e with SMTP id e13-20020a056402190d00b0043df64f9a0emr5440320edz.346.1660345185432; Fri, 12 Aug 2022 15:59:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660345185; cv=none; d=google.com; s=arc-20160816; b=u+EeJyTsB2D437aREcIIJzy3IiAVK6IrRaU8rAdAagNJH5ESFo7Rn0YPL1Rf9ogctd rEDuuEWiUTUth1TSuFVeAwBqbO296VT/ybXby8DZ5qU9bV5Q+VTt3/oyOugAYiEHORWn 8AUCbfJ1vytgaICiZmO7wuGVNlZ0LTQxHdswEkZ+0Gah/Bfgz1l/77qKh7BeCxAuRm4V 4lShBsxtD8+kYco3zkE58onJVsORnpScsixbnk/C4ad460IU12faap/dOYg9W5qbBk1n NSVpsDoQFEJgyOujTKvYDd/fngVSOzZzjqg5NWvHwHF48OPfdZdJ0pqKVsOVbP71ugp1 3cDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:feedback-id:dkim-signature :dkim-signature; bh=MihXDT4RnPEouVvFPrPaSH/gv3/IeZRAiImwW7f+1Rw=; b=XAf+9qR2a7wtPx80yzDKNEnMzDYlW8TY2pD7jQ/35bRboXEHuP/2T7d599KG6r1/vC wv/ffbLlflvCwTRmvNjjzRPYxmEr5vyiAjt9tK9q2AdMBF2z+yjobwBbDKL+vWlW6Omn HxYLc6oHW1Jy0Q9ZPRkc0C1xKrAK0L36dCxaAGNmU4QnAsylmk9zXxNU9ihVSdH/NZDh hnkA9wty1zYC+dJd5YLZ4r8nBUticdEagc9nB1sAcWD7QEIK/X6XxSA8SuKTp7SfP0l5 GE0W6uwW+PgunMf98oPFVTYQevqPp+T+fPoMHdKSilfatrCYts19fF6rNH3xMsDscezW 7xjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ljones.dev header.s=fm2 header.b=WXrliUJR; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=Bl8yqRsU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o6-20020a170906974600b0073062f48dbesi3015722ejy.671.2022.08.12.15.58.55; Fri, 12 Aug 2022 15:59:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ljones.dev header.s=fm2 header.b=WXrliUJR; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=Bl8yqRsU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236879AbiHLWZ1 (ORCPT + 99 others); Fri, 12 Aug 2022 18:25:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236334AbiHLWZZ (ORCPT ); Fri, 12 Aug 2022 18:25:25 -0400 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D225AAE61; Fri, 12 Aug 2022 15:25:23 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 6BE965C0093; Fri, 12 Aug 2022 18:25:22 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 12 Aug 2022 18:25:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ljones.dev; h=cc :cc:content-transfer-encoding:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to; s=fm2; t=1660343122; x=1660429522; bh=MihXDT4RnPEouVvFPrPaSH/gv 3/IeZRAiImwW7f+1Rw=; b=WXrliUJRNbOCEcWHfRIMexq2AMZpMeFFbY5Uh1CcX wvC0y6tOLwHVQTD9VSOG6NKYP4f1ypbMiy8K24A4zO1PqSmPe+r4JsQFlURQfnVG lVYkVNrhRH6aGQBNBkF1E/9zmC9vdZMiPLJSDJnY7J/D99qlSuFMZP5V4ZA35zU0 +tytHoYpU4bjsndJQVFX5b7y9pXYe0hJT4ix0Eb7eS8u9CbtCex/nIWA0S4sWiyq mTeyUCVVl3N45qAt9yFmRpiIc6+RxGwjRpSwdkhlHmeO0eE6BPVokAndCzVY1zcK QToJAcprOY0IYMa734i2HSW1PSvpdbSRDf5fatgl+P8bQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1660343122; x=1660429522; bh=MihXDT4RnPEouVvFPrPaSH/gv3/IeZRAiIm wW7f+1Rw=; b=Bl8yqRsUGbWjUK0QIclLBOdIoKE3KDeSRDMLfSNH1fJz10EUk23 3zO1OQTxaDHZGG/wkNwdaZGB7AFp34sRP16AGtUr0vPuxpu/NWYiXMhrtdCAafJn irwSMoWWog6pqF4Tgfcxvx7naR7bPqRTiKa+meZlSjJz5LsagM0mGTG2N258Tkz9 BTq3xITb80Se3MiDv8a+JdBEvgyZT70oSpL3LNCegrluxiSAIYBKnvVlbZZgvMW9 ZZrGPKanstgxRNTFnd44iISm9MTIgStHOZ9ijVVrEWzO4bn/6s9iDPHObIVhiGaP w8YN69dIshFFqRGlTPC2hK74AJST6bcMarQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdegjedguddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffoggfgsedtkeertd ertddtnecuhfhrohhmpedfnfhukhgvucffrdculfhonhgvshdfuceolhhukhgvsehljhho nhgvshdruggvvheqnecuggftrfgrthhtvghrnhepgfdujedthfduudekffefkeeiffdttd dvhfegudduueffuefhfefggeefteevvdegnecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomheplhhukhgvsehljhhonhgvshdruggvvh X-ME-Proxy: Feedback-ID: i5ec1447f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 12 Aug 2022 18:25:18 -0400 (EDT) From: "Luke D. Jones" To: hdegoede@redhat.com Cc: markgross@kernel.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, "Luke D. Jones" Subject: [PATCH 0/6] asus-wmi: cleanup dgpu_disable, egpu_enable, panel_od Date: Sat, 13 Aug 2022 10:25:03 +1200 Message-Id: <20220812222509.292692-1-luke@ljones.dev> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch series does two things for previously added features: - dgpu_disable - egpu_enable - panel_od The fixes add missing documentation, and the refactors vastly clean up how the features work, including reading the values from WMI methods on *_show() and checking the result correctly (these methods return 1 on success). Luke D. Jones (6): Fixes 98829e84dc67 ("asus-wmi: Add dgpu disable method") Fixes: 382b91db8044 ("asus-wmi: Add egpu enable method") Fixes: ca91ea34778f ("asus-wmi: Add panel overdrive functionality") asus-wmi: Refactor disable_gpu attribute asus-wmi: Refactor egpu_enable attribute asus-wmi: Refactor panel_od attribute .../ABI/testing/sysfs-platform-asus-wmi | 28 +++ drivers/platform/x86/asus-wmi.c | 231 ++++++------------ 2 files changed, 103 insertions(+), 156 deletions(-) -- 2.37.1