Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2e15fc72-5483-b901-5a54-d4a4529d61d9@infradead.org>
Date:   Fri, 12 Aug 2022 18:11:35 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [RFC PATCH v2 12/12] mm: make MAX_ORDER a kernel boot time
 parameter.
Content-Language: en-US
To:     Zi Yan <ziy@nvidia.com>, linux-mm@kvack.org
Cc:     David Hildenbrand <david@redhat.com>,
        Matthew Wilcox <willy@infradead.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        John Hubbard <jhubbard@nvidia.com>,
        Yang Shi <shy828301@gmail.com>,
        David Rientjes <rientjes@google.com>,
        James Houghton <jthoughton@google.com>,
        Mike Rapoport <rppt@kernel.org>, linux-kernel@vger.kernel.org
References: <20220811231643.1012912-1-zi.yan@sent.com>
 <20220811231643.1012912-13-zi.yan@sent.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20220811231643.1012912-13-zi.yan@sent.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi--

On 8/11/22 16:16, Zi Yan wrote:
> diff --git a/mm/Kconfig b/mm/Kconfig
> index e558f5679707..acccb919d72d 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -455,6 +455,19 @@ config SET_MAX_ORDER
>  	  increase this value. A value of 10 means that the largest free memory
>  	  block is 2^10 pages.
>  
> +config BOOT_TIME_MAX_ORDER
> +	bool "Set maximum order of buddy allocator at boot time"
> +	depends on SPARSEMEM_VMEMMAP && (ARCH_FORCE_MAX_ORDER != 0 || SET_MAX_ORDER != 0)
> +	help
> +	  It enables users to set the maximum order of buddy allocator at system
> +      boot time instead of a static MACRO set at compilation time. Systems with
> +      a lot of memory might want to allocate large pages whereas it is much
> +      less feasible and desirable for systems with less memory. This option
> +      allows different systems to control the largest page they want to
> +      allocate. By default, MAX_ORDER will be set to ARCH_FORCE_MAX_ORDER or
> +      SET_MAX_ORDER, whichever is non-zero, when the boot time parameter is not
> +      set. The maximum of MAX_ORDER is currently limited at 256.

Please make sure that all lines of help text are indented with one tab + 2 spaces,
as specified in Documentation/process/coding-style.rst.

Thanks.
-- 
~Randy