Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 13 Aug 2022 12:55:33 +0200
From:   Lukas Wunner <lukas@wunner.de>
To:     "Luke D. Jones" <luke@ljones.dev>
Cc:     hdegoede@redhat.com, markgross@kernel.org,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] asus-wmi: Support the hardware GPU MUX on some laptops
Message-ID: <20220813105533.GA3258@wunner.de>
References: <20220813092624.6228-1-luke@ljones.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220813092624.6228-1-luke@ljones.dev>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Sat, Aug 13, 2022 at 09:26:24PM +1200, Luke D. Jones wrote:
> Support the hardware GPU MUX switch available on some models. This
> switch can toggle the MUX between:
> 
> - 0, Dedicated mode
> - 1, Optimus mode
> 
> Optimus mode is the regular iGPU + dGPU available, while dedicated
> mode switches the system to have only the dGPU available.

Could you please integrate this with the framework provided by:

  include/linux/vga_switcheroo.h
  drivers/gpu/vga/vga_switcheroo.c

vga_switcheroo will then automatically expose a sysfs interface.

Find existing vga_switcheroo mux drivers in the tree like this,
they may serve as a template:

  git grep "struct vga_switcheroo_handler" -- :/

Thanks,

Lukas