Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e6b6f874-bde5-75f2-eb40-2b31097c6f8c@o2.pl>
Date:   Sat, 13 Aug 2022 14:04:05 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.1.2
Subject: Re: [PATCH] x86/MCE/AMD: Decrement threshold_bank refcount when
 removing threshold blocks
Content-Language: en-GB
To:     Borislav Petkov <bp@alien8.de>
Cc:     Yazen Ghannam <yazen.ghannam@amd.com>, linux-edac@vger.kernel.org,
        linux-kernel@vger.kernel.org, tony.luck@intel.com, x86@kernel.org,
        Smita.KoralahalliChannabasappa@amd.com, mpatocka@redhat.com,
        gregkh@linuxfoundation.org
References: <20220614174346.3648305-1-yazen.ghannam@amd.com>
 <7c8e34c8-f12d-e7e4-b6bc-4867824865ea@o2.pl> <Yvd4cCW4ng2cG96p@zn.tnic>
From:   =?UTF-8?Q?Mateusz_Jo=c5=84czyk?= <mat.jonczyk@o2.pl>
In-Reply-To: <Yvd4cCW4ng2cG96p@zn.tnic>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

W dniu 13.08.2022 o 12:09, Borislav Petkov pisze:
> On Fri, Aug 12, 2022 at 11:14:44PM +0200, Mateusz Jończyk wrote:
>> After these changes, the __threshold_remove_blocks() function looks
>> very similar to deallocate_threshold_blocks() function just above it.
> Yes, minus the list_del(&pos->miscj); But that can be made conditional
> with a bool arg to deallocate_threshold_blocks() and then remove
> __threshold_remove_blocks().
>
> Care to take Yazen's patch, fix it up, test it thoroughly (you should
> enable KASAN to catch any potential memory leaks) and send it?
>
> Thx.
>
I'll try, but I don't understand the code well yet, and have access to only one
old computer with an AMD CPU.

Greetings,

Mateusz,