Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp762892rwb; Sat, 13 Aug 2022 08:16:22 -0700 (PDT) X-Google-Smtp-Source: AA6agR7D1h6pGlC3FIMpaHKozT1b3fUbSj7srWI3eCnjf9c5cALRgJJYK4EVPLAcpifrwYL0wi+e X-Received: by 2002:a17:907:1690:b0:731:56b6:fded with SMTP id hc16-20020a170907169000b0073156b6fdedmr5929943ejc.119.1660403782689; Sat, 13 Aug 2022 08:16:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660403782; cv=none; d=google.com; s=arc-20160816; b=QW9WUVa6KidkMXZUTp8OaBCCKQleO/d4eaZwiMXLAIIWHOPWFy0SMnVKSK5Hpe9Uod dAeOzwFX6RxOFxA4zGzTzUlGImTnzm7hoIwngpgmLkzOmSv7tJiDTbYhEyVwSKujX4gC IDdiqiY+alUr7CNsgCPl1E24q2HqEThhCcjaeCJ1+9CZ3b+1oDPUFz1mh8JCEQHo2YGJ 0Wvm3PTmtTlj/UIgFI3FLyMXRJh1wo1wddhGnFcDNnZLndjkiN/iYO6etOdo2IR+BzKy /FdLARccQDuEWmVXhIwn60seMj4bpOsvvY2wSRvqd5qIcKgGBiIFUmHVkfJoiyYvU4G1 7R5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=WapydjWUane8f3QxMtubXs/QK0ODLAdb+vKaEJ8bjAc=; b=URh30/e/SdB18gMKNvJ9FJTVG8gcwI4xA7Sfqktd4cwggT0x6KpE2YxHMmfejHEmlU jtet5sjlPd8U/c17TsRLJcaxgf5P0IE89eeCA8Cox2chnI/BrwxK7Rizatvy1bzDstOl SXoZsJ0V9S0hYp//LOVvkhwC6KYuKIUzbOvGIq0Sq65q9kNugHRTgKhhNm5Ae0pQFzoz 2tHE5fny1rIgM/jIfIrYLIZN3emtduDSm3n7DjCxWBwWOlvmJEmQJP6w7e2vNSmsibVw WoNz9xnH4T8hzkq356OimFWgREtJgSxKBv1BemKhiW78u7pauVy1FuHupaVRx6vxZfNt wd8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=w+HL5WiP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s4-20020a17090699c400b00734ca64fb9bsi4186336ejn.832.2022.08.13.08.15.50; Sat, 13 Aug 2022 08:16:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=w+HL5WiP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239677AbiHMPMG (ORCPT + 99 others); Sat, 13 Aug 2022 11:12:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239634AbiHMPME (ORCPT ); Sat, 13 Aug 2022 11:12:04 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C1FF13CED; Sat, 13 Aug 2022 08:12:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=WapydjWUane8f3QxMtubXs/QK0ODLAdb+vKaEJ8bjAc=; b=w+HL5WiPOhI4wdFgzMqzxODMzZ FaUvcyPj8Umu+d/o1TGjTG3+SNxVVsOnGM4leP0g54Quyi5u8qvypyfOjhrViRJG0iPMDNNBdt2Yi aHmclgf/RHGyBeOms2YKq7nd6R51Nft+lyT+qOOaczBAWZgAWLA2Gk+DzQmthbI/f31A=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oMsnh-00DDzY-3j; Sat, 13 Aug 2022 17:11:45 +0200 Date: Sat, 13 Aug 2022 17:11:45 +0200 From: Andrew Lunn To: Oleksij Rempel Cc: Vladimir Oltean , Woojung Huh , UNGLinuxDriver@microchip.com, Vivien Didelot , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next v1 07/10] net: dsa: microchip: warn about not supported synclko properties on KSZ9893 chips Message-ID: References: <20220729130346.2961889-1-o.rempel@pengutronix.de> <20220729130346.2961889-8-o.rempel@pengutronix.de> <20220802113633.73rxlb2kmihivwpx@skbuf> <20220805115601.GB10667@pengutronix.de> <20220805134234.ps4qfjiachzm7jv4@skbuf> <20220813143215.GA12534@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220813143215.GA12534@pengutronix.de> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 13, 2022 at 04:32:15PM +0200, Oleksij Rempel wrote: > On Fri, Aug 05, 2022 at 04:42:34PM +0300, Vladimir Oltean wrote: > > On Fri, Aug 05, 2022 at 01:56:01PM +0200, Oleksij Rempel wrote: > > > Hm, if we will have any random not support OF property in the switch > > > node. We won't be able to warn about it anyway. So, if it is present > > > but not supported, we will just ignore it. > > > > > > I'll drop this patch. > > > > To continue, I think the right way to go about this is to edit the > > dt-schema to say that these properties are only applicable to certain > > compatible strings, rather than for all. Then due to the > > "unevaluatedProperties: false", you'd get the warnings you want, at > > validation time. > > Hm, with "unevaluatedProperties: false" i have no warnings. Even if I > create examples with random strings as properties. Are there some new > json libraries i should use? Try additionalProperties: False Andrew