Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 13 Aug 2022 18:47:17 -0400
From:   William Breathitt Gray <william.gray@linaro.org>
To:     Julien Panis <jpanis@baylibre.com>
Cc:     robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, mranostay@ti.com
Subject: Re: [PATCH v4 2/3] Documentation: ABI: add sysfs-bus-counter-ecap
Message-ID: <Yvgp9WGcA2fqS1Rm@fedora>
References: <20220810140724.182389-1-jpanis@baylibre.com>
 <20220810140724.182389-3-jpanis@baylibre.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="R+ComDZuVIk5knoa"
Content-Disposition: inline
In-Reply-To: <20220810140724.182389-3-jpanis@baylibre.com>
Precedence: bulk


--R+ComDZuVIk5knoa
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Aug 10, 2022 at 04:07:23PM +0200, Julien Panis wrote:
> This commit adds an ABI file for TI ECAP used in capture operating mode.
>=20
> Signed-off-by: Julien Panis <jpanis@baylibre.com>

Hi Julien,

Duplicate ABIs are no longer valid, so we consolidated the Counter sysfs
attributes documentation to a single sysfs-bus-counter file in commit
769841c966fd. You can document the new sysfs attributes you introduce
for the TI eCAP counter driver to that sysfs-bus-counter file as well.

William Breathitt Gray

> ---
>  .../ABI/testing/sysfs-bus-counter-ecap        | 64 +++++++++++++++++++
>  1 file changed, 64 insertions(+)
>  create mode 100644 Documentation/ABI/testing/sysfs-bus-counter-ecap
>=20
> diff --git a/Documentation/ABI/testing/sysfs-bus-counter-ecap b/Documenta=
tion/ABI/testing/sysfs-bus-counter-ecap
> new file mode 100644
> index 000000000000..ca530a6806de
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-bus-counter-ecap
> @@ -0,0 +1,64 @@
> +What:		/sys/bus/counter/devices/counter0/signal0/polarity1
> +What:		/sys/bus/counter/devices/counter0/signal0/polarity2
> +What:		/sys/bus/counter/devices/counter0/signal0/polarity3
> +What:		/sys/bus/counter/devices/counter0/signal0/polarity4
> +KernelVersion:	5.19
> +Contact:	jpanis@baylibre.com
> +Description:
> +		ECAP module includes 4 timestamp capture registers.
> +		For all 4 sequenced timestamp capture events (1->2->3->4->1->...),
> +		edge polarity can be selected. Then, each capture register can be
> +		tuned to capture event by either:
> +
> +		- "rising"
> +		- "falling"
> +
> +		Reading returns current trigger polarity.
> +
> +		Writing value before enabling capture sets trigger polarity.
> +
> +What:		/sys/bus/counter/devices/counter0/signal0/polarity1_available
> +What:		/sys/bus/counter/devices/counter0/signal0/polarity2_available
> +What:		/sys/bus/counter/devices/counter0/signal0/polarity3_available
> +What:		/sys/bus/counter/devices/counter0/signal0/polarity4_available
> +KernelVersion:	5.19
> +Contact:	jpanis@baylibre.com
> +Description:
> +		Discrete set of available values for the respective polarity X
> +		configuration are listed in this file. Values are delimited by
> +		newline characters.
> +
> +What:		/sys/bus/counter/devices/counter0/count0/enable
> +KernelVersion:	5.19
> +Contact:	jpanis@baylibre.com
> +Description:
> +		Whether ECAP is enabled. Valid attribute values are boolean.
> +
> +		This attribute is intended to serve as a start/stop mechanism
> +		for ECAP.
> +
> +What:		/sys/bus/counter/devices/counter0/count0/count
> +KernelVersion:	5.19
> +Contact:	jpanis@baylibre.com
> +Description:
> +		Read-only attribute that indicates the current base counter value.
> +
> +What:		/sys/bus/counter/devices/counter0/count0/capture1
> +What:		/sys/bus/counter/devices/counter0/count0/capture2
> +What:		/sys/bus/counter/devices/counter0/count0/capture3
> +What:		/sys/bus/counter/devices/counter0/count0/capture4
> +KernelVersion:	5.19
> +Contact:	jpanis@baylibre.com
> +Description:
> +		Read-only attributes that indicate the last timestamp captured
> +		for the respective capture X register.
> +
> +What:		/sys/bus/counter/devices/counter0/count0/capture1_component_id
> +What:		/sys/bus/counter/devices/counter0/count0/capture2_component_id
> +What:		/sys/bus/counter/devices/counter0/count0/capture3_component_id
> +What:		/sys/bus/counter/devices/counter0/count0/capture4_component_id
> +KernelVersion:	5.19
> +Contact:	jpanis@baylibre.com
> +Description:
> +		Read-only attributes that indicate the component ID of the
> +		respective extension or synapse.
> --=20
> 2.25.1
>=20

--R+ComDZuVIk5knoa
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCYvgp9QAKCRC1SFbKvhIj
K+hOAP9FJPw/AbXZbCmP3t4cfCY2o6AER5KkmaxTEu0mFDAafwEApCOn+i40k5FZ
CqEdQohSPhKXNuCBLsp8BBgdR1MLZQg=
=jfdg
-----END PGP SIGNATURE-----

--R+ComDZuVIk5knoa--