Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp1108558rwb; Sat, 13 Aug 2022 17:20:11 -0700 (PDT) X-Google-Smtp-Source: AA6agR6rhpZSmYVD+HGGtnhoB0dhNTHIOu5KXh6OBL4UXURc63UKh1IIM9tYlg0IytQTbQpnDN0I X-Received: by 2002:a17:902:e746:b0:16e:f7cf:671f with SMTP id p6-20020a170902e74600b0016ef7cf671fmr10314229plf.168.1660436411246; Sat, 13 Aug 2022 17:20:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660436411; cv=none; d=google.com; s=arc-20160816; b=EQELfDcd5s91/H3z4eICLxhrOekUgwCjTQREqN0BTAi4okZ9E0zFN+vDI/DZT1rLOu OsHLezgKtM2KVV1ArxfIZAqT9kNjiIWrOGWvkHeBiRD8NHBzAW1JuhSLCILJMLltqcJi jfGBiKZ+Cpx0oLB86nxyQbPn10oWsWux61KXDyVzh8vsi4rk31+OBvqHipq9YN04dTEd FcNG5H59e0GRPQUm/J7nqjBFWaVEBeJ3po73bfIfgcX1Fx03aUULVDfqk9sPe4L0o2e6 ejnmcFLdShfWY3tDF6YiD9rBTtt7yt4CpANkGetf1OwA0HTdwaywiit0i1ol6XAqvim7 q2Uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=k2HXj1ftKqQzS7OWACfiV9g8z1v8ZgNeYGZxqozA+Pc=; b=jcDhA50FMbuMulewK2oowR9WCwOQ0zJlRYUeLtV+iVw8EfIDQP75PSldoFYjvplORY i8isRMyrDHzmUEM3H5KWpiQUsdxvIMZaC6rfbWZqd5OLWSwRXeKeW9d4kBR91iaHxdL7 o+Fz5P1yk5y9rZ2yOZSFPVvZf+bVKwxal0rLbcqyPybVkK4+Ixv7mYsbrxZJ509eHe2p 4F7/K5w4gbB3NWVG2EsHQM3KTQzH1C5VyQ3joNdfisTaILVVTlLuyJO+63iXoMSfBm5a u6SguvzpFYFGwIUsXV9Uc3gwvLZYSZ5U8gzNR4kaIPAC/P7yGzdpPJexAAYpKRrnDnG0 XRjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=Y8HUp8Mx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mu16-20020a17090b389000b001f31fdc9d58si7001675pjb.14.2022.08.13.17.19.35; Sat, 13 Aug 2022 17:20:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=Y8HUp8Mx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239721AbiHMX2p (ORCPT + 99 others); Sat, 13 Aug 2022 19:28:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229825AbiHMX2n (ORCPT ); Sat, 13 Aug 2022 19:28:43 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1044089822 for ; Sat, 13 Aug 2022 16:28:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A50EAB80920 for ; Sat, 13 Aug 2022 23:28:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC8A8C433D6; Sat, 13 Aug 2022 23:28:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1660433320; bh=/nd0iG9fLC7CgVX6HvULDZV4QNZrX4MQtqqRHeB/XCY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Y8HUp8Mxi0d6URADjUtO3p26TwUAoTrvTRrKMv0VLOEqO9dI7WQmvMImQXnU4wpTh 8UnMSrANJHAeQDNJvbv9rImyRCsEhBQMRMJx2mw3qQbSq9mmHaAn/gEYRdOkWAtOZK Mlq8Gv6WSLhwz1ZPAQJzXpfmVJFvmKuoTQ4nzCCM= Date: Sat, 13 Aug 2022 16:28:37 -0700 From: Andrew Morton To: Haiyue Wang Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, david@redhat.com, linmiaohe@huawei.com, ying.huang@intel.com, songmuchun@bytedance.com, naoya.horiguchi@linux.dev Subject: Re: [PATCH v1] mm: migration: fix the FOLL_GET failure on following huge page Message-Id: <20220813162837.cc20e208e7a9d65fd2e7dc14@linux-foundation.org> In-Reply-To: <20220812084921.409142-1-haiyue.wang@intel.com> References: <20220812084921.409142-1-haiyue.wang@intel.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 12 Aug 2022 16:49:21 +0800 Haiyue Wang wrote: > Not all huge page APIs support FOLL_GET option, so the __NR_move_pages > will fail to get the page node information for huge page. Which ones need fixing? What are the user-visible runtime effects of this bug? Is a -stable backport warranted? > This is an temporary solution to mitigate the racing fix. > > After supporting follow huge page by FOLL_GET is done, this fix can be > reverted safely. >