Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp1357209rwb; Sun, 14 Aug 2022 01:41:39 -0700 (PDT) X-Google-Smtp-Source: AA6agR4ROkJUNgwq13UjGMw8/0Iv1zxoNHyIpjDWyYJm4TKlH9JWQPmMN8wklaEA5ht9iE6FceDs X-Received: by 2002:a63:6d09:0:b0:427:bbb0:e62 with SMTP id i9-20020a636d09000000b00427bbb00e62mr2702682pgc.346.1660466499472; Sun, 14 Aug 2022 01:41:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660466499; cv=none; d=google.com; s=arc-20160816; b=dygudsQgU6E+d6QlGjfZl3p6nos5tmZqJ/vCgMPJg6a8GgqZhod7s5rpPGot7PFdWj vOlsF2LcbuN9OrZuoo0tQ+3zut5YNvYKWFiKJvl2f+IBqL5Tg/mJb335zAoDwB0yib7y jsVuZh81a0zr9MQLzp5CkwFDyrjzHzmzihdotS6GQIAgtyzNiTGvjGS1mYa/vgfw79yH EkRYVhqo6REMb326L2eCYma79vQX0OpyBkaQrF78iAybdpXi6KP7PunbdmOMjaBSRQzR NvHChh+XLEMig6Xysx/myiag/14EejtXnpXW2mzZ7Yh+t18Tg+74VLrWLffOwtYFn2nu i73Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=TNUwlG9nzp/Ftl8DzRydchfqZilNnNf9wCNcd4Axyyc=; b=vLtX40fGIZmtdWOv9Hq7iavTqwCMFElmHc37SdccWMAncW1pyVC3ZXAy6Nq4PTVJoF +Uw8ql9z6dCkR/m0arDFPtBDwI3sp29i0426IZ3KU5i94IMfH3W+fM6MWJXCp7BZDxe8 2icAbu0OarYqFkCrtAKmWPyPmE+t6IvWMc5Ayb6W3t8n4G/TjRsh6blwpE04ddM7n1xd KPVk4LGI7UEX+7/wAGHQ//NV9MAK5O2EJ6MBkR0oVhznajrZrVDIZRt3wvWErsdyKcAE cZum5mzDDXBnxr2Mck110DSOHr3R/q1yv9BibyMv5If78GoXXfB6KYH1MzVLOqn5ffOJ wbYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=AsEa44Yc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y193-20020a6264ca000000b0050d80e4935fsi7283456pfb.256.2022.08.14.01.41.29; Sun, 14 Aug 2022 01:41:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=AsEa44Yc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239509AbiHNIWR (ORCPT + 99 others); Sun, 14 Aug 2022 04:22:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229606AbiHNIWQ (ORCPT ); Sun, 14 Aug 2022 04:22:16 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB65017A9B; Sun, 14 Aug 2022 01:22:14 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id r4so6149666edi.8; Sun, 14 Aug 2022 01:22:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=TNUwlG9nzp/Ftl8DzRydchfqZilNnNf9wCNcd4Axyyc=; b=AsEa44Yc9lPon5nq4b7t2lUsgYwtl38nBM80b4OEIXUmDvPFUK3Ea6watTDnpUP//5 Rb98C1RrEplCcahkDx0onVcQi+FRIR7igDeitUo5JDX7ticQ9DMh7lcgWORZeQp91drj R24codiDwS6kHVQjc9ersi82pyV7oarHgP1ciRxLTG7A55VD5YeP5DOLk+/A9fjJ4t8I k7TabjpB8lNP/QZNXWjBh8i7keS9+fd3eZktH4i4fGTOuIExnwWyj4ph0qQ7EC1CG/mF L2EjVFwHKrGF6fC+F47yDlL5eM03xDo7ILVRxOiyuOgRrUjC9cl+mdOTtDzK86BkhhhH GFeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=TNUwlG9nzp/Ftl8DzRydchfqZilNnNf9wCNcd4Axyyc=; b=gCXkE6TfNRs6Ih6bSoochZZ3H4vCoAfj+L54ce9U8YGe228biHbKlHcay2Wqk/n1JI Ms+NyiM/lzPe8VlTOA4dpO+KCMwZxBeIYcexeZFRDeQ5i0dHpMTOAzRqVpDOnW/3r6Ee Hmv9AV29M+Hz+K4Ll4C2zz3EAt3TdLLGRQ6e9xgb/urt7TAGAHY622vpVyi8w8X7JfIb PttjPX/UhIiwTOQ37lwydomGvaTMlBLBRKWOpy+ralQtlnOW/yprJjlASS8tlawSPVa1 S7/poCFCQGhZxaEeJIza0KIcq04gGSPSnCK+og5D4XDgD25OgNaAuWdVfvL11l8AdkpJ PhEg== X-Gm-Message-State: ACgBeo2DXxiRbA5cOd2o5axvUCIy3ANYBuwbOQQrLuuEWCZSBOaHJT5b MieFz5C9lawAwc6XODTOSeQ= X-Received: by 2002:aa7:d795:0:b0:43c:eb00:fc77 with SMTP id s21-20020aa7d795000000b0043ceb00fc77mr9816545edq.284.1660465333601; Sun, 14 Aug 2022 01:22:13 -0700 (PDT) Received: from jernej-laptop.localnet (89-212-118-115.static.t-2.net. [89.212.118.115]) by smtp.gmail.com with ESMTPSA id z5-20020a1709063ac500b007306df330e5sm2774748ejd.12.2022.08.14.01.22.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Aug 2022 01:22:13 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Chen-Yu Tsai , Ulf Hansson , Wolfram Sang , Samuel Holland Cc: Samuel Holland , Andre Przywara , Maxime Ripard , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH] mmc: sunxi-mmc: Fix clock refcount imbalance during unbind Date: Sun, 14 Aug 2022 10:22:11 +0200 Message-ID: <21565294.EfDdHjke4D@jernej-laptop> In-Reply-To: <20220810022509.43743-1-samuel@sholland.org> References: <20220810022509.43743-1-samuel@sholland.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dne sreda, 10. avgust 2022 ob 04:25:09 CEST je Samuel Holland napisal(a): > If the controller is suspended by runtime PM, the clock is already > disabled, so do not try to disable it again during removal. Use > pm_runtime_disable() to flush any pending runtime PM transitions. > > Fixes: 9a8e1e8cc2c0 ("mmc: sunxi: Add runtime_pm support") > Signed-off-by: Samuel Holland Did you get any warnings for unbalanced disable calls? Anyway: Acked-by: Jernej Skrabec Best regards, Jernej