Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938952AbXFHTVY (ORCPT ); Fri, 8 Jun 2007 15:21:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750926AbXFHTVR (ORCPT ); Fri, 8 Jun 2007 15:21:17 -0400 Received: from adsl-70-250-156-241.dsl.austtx.swbell.net ([70.250.156.241]:42217 "EHLO gw.microgate.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750795AbXFHTVQ (ORCPT ); Fri, 8 Jun 2007 15:21:16 -0400 Subject: Re: [Bug 8473] New: Oops: 0010 [1] SMP From: Paul Fulghum To: =?ISO-8859-1?Q?Bj=F6rn?= Steinbrink Cc: Andrew Morton , Arnd Bergmann , Alan Cox , Nicolas Mailhot , Randy Dunlap , "bugme-daemon@kernel-bugs.osdl.org" , linux-kernel@vger.kernel.org, Mel Gorman , Christoph Lameter In-Reply-To: <1181315809.4811.5.camel@x2.microgate.com> References: <200705132102.l4DL2onF003014@fire-2.osdl.org> <20070513154718.bb338ceb.akpm@linux-foundation.org> <1179098742.7322.5.camel@rousalka.dyndns.org> <1179396003.31796.4.camel@rousalka.dyndns.org> <20070517094557.c96f7e54.randy.dunlap@oracle.com> <1179421196.5000.5.camel@rousalka.dyndns.org> <1180206615.3430.8.camel@rousalka.dyndns.org> <20070608030629.GA18493@atjola.homenet> <1181315809.4811.5.camel@x2.microgate.com> Content-Type: text/plain; charset=UTF-8 Date: Fri, 08 Jun 2007 14:20:48 -0500 Message-Id: <1181330448.5365.7.camel@amdx2.microgate.com> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 (2.2.3-4.fc4) Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1010 Lines: 27 On Fri, 2007-06-08 at 10:16 -0500, Paul Fulghum wrote: > On Fri, 2007-06-08 at 05:06 +0200, Björn Steinbrink wrote: > > This is do_tty_hangup() exchanging the fops while we're waiting for the > > lock. The new fops (hung_up_tty_fops) only have the unlocked variant and > > thus we Oops our way. ... > Here is a patch that restores the locked ioctl for hung_up_tty_ioctl. > Can you try it and see if it removes your oops? Unfortunately I can't get the timing right to trigger this, but it is very clear the locked ioctl fop must not be allowed to disappear like my original patch allows. Andrew: Would you prefer I resend the entire compat ioctl patch or submit an incremental patch like in my message I'm quoting above? -- Paul Fulghum Microgate Systems, Ltd - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/