Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S939390AbXFHTVy (ORCPT ); Fri, 8 Jun 2007 15:21:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750795AbXFHTVn (ORCPT ); Fri, 8 Jun 2007 15:21:43 -0400 Received: from x35.xmailserver.org ([64.71.152.41]:1499 "EHLO x35.xmailserver.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752047AbXFHTVm (ORCPT ); Fri, 8 Jun 2007 15:21:42 -0400 X-AuthUser: davidel@xmailserver.org Date: Fri, 8 Jun 2007 12:21:36 -0700 (PDT) From: Davide Libenzi X-X-Sender: davide@alien.or.mcafeemobile.com To: Linus Torvalds cc: Ulrich Drepper , Al Viro , Alan Cox , Theodore Tso , Eric Dumazet , Kyle Moffett , Linux Kernel Mailing List , Andrew Morton , Ingo Molnar Subject: Re: [patch 7/8] fdmap v2 - implement sys_socket2 In-Reply-To: Message-ID: References: <466864F8.2050903@cosmosbay.com> <46686810.6030805@redhat.com> <466880A4.3090908@redhat.com> <20070608120746.GD12687@thunk.org> <20070608140150.6f31672f@the-village.bc.nu> <20070608192652.4a291901@the-village.bc.nu> <4669A351.4010403@redhat.com> <20070608184650.GA4095@ftp.linux.org.uk> <4669A674.4080309@redhat.com> X-GPG-FINGRPRINT: CFAE 5BEE FD36 F65E E640 56FE 0974 BF23 270F 474E X-GPG-PUBLIC_KEY: http://www.xmailserver.org/davidel.asc MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1200 Lines: 32 On Fri, 8 Jun 2007, Linus Torvalds wrote: > On Fri, 8 Jun 2007, Ulrich Drepper wrote: > > > > We are talking about file descriptors here. If you're using file > > descriptors as anything other than tokens you'll find out soon enough > > that your code is broken. The new type of file descriptors cannot be > > used as indeces and the randomization makes sure that no program by some > > fluke happens to work. > > No, Uli. > > You need things to be *repeatable* for debugging. No ifs, buts, or maybes > about it. It all depends on how you use the file descriptor. If you see a file descriptor as an opaque handle (like it should be, really), that is simply passed to the OS to use services exposed by the handle, you will be fine independently from the values handed out by the OS. It was for the exactly this guarantee that created the problems, with ppl relying on it for indexing table, closing all files < NR_FILE and so on. - Davide - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/