Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 14 Aug 2022 18:15:14 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        Tomislav Denis <tomislav.denis@avl.com>,
        Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH v1 1/1] iio: pressure: dlhl60d: Don't take garbage into
 consideration when reading data
Message-ID: <20220814181514.3fe1107c@jic23-huawei>
In-Reply-To: <20220731133357.5705df25@jic23-huawei>
References: <20220726142048.4494-1-andriy.shevchenko@linux.intel.com>
        <20220731133357.5705df25@jic23-huawei>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sun, 31 Jul 2022 13:33:57 +0100
Jonathan Cameron <jic23@kernel.org> wrote:

> On Tue, 26 Jul 2022 17:20:48 +0300
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> 
> > Both pressure and temperature are 24-bit long. Use proper accessors
> > instead of overlapping readings.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>  
> Looks correct to me, but it made me scratch my head just enough that I'd
> like Tomislav to take a look if possible.  So give me a poke if this
> hasn't progressed in a few weeks time.

Long enough.

Applied to the togreg branch of iio.git and pushed out as testing.

Thanks,

Jonathan

> 
> Thanks,
> 
> Jonathan
> 
> > ---
> >  drivers/iio/pressure/dlhl60d.c | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/iio/pressure/dlhl60d.c b/drivers/iio/pressure/dlhl60d.c
> > index 5f6bb3603a8b..f0b0d198c6d4 100644
> > --- a/drivers/iio/pressure/dlhl60d.c
> > +++ b/drivers/iio/pressure/dlhl60d.c
> > @@ -129,9 +129,8 @@ static int dlh_read_direct(struct dlh_state *st,
> >  	if (ret)
> >  		return ret;
> >  
> > -	*pressure = get_unaligned_be32(&st->rx_buf[1]) >> 8;
> > -	*temperature = get_unaligned_be32(&st->rx_buf[3]) &
> > -		GENMASK(DLH_NUM_TEMP_BITS - 1, 0);
> > +	*pressure = get_unaligned_be24(&st->rx_buf[1]);
> > +	*temperature = get_unaligned_be24(&st->rx_buf[4]);
> >  
> >  	return 0;
> >  }  
>