Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp1937706rwb; Sun, 14 Aug 2022 16:40:46 -0700 (PDT) X-Google-Smtp-Source: AA6agR4CqEorGcs4vjI7vGHtxhjuF2jb5rkc8TJ6jyi02deVk+92YTphNg0co9lPLYojIO7vcVxS X-Received: by 2002:a17:907:720f:b0:731:8a9d:5ade with SMTP id dr15-20020a170907720f00b007318a9d5ademr8611695ejc.768.1660520445748; Sun, 14 Aug 2022 16:40:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660520445; cv=none; d=google.com; s=arc-20160816; b=l9IRC+eARBYk8ckmfmbBjA3QyjWPOcOdYVv6fQ3yq+qXklPGjYdB818lJa2bxcFXHj Buz4d/nYVHNR36S0/1F0bpvrUEZsSGHQFYLr6JHk1eMzP4BSYk77ZDEYPqyHqyj+Gwez bY1ua9y+dVooUwZeeqc7TFiMlAEOppi0seZlLJLRKH+EVdM/28xNbH+DpYgH85RrxkdT Nj/MI1lY0eaFljJ5Au2rN3qm1wyraWqPZNEbb2/fivy0AbL13uduu7ZbbYVub6FGSKXT ZDguciZznzvNiwiYo1wt/EzdgglaWhFDKgkyco4ybi++alpZjBGmJRnUVSu9CAkrbOAq ldNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=/RNl//CQIdgfxBiYXR2ClSuv26fcHBeLkZBQXo1ac8A=; b=w1K8+0+oNu0NZHs4GkSvH1HsEV8aP5y7/xNpBUdXJfZHNvp61KiWvrnsEK0BpkA2Uv zi3Ssbn86mUMQu/YT0GmB9Mm4BguqKUBOXTAH8T0sutgXrI4Z+etDi7+UNPWUVVe03qp e9gSF1Js63MLcAKqyNU+uFbhMb2h5Tj4amIceApl0d8DFNx7I50bYtWNx3ykX7QqaILi 1/pNMZXFexnrKL9CmrdhF/QrYt3nkGbGUWRRaSA2riC37NFz/ctuFd6GNVg+eBR38Qe+ 1fWkLTAcAl3fyejGcNzKV/cnx7iUp1bdEuLU6gG6qLzYFelkaxl36Kjqo1DOyXKiKalX cp9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=Vfz3IoiD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m10-20020a056402430a00b0043aa8412572si7492097edc.257.2022.08.14.16.40.19; Sun, 14 Aug 2022 16:40:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=Vfz3IoiD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232106AbiHNVwM (ORCPT + 99 others); Sun, 14 Aug 2022 17:52:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229570AbiHNVwL (ORCPT ); Sun, 14 Aug 2022 17:52:11 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B48BA12D26; Sun, 14 Aug 2022 14:52:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=/RNl//CQIdgfxBiYXR2ClSuv26fcHBeLkZBQXo1ac8A=; b=Vfz3IoiDMyXbd/8N1C2zY4t4OO 0cNfyaYdHnoPSTcBG5nWEnmmxA7RE3fuAhp7FwUL0ZlrE4S974mAA67zoNnVLmW8to84O4OTACHdd KmT0OkQpJFui+9udyZk1NS0cjqqo4GO3tUUuFMr96zvD4JkuHzJ2QMcQKXk89Sz4YuEhGFuzlWPl7 XYYDVM/l5WbDFfORJRnxs/dP/zaYlOt2OcHN0KPR5VD59j/RZUdPyxjcQKih+fRsYS9zz+iGJFwHm ETljBGy3T/Tdodt+QcVe9f6FGTtIkJmZHJeELc46QESdK88XsbUT58mjc5pxtM6+ch8GJnKit1i6E gnHC8WQQ==; Received: from [2601:1c0:6280:3f0::a6b3] (helo=casper.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNLWc-0058iR-Rj; Sun, 14 Aug 2022 21:52:03 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , kernel test robot , Matthew Rosato , Christian Borntraeger , Pierre Morel , Eric Farman , linux-s390@vger.kernel.org, kvm@vger.kernel.org Subject: [PATCH] vfio-pci/zdev: require KVM to be built-in Date: Sun, 14 Aug 2022 14:51:54 -0700 Message-Id: <20220814215154.32112-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix build errors when CONFIG_KVM=m: s390-linux-ld: drivers/vfio/pci/vfio_pci_zdev.o: in function `vfio_pci_zdev_open_device': vfio_pci_zdev.c:(.text+0x242): undefined reference to `kvm_s390_pci_register_kvm' s390-linux-ld: drivers/vfio/pci/vfio_pci_zdev.o: in function `vfio_pci_zdev_close_device': vfio_pci_zdev.c:(.text+0x296): undefined reference to `kvm_s390_pci_unregister_kvm' Having a bool Kconfig symbol depend on a tristate symbol can often lead to problems like this. Fixes: 8061d1c31f1a ("vfio-pci/zdev: add open/close device hooks") Signed-off-by: Randy Dunlap Reported-by: kernel test robot Cc: Matthew Rosato Cc: Christian Borntraeger Cc: Pierre Morel Cc: Eric Farman Cc: linux-s390@vger.kernel.org Cc: kvm@vger.kernel.org --- drivers/vfio/pci/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/vfio/pci/Kconfig +++ b/drivers/vfio/pci/Kconfig @@ -46,7 +46,7 @@ endif config VFIO_PCI_ZDEV_KVM bool "VFIO PCI extensions for s390x KVM passthrough" - depends on S390 && KVM + depends on S390 && KVM=y default y help Support s390x-specific extensions to enable support for enhancements