Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031954AbXFHTpD (ORCPT ); Fri, 8 Jun 2007 15:45:03 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1031801AbXFHToa (ORCPT ); Fri, 8 Jun 2007 15:44:30 -0400 Received: from ms-smtp-05.nyroc.rr.com ([24.24.2.59]:39135 "EHLO ms-smtp-05.nyroc.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031793AbXFHTo2 (ORCPT ); Fri, 8 Jun 2007 15:44:28 -0400 Subject: Re: [PATCH RT] convert RCU Preempt tasklet into softirq. From: Steven Rostedt To: paulmck@linux.vnet.ibm.com Cc: john stultz , Ingo Molnar , Thomas Gleixner , Oleg Nesterov , LKML , Dipankar Sarma , RT In-Reply-To: <20070608193655.GA18399@linux.vnet.ibm.com> References: <1181180051.18444.31.camel@localhost.localdomain> <20070607041411.GB1783@linux.vnet.ibm.com> <1181226138.18444.54.camel@localhost.localdomain> <20070607161754.GA11941@linux.vnet.ibm.com> <1181240819.10408.14.camel@localhost.localdomain> <20070607210247.GA9390@linux.vnet.ibm.com> <1181316428.10408.30.camel@localhost.localdomain> <20070608193655.GA18399@linux.vnet.ibm.com> Content-Type: text/plain Date: Fri, 08 Jun 2007 15:43:48 -0400 Message-Id: <1181331828.10408.34.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.6.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1187 Lines: 29 On Fri, 2007-06-08 at 12:36 -0700, Paul E. McKenney wrote: > On Fri, Jun 08, 2007 at 11:27:08AM -0400, Steven Rostedt wrote: > > The first time I compiled it, I forgot the ';' and got a warning there. > > But the warning also included "declaring structure softirq_action in > > prototype", so I fixed both the ';' and added the struct. I can try > > compile without it. But I also know that adding #include > > in rcupreempt.h caused issues too. > > If I leave out both the "struct softirq_action" and the > rcu_process_callbacks() declaration,, it compiles for me. > > So I guess the rcu_process_callbacks() should be declared static... OK, I can update the patch to reflect that. Remember, I didn't learn anything from doing this patch, so I have no idea why rcu_procell_callbacks was global. I was just keeping to the norm. :-) Actually, I'll make a separate patch for this change. This is a different issue. -- Steve - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/