Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Lu, Brent" <brent.lu@intel.com>
To:     Sean Hong <sean.hong@quanta.corp-partner.google.com>,
        "perex@perex.cz" <perex@perex.cz>,
        "tiwai@suse.com" <tiwai@suse.com>
CC:     "Rojewski, Cezary" <cezary.rojewski@intel.com>,
        "pierre-louis.bossart@linux.intel.com" 
        <pierre-louis.bossart@linux.intel.com>,
        "liam.r.girdwood@linux.intel.com" <liam.r.girdwood@linux.intel.com>,
        "peter.ujfalusi@linux.intel.com" <peter.ujfalusi@linux.intel.com>,
        "yung-chuan.liao@linux.intel.com" <yung-chuan.liao@linux.intel.com>,
        "ranjani.sridharan@linux.intel.com" 
        <ranjani.sridharan@linux.intel.com>,
        "kai.vehmanen@linux.intel.com" <kai.vehmanen@linux.intel.com>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "Zhi, Yong" <yong.zhi@intel.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] ASoC: Intel: sof_rt5682: Add support for
 jsl_rt5682_rt1019
Thread-Topic: [PATCH] ASoC: Intel: sof_rt5682: Add support for
 jsl_rt5682_rt1019
Thread-Index: AQHYrkFuhd+ftbZDCk+dLVSshb9ioK2vOjTg
Date:   Mon, 15 Aug 2022 02:14:36 +0000
Message-ID: <CY5PR11MB6257F9BB8766EDA67AB9965F97689@CY5PR11MB6257.namprd11.prod.outlook.com>
References: <20220812114804.550809-1-sean.hong@quanta.corp-partner.google.com>
In-Reply-To: <20220812114804.550809-1-sean.hong@quanta.corp-partner.google.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.500.17
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Z9yDAhuWLGZ9MlZLvpP3CBnnSuXWejvCsuPdXEYpOTPeHlp7yhTluiHPhQh1?=
 =?us-ascii?Q?cnEVxyXoAZupSnXNT87JCQgWd+pXfoIX0g+jO3c/5BjW1FrgKp4CgtCZBrQl?=
 =?us-ascii?Q?p2eXi3a46cFebz3eWft8Ufb7Mk0XvR538bH3MVcktyUWe6qCOziAmwiXmsXy?=
 =?us-ascii?Q?/R2JNz9aoswMq0fsGOTIhSCPh4UCU9FWuwxzoPHcaB5r2W2Vk79mYCQUfM2I?=
 =?us-ascii?Q?AsFzO1Ms1zY7Rfd7d3aAZIPLremXfXLLwslKUnGyPoiZX/INjjqivPf0XdZU?=
 =?us-ascii?Q?ahG+00zpVeaf7jVwPIfkklRjJpIhKmRzh3TkmresLQmVEiGIegTZBE8uNHAQ?=
 =?us-ascii?Q?V7c81AhjGM4lCoSJM6UbquPz/t/qEsLkbKoulTI7Ui/+pk0I5+KXFdrMWUVn?=
 =?us-ascii?Q?hM4lm1BhgV0lmqGwunL10/6tl7tTGVD0b6VnlmfaipswlF1TQgerSxCPTbEr?=
 =?us-ascii?Q?axV6Qy3WGPbpyFJl1xuSo5E2NP43roJiJCMxgnnn2fnXXXnra493KHdx3tWu?=
 =?us-ascii?Q?MQtOYXg6BHDkpSr1LJ2BQwYyypvQzKY8RtS0/Mav3YKB4Pt7BpLPi1bI+4yT?=
 =?us-ascii?Q?kqX1pQ0tgajxxm7y2l03omq9iRCf1+VWAng0FKYhELx7tlAnnXzYaK82pqpw?=
 =?us-ascii?Q?oDCyjiYEkyJNMF3QCO3bvKAJfMFAuE38Sz+OJKO48DaKQrMbKU/cFz2RU8Dp?=
 =?us-ascii?Q?JWmgGe1atIcB8mvunU2nBU2/bqySGLGeiNIxmyixewh7SY0EHZfKV9oyBGeE?=
 =?us-ascii?Q?WNMGsnzBJPgIR6FGY/+8zUKlydzv6TeDd/My09AR7f3AsNiULxFKCPt3POc2?=
 =?us-ascii?Q?mA966iI0o74FGO9wHe1FSps3d1E99435RR4JcBmHiA9gNK2W65PLbxBxECMo?=
 =?us-ascii?Q?86DWXESlcsc0wFbfafy3S2jglGyK+3N2dg3leDFQw3/Klwb+CReVQC4vBS1y?=
 =?us-ascii?Q?5IjVr7JJrMF0Zs8Jv9QzBlPJbaFCEceD2giLs6uNFk+pofyOYX0oJjOQYr4C?=
 =?us-ascii?Q?rOC5s7UOty3O4Uw/aIJO6RZvBLtQcAn2sJCNuvZvXbVIdM/uo1HbvTyfhORf?=
 =?us-ascii?Q?Or288whljBQammJSJilttRMktTKAVQHm/5igfr/RROklkLjSMyS1+w5HScGe?=
 =?us-ascii?Q?OkFzKuQhR/TEsciPPOtcIbXBInscAN09DPjLofrTT1UB9PCvqP8WObH2UHTo?=
 =?us-ascii?Q?kyLSnqZpiHaRRgkCWxh9ececy7yr+StnBwt+ampA5/jDQhYE3D4z+naxE/Ko?=
 =?us-ascii?Q?KOeIhVYzPod2lvc9pvNuIXKsNyeeCtnR1hm2gpTxJjQFAKGDsWh6mFz0kAnY?=
 =?us-ascii?Q?7ET5WA0bzu755llwdC/jIGuPAfNK4URgEDGhukOCj5rgmsiPT4JPhnd7WoGU?=
 =?us-ascii?Q?YuAjzwsIYrZcQNomokYCgkoMzC3MR1JgOkLuco4zYcDFXw4Z2iDtbNW9msYQ?=
 =?us-ascii?Q?5lvvujcvjjGnBQxsJydqKJJafV/kqBa5XwEzRehrV2wyMPSc1Mvp7DnAsXWx?=
 =?us-ascii?Q?dM5ksPIu6h6RA0Qoi8Y45/Y3fXFE13/lgXBNWae8GEGjjdXgHYCnRELMLGwj?=
 =?us-ascii?Q?cdESXc6UCFJyOytPVTmbspcq9e54R4uEmaKzLZVw?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6257.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d1b865a1-9f40-43b4-e755-08da7e63e6f3
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Aug 2022 02:14:36.7483
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Cr2rnpHToPXlXT71y0y+TmRmrF8uSc+Xqvgn/nzppznikphlLZBDaYzhpmammAUdCGfwWMJJPECWwB6OUZNZeg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB2055
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

index b95c4b2cda947..139d2468f5f70 100644
--- a/sound/soc/intel/common/soc-acpi-intel-jsl-match.c
+++ b/sound/soc/intel/common/soc-acpi-intel-jsl-match.c
@@ -29,6 +29,11 @@ static const struct snd_soc_acpi_codecs rt1015p_spk =3D =
{
 	.codecs =3D {"RTL1015"}
 };
=20
+static struct snd_soc_acpi_codecs rt1019p_spk =3D {
+	.num_codecs =3D 1,
+	.codecs =3D {"RTL1019"}
+}
Missing semicolon. Please compile the kernel and make sure no error before
submitting patch.

+
 static const struct snd_soc_acpi_codecs mx98360a_spk =3D {
 	.num_codecs =3D 1,
 	.codecs =3D {"MX98360A"}
> @@ -78,6 +83,14 @@ struct snd_soc_acpi_mach
> snd_soc_acpi_intel_jsl_machines[] =3D {
>  		.quirk_data =3D &mx98360a_spk,
>  		.sof_tplg_filename =3D "sof-jsl-rt5682-mx98360a.tplg",
>  	},
> +	{
> +		.comp_ids =3D &rt5682_rt5682s_hp,
> +		.drv_name =3D "jsl_rt5682_rt1019",
> +		.sof_fw_filename =3D "sof-jsl.ri",
Remove this line.

> +		.machine_quirk =3D snd_soc_acpi_codec_list,
> +		.quirk_data =3D &rt1019p_spk,
> +		.sof_tplg_filename =3D "sof-jsl-rt5682-rt1015.tplg",
> +	},
>  	{
>  		.id =3D "10134242",
>  		.drv_name =3D "jsl_cs4242_mx98360a",
> --
> 2.25.1
>=20

Hi Sean,
I guess you are using Chrome tree. Please use the for-next branch of brooni=
e tree
to generate the V2 patch.

$ git clone https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.g=
it
$ git checkout for-next

Brent