Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220815025006.48167-1-mie@igel.co.jp>
In-Reply-To: <20220815025006.48167-1-mie@igel.co.jp>
From:   Shunsuke Mie <mie@igel.co.jp>
Date:   Mon, 15 Aug 2022 12:00:23 +0900
Message-ID: <CANXvt5osmx+iFdVXYQhGcdBiz5VsA60jzdKXg42c_zSDuxoHxg@mail.gmail.com>
Subject: Re: [PATCH] PCI: endpoint: fix Kconfig indent style
To:     Jon Mason <jdmason@kudzu.us>
Cc:     Kishon Vijay Abraham I <kishon@ti.com>,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= <kw@linux.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Frank Li <Frank.Li@nxp.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Ren Zhijie <renzhijie2@huawei.com>, linux-pci@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

I have a question, not related to the patch. Could you please tell me
why the ntb related patches are managed outside the pci branch,
Helgaas's branch? It confused me a little to find the ntb branch.

Thanks,
Shunsuke

2022=E5=B9=B48=E6=9C=8815=E6=97=A5(=E6=9C=88) 11:50 Shunsuke Mie <mie@igel.=
co.jp>:
>
> Change to follow the Kconfig style guide. This patch fixes to use tab
> rather than space to indent, while help text is indented an additional
> two spaces.
>
> Fixes: e35f56bb0330 ("PCI: endpoint: Support NTB transfer between RC and =
EP")
> Signed-off-by: Shunsuke Mie <mie@igel.co.jp>
> ---
>  drivers/pci/endpoint/functions/Kconfig | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/pci/endpoint/functions/Kconfig b/drivers/pci/endpoin=
t/functions/Kconfig
> index 295a033ee9a2..9fd560886871 100644
> --- a/drivers/pci/endpoint/functions/Kconfig
> +++ b/drivers/pci/endpoint/functions/Kconfig
> @@ -27,13 +27,13 @@ config PCI_EPF_NTB
>           If in doubt, say "N" to disable Endpoint NTB driver.
>
>  config PCI_EPF_VNTB
> -        tristate "PCI Endpoint NTB driver"
> -        depends on PCI_ENDPOINT
> -        depends on NTB
> -        select CONFIGFS_FS
> -        help
> -          Select this configuration option to enable the Non-Transparent
> -          Bridge (NTB) driver for PCIe Endpoint. NTB driver implements N=
TB
> -          between PCI Root Port and PCIe Endpoint.
> +       tristate "PCI Endpoint NTB driver"
> +       depends on PCI_ENDPOINT
> +       depends on NTB
> +       select CONFIGFS_FS
> +       help
> +         Select this configuration option to enable the Non-Transparent
> +         Bridge (NTB) driver for PCIe Endpoint. NTB driver implements NT=
B
> +         between PCI Root Port and PCIe Endpoint.
>
> -          If in doubt, say "N" to disable Endpoint NTB driver.
> +         If in doubt, say "N" to disable Endpoint NTB driver.
> --
> 2.17.1
>