Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp2055387rwb; Sun, 14 Aug 2022 20:10:19 -0700 (PDT) X-Google-Smtp-Source: AA6agR7PUpY+bDK6tzmpDcI8eVxHioROXnSI9IeDwxdQvHVh4HrVUjwuix+DqT0GWXoQhuvBftSm X-Received: by 2002:a05:6402:14b:b0:43d:a7dd:4376 with SMTP id s11-20020a056402014b00b0043da7dd4376mr12659889edu.89.1660533019692; Sun, 14 Aug 2022 20:10:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660533019; cv=none; d=google.com; s=arc-20160816; b=gMZcqWFDLkwtyTO9LiZ/MFYiz0EsmPaR9ApZRLHLYJVu8Vi/hDF65rJXQPdi2rz5Bi pJLVKs/Q4hbJLEycuO2spDbFYqNTHD40yG+mTXAhEh/Zmfd9iPgzZGUMx60VhJwBuC5c hSYO1Z6IBxAnPsiCcMZVcKT/bjrWxroe09/TI+HxGOcJMjG4z9gi69b32DlDuoA+petD Kv3p/GT1gjb3xDGKm2rlKeOulY/dHq381w5Pp78H3gi69FLYToX0yeSXjd41BU81RdPX 0YISDHVOIoufWYWa5Nl+UWTun3ie902G513apGUyfXaJatOpdFh3xBwK8t71LcPmVQPQ u5ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=T++k31dEW/zz4iALzmj+VEHzJlOnzJc0X5SoeMwffuA=; b=myLOWeOgDT8F2TYYjcNYuEGkeViVA1ASTtin+zLESX50qpmcE9dib+ioCwt+D2LPbg qh+iH/IIXdJpTliaJ5A5FadSFTu0UsO61wxyFvXIJpyMmoHJpqgfKRT7rSItmDDHFXx/ WsnmMyzRz/kTNmxHsLNpP0tOSkjHoFZGKKld3V0536WfuDDZzaWCtsBt5hipdUtDuc18 9KxiWMSmxow2KWionjopRkycx42EnAonM3kmD94AXm8BdadlrZjpVMtw3iZ8B6Ms6AXX Dk9xpNnuFBxVUGQAEBq1fn1Pg5+bSefhQ27cqbqiC7Z4nDtkUruO4x3hmsB7jE/tHY4F NBNg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w1-20020a1709064a0100b00730936657d1si5878100eju.552.2022.08.14.20.09.54; Sun, 14 Aug 2022 20:10:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230116AbiHODF6 (ORCPT + 99 others); Sun, 14 Aug 2022 23:05:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229512AbiHODF5 (ORCPT ); Sun, 14 Aug 2022 23:05:57 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88C44EE07; Sun, 14 Aug 2022 20:05:55 -0700 (PDT) Received: from dggpeml500026.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4M5fG71fP1z1M8xs; Mon, 15 Aug 2022 11:02:23 +0800 (CST) Received: from huawei.com (10.175.101.6) by dggpeml500026.china.huawei.com (7.185.36.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 15 Aug 2022 11:05:40 +0800 From: Zhengchao Shao To: , , , , , CC: , , , , Subject: [PATCH net-next] net: sched: fix misuse of qcpu->backlog in gnet_stats_add_queue_cpu Date: Mon, 15 Aug 2022 11:08:48 +0800 Message-ID: <20220815030848.276746-1-shaozhengchao@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.101.6] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpeml500026.china.huawei.com (7.185.36.106) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In the gnet_stats_add_queue_cpu function, the qstats->qlen statistics are incorrectly set to qcpu->backlog. Fixes: 448e163f8b9b("gen_stats: Add gnet_stats_add_queue()") Signed-off-by: Zhengchao Shao --- net/core/gen_stats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/gen_stats.c b/net/core/gen_stats.c index a10335b4ba2d..c8d137ef5980 100644 --- a/net/core/gen_stats.c +++ b/net/core/gen_stats.c @@ -345,7 +345,7 @@ static void gnet_stats_add_queue_cpu(struct gnet_stats_queue *qstats, for_each_possible_cpu(i) { const struct gnet_stats_queue *qcpu = per_cpu_ptr(q, i); - qstats->qlen += qcpu->backlog; + qstats->qlen += qcpu->qlen; qstats->backlog += qcpu->backlog; qstats->drops += qcpu->drops; qstats->requeues += qcpu->requeues; -- 2.17.1