Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f13d4881-820f-f6cd-4a70-c46ca3c5089f@kernel.org>
Date:   Mon, 15 Aug 2022 11:38:00 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [f2fs-dev] [PATCH] f2fs: zoned device does not support ATGC
Content-Language: en-US
To:     Jaegeuk Kim <jaegeuk@kernel.org>, linux-kernel@vger.kernel.org,
        linux-f2fs-devel@lists.sourceforge.net
References: <20220811225454.2125297-1-jaegeuk@kernel.org>
From:   Chao Yu <chao@kernel.org>
In-Reply-To: <20220811225454.2125297-1-jaegeuk@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/8/12 6:54, Jaegeuk Kim wrote:
> ATGC is using SSR which violates zoned device. >
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
>   fs/f2fs/super.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 2451623c05a7..212ec2b4926b 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -1298,6 +1298,10 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount)
>   			F2FS_OPTION(sbi).discard_unit =
>   					DISCARD_UNIT_SECTION;
>   		}
> +		if (test_opt(sbi, ATGC)) {
> +			f2fs_err(sbi, "Zoned block device doesn't support ATGC.");
> +			return -EINVAL;
> +		}

ATGC is incompatible with LFS mode, we can check f2fs_lfs_mode() and ATGC
mountoption instead, as zoned device depends on LFS mode.

Thanks,

>   	}
>   
>   #ifdef CONFIG_F2FS_FS_COMPRESSION