Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Wang, Haiyue" <haiyue.wang@intel.com>
To:     Alistair Popple <apopple@nvidia.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "david@redhat.com" <david@redhat.com>,
        "linmiaohe@huawei.com" <linmiaohe@huawei.com>,
        "Huang, Ying" <ying.huang@intel.com>,
        "songmuchun@bytedance.com" <songmuchun@bytedance.com>,
        "naoya.horiguchi@linux.dev" <naoya.horiguchi@linux.dev>,
        "alex.sierra@amd.com" <alex.sierra@amd.com>
Subject: RE: [PATCH v4 1/2] mm: migration: fix the FOLL_GET failure on
 following huge page
Thread-Topic: [PATCH v4 1/2] mm: migration: fix the FOLL_GET failure on
 following huge page
Thread-Index: AQHYsEqaehDxLZhp/0WpLois8QzWXq2vXnsAgAADE2A=
Date:   Mon, 15 Aug 2022 04:40:48 +0000
Message-ID: <BYAPR11MB34954E0692FAD9FFB66FD2E6F7689@BYAPR11MB3495.namprd11.prod.outlook.com>
References: <20220812084921.409142-1-haiyue.wang@intel.com>
 <20220815015909.439623-1-haiyue.wang@intel.com>
 <20220815015909.439623-2-haiyue.wang@intel.com> <5767084.K44AtQxeQl@nvdebian>
In-Reply-To: <5767084.K44AtQxeQl@nvdebian>
Accept-Language: zh-CN, en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.500.17
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5mZNo7iy+8wTMbXNO8cSsdAji13Hgo4TdJcPpbXyMOYErr1hwvMQ8ZrLSdMu?=
 =?us-ascii?Q?9sz8qTRs6XorJ8Ny9pCxFljZkv1j5hNZ+tBKYjxRsOU9OxUBRY7TM4idJ/TE?=
 =?us-ascii?Q?5rnhib0lohY9jIVmtsdbnAybYE0OeM1lkJtc8EJ6NAm6aWnOMtX0+8PxNu1/?=
 =?us-ascii?Q?BmhTq9FiB6lgGh9Ggpf+QreTT4jZbWX9mpDWwQR761HCWYB9fR04iOFlD+tt?=
 =?us-ascii?Q?/BDZaccRjbM7+V352KCzzVKbMyOcWPZXR0D7vS6qqOepdBp5s55LC+369VhZ?=
 =?us-ascii?Q?Tx13OrCeTRxPKEYt4au7xtKTcGuCCFiiVt3DFJVb/mXX/w1KhD2oi7hGaoln?=
 =?us-ascii?Q?Z+ntaOp4Pt92ibmq1BfTXy+4/j9hxRVWnGyfuu9TEyk9P2twW838wY6GUnBk?=
 =?us-ascii?Q?1FouzNeFtwGMeYNgzVgd0LJNvdp/+Q2xjE4QZZ7PgUpzcCgWeKg+PyfXNy3l?=
 =?us-ascii?Q?9W12njKNhZH1mTyTBm03Z+YX/qVtrDMKZydsl+kpgcn1Gh9FK1qTnRdT0rZM?=
 =?us-ascii?Q?kPuFJPJ5ADAS5R1+C3AR+QbxSyrOwYHDTAwegQwVSWGHTgpmF44wDyZAUi/4?=
 =?us-ascii?Q?4qrGk8Mv5f7GvbbJJLUZ3CaDI7Wh2KvdACDL9OmLgrSP45ChqXXhYIVd9gct?=
 =?us-ascii?Q?B4yMQ2PIG/JYLVDGavrQDSM0IOKfGx65HYghh5EO7XgSphzd5Aspho05iHeR?=
 =?us-ascii?Q?gGayNp6OhBC8SyGN2EG7K1NXAobTJakW2B6JA8JTYE/m7q+2IvGbA86sVF+9?=
 =?us-ascii?Q?0FL6Tn9Z4dRfsao+kK2yUhV4MeEQDaH55zgWYDH4UuTRRiy/NNnYj9jhSnM3?=
 =?us-ascii?Q?j234oD9YulA1Dfg6DmxweW5Tu9PyLZnUFPklIax3wyoN5PoDYmiH5Rdc4BNs?=
 =?us-ascii?Q?zRpSJDfZeRD717kZMO069X1uNnDFnV9K4oV+yHvY0ZUiVfQdVdT0fctB51Au?=
 =?us-ascii?Q?cGkYQ0v8p+0XlVWi6JLEMXX+HEnftvpWwjJBIDs+rYHhR8n/yySVizGWF6jY?=
 =?us-ascii?Q?wyHUzGzpoqM4yg3ZcX6mDtAPlU8IXZOx/NddCHpddT0X7r59vl/asbi/P5Lg?=
 =?us-ascii?Q?wq2/pGeQB/BIHeEtgaeDcqzbWtrR7Vz+0F9rcZ9ok6bkNUK6UXUMiNWR3S8w?=
 =?us-ascii?Q?CtzdoJNM7QOLcMuvxn12CSn91XIWJZfHY32DuUMAGp1YiUlYv6RAv9RDeWu4?=
 =?us-ascii?Q?cIsY7Yh+FSQg7Cb+Q+W+OA+cUIcavZZmCQNdX+017upHGnJXeVaWtH7VCEK8?=
 =?us-ascii?Q?7yLFTALuHvoYz6mNn1Al4f5xuGQ8tZdo9o/RXOo+/e44HBWP8+vwrAMsG2rH?=
 =?us-ascii?Q?mleCvueAVIAPBDAYMjk5sUxi/j5jDZ+pzeFsAhei3CpgmnJVU63iDAYWw+qJ?=
 =?us-ascii?Q?c/FAoRrd+y1zL0flLLLgC8V1+fS3bMvRl6i3bVlgINh8gmmtrccEDySN0klD?=
 =?us-ascii?Q?WFBFzg0IRY0T3jcaS5gvO2/bupK2xxhHVo/0LqXbfxMyQldImBhW4oatOeg3?=
 =?us-ascii?Q?KRrUzHnJ+IiJTJbLpVP+gn66vH1jTltPjCfTpHPlSfZ9f/mwfynGJlQuj7l5?=
 =?us-ascii?Q?RUwULdFlrdtQVzWlCd/vFyc4gzn2CeX1hg+wiImN?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3495.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4617a8a0-d01d-4ab6-3efb-08da7e78535f
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Aug 2022 04:40:48.5647
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6HAW42aI7deEnaenjJqQkDvd/yXCR2AElCYWTSxgMT8PPk78qNe4SSCuaOmxNYuE1oQovrU7H5gx4UEr9WqP0w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1917
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HK_RANDOM_ENVFROM,
        HK_RANDOM_FROM,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Alistair Popple <apopple@nvidia.com>
> Sent: Monday, August 15, 2022 12:29
> To: linux-mm@kvack.org; linux-kernel@vger.kernel.org; Wang, Haiyue <haiyu=
e.wang@intel.com>
> Cc: akpm@linux-foundation.org; david@redhat.com; linmiaohe@huawei.com; Hu=
ang, Ying
> <ying.huang@intel.com>; songmuchun@bytedance.com; naoya.horiguchi@linux.d=
ev; alex.sierra@amd.com; Wang,
> Haiyue <haiyue.wang@intel.com>
> Subject: Re: [PATCH v4 1/2] mm: migration: fix the FOLL_GET failure on fo=
llowing huge page
>=20
> On Monday, 15 August 2022 11:59:08 AM AEST Haiyue Wang wrote:
> > Not all huge page APIs support FOLL_GET option, so the __NR_move_pages
> > will fail to get the page node information for huge page.
>=20
> I think you should be explicit in the commit message about which function=
s do
> not support FOLL_GET as it's not obvious what support needs to be added b=
efore
> this fix can be reverted.

Yes, make sense, will add them in new patch.

>=20
> Thanks.
>=20
>  - Alistair
>=20
> > This is an temporary solution to mitigate the racing fix.
> >
> > After supporting follow huge page by FOLL_GET is done, this fix can be
> > reverted safely.
> >
> > Fixes: 4cd614841c06 ("mm: migration: fix possible do_pages_stat_array r=
acing
> with memory offline")
> > Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> > ---
> >  mm/migrate.c | 10 ++++++++--
> >  1 file changed, 8 insertions(+), 2 deletions(-)
> >
> > diff --git a/mm/migrate.c b/mm/migrate.c
> > index 6a1597c92261..581dfaad9257 100644
> > --- a/mm/migrate.c
> > +++ b/mm/migrate.c
> > @@ -1848,6 +1848,7 @@ static void do_pages_stat_array(struct mm_struct =
*mm,
> unsigned long nr_pages,
> >
> >  	for (i =3D 0; i < nr_pages; i++) {
> >  		unsigned long addr =3D (unsigned long)(*pages);
> > +		unsigned int foll_flags =3D FOLL_DUMP;
> >  		struct vm_area_struct *vma;
> >  		struct page *page;
> >  		int err =3D -EFAULT;
> > @@ -1856,8 +1857,12 @@ static void do_pages_stat_array(struct mm_struct=
 *mm,
> unsigned long nr_pages,
> >  		if (!vma)
> >  			goto set_status;
> >
> > +		/* Not all huge page follow APIs support 'FOLL_GET' */
> > +		if (!is_vm_hugetlb_page(vma))
> > +			foll_flags |=3D FOLL_GET;
> > +
> >  		/* FOLL_DUMP to ignore special (like zero) pages */
> > -		page =3D follow_page(vma, addr, FOLL_GET | FOLL_DUMP);
> > +		page =3D follow_page(vma, addr, foll_flags);
> >
> >  		err =3D PTR_ERR(page);
> >  		if (IS_ERR(page))
> > @@ -1865,7 +1870,8 @@ static void do_pages_stat_array(struct mm_struct =
*mm,
> unsigned long nr_pages,
> >
> >  		if (page && !is_zone_device_page(page)) {
> >  			err =3D page_to_nid(page);
> > -			put_page(page);
> > +			if (foll_flags & FOLL_GET)
> > +				put_page(page);
> >  		} else {
> >  			err =3D -ENOENT;
> >  		}
> >
>=20
>=20
>=20