Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
References: <487960bf67c7273ff5606c76f73bb51271bc7b90.1660269441.git-series.apopple@nvidia.com>
 <YvZOSUrXoeYnuCyg@casper.infradead.org>
 <51d4408b-14f5-f6a8-80cf-d23cdb0a7c69@nvidia.com>
 <YvaX6emidD6ddjmb@casper.infradead.org>
User-agent: mu4e 1.6.9; emacs 27.1
From:   Alistair Popple <apopple@nvidia.com>
To:     Matthew Wilcox <willy@infradead.org>
Cc:     John Hubbard <jhubbard@nvidia.com>, linux-mm@kvack.org,
        akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
        "Sierra Guiza, Alejandro (Alex)" <alex.sierra@amd.com>,
        Chaitanya Kulkarni <kch@nvidia.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Felix Kuehling <Felix.Kuehling@amd.com>,
        Jason Gunthorpe <jgg@nvidia.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Muchun Song <songmuchun@bytedance.com>,
        Ralph Campbell <rcampbell@nvidia.com>,
        David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH v4 1/2] mm/gup.c: Don't pass gup_flags to
 check_and_migrate_movable_pages()
Date:   Mon, 15 Aug 2022 15:52:53 +1000
In-reply-to: <YvaX6emidD6ddjmb@casper.infradead.org>
Message-ID: <87czd2vymg.fsf@nvdebian.thelocal>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?eN0Ng59aZ2GzaUDJ9+PTBzxLAJT1ZrpyKbhg+IXXcCsh+dKcTHXxi+A3nq49?=
 =?us-ascii?Q?N1VXADtJd+Ea9QOEgeHTmXCykC96aOFxMBwssQqM4ur33rIbMSUrgSpF09rO?=
 =?us-ascii?Q?3xHFuVI4Ozvq2lc9S8FhLHShxuNwV55yF4DwWy/WjJEZzs551LmV0djgslv8?=
 =?us-ascii?Q?E2GIWyeABOhvfxqeQCyPppqToWAGtHyT5LeUKtDaDx7o6gu+pRi3DJdJX1rz?=
 =?us-ascii?Q?HbyWdojBX2EhPHIi2DIkgW0OTMFjnqB8Y9XQmzoLhD+EXjEGMB34YRserelN?=
 =?us-ascii?Q?pQA0629rVFaxVbf+A/jIwStnbvAWvR7+A1r41eXoqN/BFpZLitsEC5bpgnVs?=
 =?us-ascii?Q?+R724XqXq8eVEcEONZMpqPhex2QikFFvbjmmAXT35F7+p+UsSBQqOCWn6LO+?=
 =?us-ascii?Q?zvwWYKAomXkU3AcQiJBKAza6iacK5B+xZV1ASuypMe/ez5+RK7VHUws6FkGy?=
 =?us-ascii?Q?ZriAo6NxrL104rRJ3uc+WAKua9VIvdofrk8AX4FjfY2w7bTlnLBPH9+//W0v?=
 =?us-ascii?Q?6ehAE5MtUpu8oRD0tg5ezsx/d/sHQzQmapfUTDhva+m8KxZ3ZAPUwMxbTayF?=
 =?us-ascii?Q?pKDdVtc9guGcusoCL4yPz4cFKv1RYbmSSDfqP6kMc/NiTjt7y73v/ILz9/1k?=
 =?us-ascii?Q?fxzuzg1GAwAwOjuBPPOkmo6R31tSnrkP2k53p32U7tf7hHVvcQiLCJsVfXXN?=
 =?us-ascii?Q?fBwM6AHwJvflNZ+UiNg0pkfKS5iVD2YtduA6C/xcmeFbpSilrKjB0TXyVjcv?=
 =?us-ascii?Q?H+QsB4iu6MeZ41LjJThSRj5T4l7K91K7qmtEBe3uivW/jIAzWqZeDFCWBbUL?=
 =?us-ascii?Q?tMs9rYgpdfnn3aC6q6K9rpwAegz65ujUZXkY3ulky4jvUBgHOQR0rlnoaR0f?=
 =?us-ascii?Q?fD4iOJo5CnyaXUrm4j5JUPW8K98YpYmPT+S3W60837nKlbKkZeAZKejhZZ0n?=
 =?us-ascii?Q?GJ0oinZpMKidRQccEB1lsFOWxnKa3YXQE/nYDAPh/f6UBXkvjuk4FcEPSH/4?=
 =?us-ascii?Q?RBGVBsc3t60KJfb04uqL5OJAII6/qNmxMr3JZeRQ/HVwZXuHRORmkl0+hOvO?=
 =?us-ascii?Q?qoW8Tvxe1E/e73fbvqJeckt0+uPhpPPXX6HQ6vSQTFmqjzXBtatpJeBdIIfp?=
 =?us-ascii?Q?ppH8DAx5oMfXnLUeJ6L2b+rJFUMHlCnba9hPo6yYTqoiKzBvXCItsnfIx+kX?=
 =?us-ascii?Q?MFPEDVVHPGPksQegAth7aLuKUsZhQ6iVzzHjVNLbt/HwjRTF4McRSDSRnA3v?=
 =?us-ascii?Q?unEaEXWsYlwRx0a5fsN+0Wyy1vJuLOMFFBStT/k4hOPfdEYzm2n7WbSylt8g?=
 =?us-ascii?Q?QzbRYqyPJJMStXaL3eOJ4ZAjdlnF/cIOxaedYkTs7rFRs+oWEoH1QUH8CxGl?=
 =?us-ascii?Q?AgFDAgMJuuq6rB7o35nrZhxO4xVPNgDGhrMT2nPq0H52RV/YxmF5STwjnSYu?=
 =?us-ascii?Q?vxp1muYYp+/rhVqTjgTRuI668JzEW3deKKKLtNqpKSd0WWPCRHJNUGmA3lLG?=
 =?us-ascii?Q?t7o/pKJh+VDSCPgJgRzPaSKsUt0O9BtgxOB2gBQrSXbSMAaZvrVscpRjbzh2?=
 =?us-ascii?Q?tfXNJJH9KSbqOo+E+/rfwOZowUC8Msi+fP1HpftT?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cb9b58ec-ba4d-4982-e102-08da7e82dac6
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3176.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Aug 2022 05:56:10.9380
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DWEoZHmhp++SIqYT2R81jy67HgQ2YCyjv4JAQuGeNNtnSpUoh4Wh22xrcv2qrStt81cqFUTV41P5qYHe/KJ2zg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB4704
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Matthew Wilcox <willy@infradead.org> writes:

> On Fri, Aug 12, 2022 at 11:02:42AM -0700, John Hubbard wrote:
>> On 8/12/22 05:57, Matthew Wilcox wrote:
>> > On Fri, Aug 12, 2022 at 12:13:08PM +1000, Alistair Popple wrote:
>> > > +			get_page(&folio->page);
>> > > +			unpin_user_page(&folio->page);
>> >
>> > https://lore.kernel.org/linux-mm/YvJddHPZsh7Lwzps@casper.infradead.org/
>>
>> The above fix shows up in patch 2/2. I noticed during review that
>> it was applied to a different patch than the one you replied to,
>> but figured it didn't matter which patch picked up this fix, since
>> the problem precedes either patch.
>
> Oh!  I didn't realise patch 2/2 changed the same lines.  let me go
> and read 2/2.

Oh, and I missed that your original comment was on patch 1/2 not 2/2.
Anyway let me know if you think I should move it to the first patch, I
don't mind either way.