Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Wang, Haiyue" <haiyue.wang@intel.com>
To:     Alistair Popple <apopple@nvidia.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "david@redhat.com" <david@redhat.com>,
        "linmiaohe@huawei.com" <linmiaohe@huawei.com>,
        "Huang, Ying" <ying.huang@intel.com>,
        "songmuchun@bytedance.com" <songmuchun@bytedance.com>,
        "naoya.horiguchi@linux.dev" <naoya.horiguchi@linux.dev>,
        "alex.sierra@amd.com" <alex.sierra@amd.com>
Subject: RE: [PATCH v4 1/2] mm: migration: fix the FOLL_GET failure on
 following huge page
Thread-Topic: [PATCH v4 1/2] mm: migration: fix the FOLL_GET failure on
 following huge page
Thread-Index: AQHYsEqaehDxLZhp/0WpLois8QzWXq2vXnsAgAADE2CAAApTAIAAALnAgAAEbgCAAABUcA==
Date:   Mon, 15 Aug 2022 05:37:54 +0000
Message-ID: <BYAPR11MB34951AED33C858D1E6BFC391F7689@BYAPR11MB3495.namprd11.prod.outlook.com>
References: <20220812084921.409142-1-haiyue.wang@intel.com>
 <8348741.Rxym6mXZyZ@nvdebian>
 <BYAPR11MB349505CD7A028D8132DB40B3F7689@BYAPR11MB3495.namprd11.prod.outlook.com>
 <4639789.K93oBFmSNS@nvdebian>
In-Reply-To: <4639789.K93oBFmSNS@nvdebian>
Accept-Language: zh-CN, en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.500.17
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Co63wDykbJDnO4eObmIAryK4SyRcFppdCNx6Se2o844A68nIlYfS1hTp37sC?=
 =?us-ascii?Q?beIjBD3AwpRiEvY6LnCAY4R7Tdyl+BCBdjUgMScsVkQHNJtm87UZJsHoAi5h?=
 =?us-ascii?Q?RbPLhNZP6cDITWlBo0KWN7pKJZTc/bIQUkGI4GLBplyZCOZ5Hc73E7gi/afc?=
 =?us-ascii?Q?emkPUdrOFCzC27vCaRyopzZHHMITkMeGyJfrYWkGoHvJMsSuazTkMf1do80I?=
 =?us-ascii?Q?HG5wEqx8CNdBiJwIDi2N7mpH8aXI+1+xmEd6M+m9KYwBkb7WutAjLWsvOH4c?=
 =?us-ascii?Q?+A5yoO0ETmId0cwD0JkoPHtkWopyzydj5muDQaDP40YFdp+jn1086XUv2vS5?=
 =?us-ascii?Q?GVKWykfafDfPJmYr4Xej45KM8PfTAYg5PTOePV0spWSYvDMVmhKobotDJpt3?=
 =?us-ascii?Q?cgfJ0kqhxaoXR1l1V8VuCPD46rA4qXh5uxmssCW9hOzHoaMWE8Omktji/oZX?=
 =?us-ascii?Q?jPD8ytK4KkgbclMwHYOh2KF4InLngs/4F4wGR+Kr+FF/Tct/eoJhmd1Bkque?=
 =?us-ascii?Q?PHAUvpstY+pOaxDyj01hgeFV4i+Hd8WFGRAzpBKgV/+spdlWNBWVs4rtGSXl?=
 =?us-ascii?Q?p3Sb98xBYk9k0aZPnEr/2FBQ9gkefttD9IITcAtAKH9WoYKEvwD9/2ucUxEY?=
 =?us-ascii?Q?98G2EnduDTCO/uzkvXp2V9EPawc3QDu6aaEDFxKzpVcwdod1u2slMazI1qSX?=
 =?us-ascii?Q?4VQLr+azKkAyf5n16kfhvrefGg0e22FDinHy5gt7fveSURwmoQESmRdVM4Q1?=
 =?us-ascii?Q?MJQIJLTHbtzj1n7wKaa6XmKQFNEPnv5J3bqYL8yxmAr1TqzHuYWLAtYjtWoh?=
 =?us-ascii?Q?LzCG3Mpg5uTVVaiNONOQTRD0HRP4+4GphRWiXnKGUdS5eohLangDXc78ueyA?=
 =?us-ascii?Q?/X07uwanwHn9r2etyPOekq3HiZTir5W4SFYVI1qi1HIbSZmLL8ap5qhsxs8W?=
 =?us-ascii?Q?FxvjobQghevCJw3C4+W/MPa+VtVD5rhBSAcv1dt8WyPNRiV3fQMSJc2mHBv+?=
 =?us-ascii?Q?ob1qSejkRmqyS+J3eapDaypdacTQkVMC/sUAxOlPXv45cOZZw+552gVGRzMb?=
 =?us-ascii?Q?olQf7SJpzPYfI1ZB9MlVkU230LpWhkGoKqWtzSQMW2gk1wxM+C9m3EweXIXp?=
 =?us-ascii?Q?2da5g8g8leoGjURwtf8u0pqPI51BfVcNpIgL+e10aYRF67ugTQMMhbUCw0Se?=
 =?us-ascii?Q?uaos2J8kIf/h8ZWu9GVvNUoxEzIKnn25lHYChIJuhAXHdVZro3F4nFsSRCea?=
 =?us-ascii?Q?9h+nmzHHxagR9Q/croQrF/Nz20E+IoLFqoFiGD5s/ech9WD/LzZk0KhWqAjU?=
 =?us-ascii?Q?XWg7k+H41UnB12fbuJkBv6dpPU4lNQBkyDribE3omLC+NqQr8X/Hl6RpMigj?=
 =?us-ascii?Q?WHG+rkTHxSzryx/3PW0Dwmas2QcqB+sxoaeCOAqCX+PcVCQgl4TOBUaCLht4?=
 =?us-ascii?Q?/WGhQ1U5isHMujdND69dfbm770SumiBVSDdP5e68yvUrnW0QouKiPB+ehm96?=
 =?us-ascii?Q?OqhmGoBl+2OWymjMWn+VDDn9nKP6daGAoNzEZwoMFhwinKS0hM40tZvGKA4c?=
 =?us-ascii?Q?rxOqUJ/WJQHtBCnJjJZ1MZiYsyQL6Tqxe+neguAz?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3495.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7188c41a-602c-42c4-3ed1-08da7e804d15
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Aug 2022 05:37:54.0185
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: o/PoIHjt9ellFUNRhBNc+3EKzRR75DKxIe2lfqqRs83Sa3tnMoT+8aXofEfPgYNawSddiWfj8EF6v6kAg5oEsg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2155
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HK_RANDOM_ENVFROM,
        HK_RANDOM_FROM,RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Alistair Popple <apopple@nvidia.com>
> Sent: Monday, August 15, 2022 13:35
> To: linux-mm@kvack.org; linux-kernel@vger.kernel.org; Wang, Haiyue <haiyu=
e.wang@intel.com>
> Cc: akpm@linux-foundation.org; david@redhat.com; linmiaohe@huawei.com; Hu=
ang, Ying
> <ying.huang@intel.com>; songmuchun@bytedance.com; naoya.horiguchi@linux.d=
ev; alex.sierra@amd.com
> Subject: Re: [PATCH v4 1/2] mm: migration: fix the FOLL_GET failure on fo=
llowing huge page
>=20
> On Monday, 15 August 2022 3:20:28 PM AEST Wang, Haiyue wrote:
> > > -----Original Message-----
> > > From: Alistair Popple <apopple@nvidia.com>
> > > Sent: Monday, August 15, 2022 13:17
> > > To: linux-mm@kvack.org; linux-kernel@vger.kernel.org; Wang, Haiyue
> <haiyue.wang@intel.com>
> > > Cc: akpm@linux-foundation.org; david@redhat.com; linmiaohe@huawei.com=
;
> Huang, Ying
> > > <ying.huang@intel.com>; songmuchun@bytedance.com;
> naoya.horiguchi@linux.dev; alex.sierra@amd.com
> > > Subject: Re: [PATCH v4 1/2] mm: migration: fix the FOLL_GET failure o=
n
> following huge page
> > >
> > > On Monday, 15 August 2022 2:40:48 PM AEST Wang, Haiyue wrote:
> > > > > -----Original Message-----
> > > > > From: Alistair Popple <apopple@nvidia.com>
> > > > > Sent: Monday, August 15, 2022 12:29
> > > > > To: linux-mm@kvack.org; linux-kernel@vger.kernel.org; Wang, Haiyu=
e
> > > <haiyue.wang@intel.com>
> > > > > Cc: akpm@linux-foundation.org; david@redhat.com; linmiaohe@huawei=
.com;
> > > Huang, Ying
> > > > > <ying.huang@intel.com>; songmuchun@bytedance.com;
> > > naoya.horiguchi@linux.dev; alex.sierra@amd.com; Wang,
> > > > > Haiyue <haiyue.wang@intel.com>
> > > > > Subject: Re: [PATCH v4 1/2] mm: migration: fix the FOLL_GET failu=
re on
> > > following huge page
> > > > >
> > > > > On Monday, 15 August 2022 11:59:08 AM AEST Haiyue Wang wrote:
> > > > > > Not all huge page APIs support FOLL_GET option, so the
> __NR_move_pages
> > > > > > will fail to get the page node information for huge page.
> > > > >
> > > > > I think you should be explicit in the commit message about which
> functions
> > > do
> > > > > not support FOLL_GET as it's not obvious what support needs to be
> added
> > > before
> > > > > this fix can be reverted.
> > > >
> > > > Yes, make sense, will add them in new patch.
> > >
> > > Actually while you're at it I think it would be good to include a
> description
> > > of the impact of this failure in the commit message. Ie. You're answe=
r to:
> > >
> > > > What are the user-visible runtime effects of this bug?
> > >
> > > As it documents what should be tested if this fix does actually ever =
get
> > > reverted.
> >
> > An short example *.c code to capture the bug in commit message ?
>=20
> That's probably overkill. Just being a bit more explicit about the
> circumstances in which sys_move_pages() actually fails would be good. Eg.
> something like this:
>=20
> "Without this sys_move_pages() will return -ENOENT for 1GB huge page
> memory map when dumping the page node information for nodes !=3D NULL"

OK, understood, will try to add more information about the error. ;-)

>=20
> > >
> > > > >
> > > > > Thanks.
> > > > >
> > > > >  - Alistair
> > > > >
> > > > > > This is an temporary solution to mitigate the racing fix.
> > > > > >
> > > > > > After supporting follow huge page by FOLL_GET is done, this fix=
 can
> be
> > > > > > reverted safely.
> > > > > >
> > > > > > Fixes: 4cd614841c06 ("mm: migration: fix possible
> do_pages_stat_array
> > > racing
> > > > > with memory offline")
> > > > > > Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> > > > > > ---
> > > > > >  mm/migrate.c | 10 ++++++++--
> > > > > >  1 file changed, 8 insertions(+), 2 deletions(-)
> > > > > >
> > > > > > diff --git a/mm/migrate.c b/mm/migrate.c
> > > > > > index 6a1597c92261..581dfaad9257 100644
> > > > > > --- a/mm/migrate.c
> > > > > > +++ b/mm/migrate.c
> > > > > > @@ -1848,6 +1848,7 @@ static void do_pages_stat_array(struct
> mm_struct
> > > *mm,
> > > > > unsigned long nr_pages,
> > > > > >
> > > > > >  	for (i =3D 0; i < nr_pages; i++) {
> > > > > >  		unsigned long addr =3D (unsigned long)(*pages);
> > > > > > +		unsigned int foll_flags =3D FOLL_DUMP;
> > > > > >  		struct vm_area_struct *vma;
> > > > > >  		struct page *page;
> > > > > >  		int err =3D -EFAULT;
> > > > > > @@ -1856,8 +1857,12 @@ static void do_pages_stat_array(struct
> mm_struct
> > > *mm,
> > > > > unsigned long nr_pages,
> > > > > >  		if (!vma)
> > > > > >  			goto set_status;
> > > > > >
> > > > > > +		/* Not all huge page follow APIs support 'FOLL_GET'
> */
> > > > > > +		if (!is_vm_hugetlb_page(vma))
> > > > > > +			foll_flags |=3D FOLL_GET;
> > > > > > +
> > > > > >  		/* FOLL_DUMP to ignore special (like zero) pages */
> > > > > > -		page =3D follow_page(vma, addr, FOLL_GET | FOLL_DUMP);
> > > > > > +		page =3D follow_page(vma, addr, foll_flags);
> > > > > >
> > > > > >  		err =3D PTR_ERR(page);
> > > > > >  		if (IS_ERR(page))
> > > > > > @@ -1865,7 +1870,8 @@ static void do_pages_stat_array(struct
> mm_struct
> > > *mm,
> > > > > unsigned long nr_pages,
> > > > > >
> > > > > >  		if (page && !is_zone_device_page(page)) {
> > > > > >  			err =3D page_to_nid(page);
> > > > > > -			put_page(page);
> > > > > > +			if (foll_flags & FOLL_GET)
> > > > > > +				put_page(page);
> > > > > >  		} else {
> > > > > >  			err =3D -ENOENT;
> > > > > >  		}
> > > > > >
> > > > >
> > > > >
> > > > >
> > > >
> > > >
> > >
> > >
> > >
> >
> >
>=20
>=20
>=20