Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 15 Aug 2022 08:07:01 +0200
From:   Marcus Folkesson <marcus.folkesson@gmail.com>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Kent Gustavsson <kent@minoris.se>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-iio <linux-iio@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v5 7/9] dt-bindings: iio: adc: mcp3911: add
 microchip,data-ready-hiz entry
Message-ID: <Yvnihf6y1qGEOWq7@gmail.com>
References: <20220809073648.167821-1-marcus.folkesson@gmail.com>
 <20220809073648.167821-8-marcus.folkesson@gmail.com>
 <CAHp75VerfFgNKRbE=f0LnpRBr1o=qNwSnUkzq69BeECJFY9Vvw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="swltbkbSHetuPsfS"
Content-Disposition: inline
In-Reply-To: <CAHp75VerfFgNKRbE=f0LnpRBr1o=qNwSnUkzq69BeECJFY9Vvw@mail.gmail.com>
Precedence: bulk


--swltbkbSHetuPsfS
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Aug 09, 2022 at 11:57:19AM +0200, Andy Shevchenko wrote:
> On Tue, Aug 9, 2022 at 9:32 AM Marcus Folkesson
> <marcus.folkesson@gmail.com> wrote:
> >
> > The Data Ready Output Pin is either hard wired to work as high
> > impedance or push-pull. Make it configurable.
>=20
> ...
>=20
> > +    description:
> > +      Data Ready Pin Inactive State Control
> > +      true =3D The DR pin state is high-impedance when data are NOT re=
ady
> > +      false =3D The DR pin state is a logic high when data are NOT rea=
dy
>=20
> Wouldn't be better to move " when data are NOT ready" to the main
> description text:
>=20
>       Data Ready Pin Inactive State Control when data are NOT ready
>=20
> In this case it unloads the list and moves focus from the part of "NOT
> ready" to the real part of what you pointed out here --
> "high-impedance" or "high".

I think I will put it as

Data Ready Pin Inactive State Control
true =3D The DR pin state is high-impedance
false =3D The DR pin state is logic high

As "NOT ready" is redundant is it is a "Inactive state control".

>=20
>=20
> --=20
> With Best Regards,
> Andy Shevchenko

--swltbkbSHetuPsfS
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEBVGi6LZstU1kwSxliIBOb1ldUjIFAmL54oAACgkQiIBOb1ld
UjK5/xAAjXlhTbU0FzS0A7Zdh2V2zprGvzUFGqzLCI0u4n9lC8beI/o9b/uRWR/9
Bz8J5MWTGLS1s09nYsk1A3VseA+M1HSABjd5QPaHf/+tjPqrzO5TJyVQ5nRTXy12
haS8YDOCLoytgNVqq0S5ZRVKjogsJCfJ8Zwf8PM4PmyJJGXVYBPJs66aTWvnuxvH
LuvXsODDE1YtVoOn441oigVQfY5MvrrTx77KmD7ekb1A8/qyZV8NHZ05hAiKsYWn
JYFt4hdHeVec3UxzMaJsgVekrizYwb1CKp+hlDuMMb92CJq1JD5hLmrmAFY/JtGC
IeyZWmPL8QLiHwqTd2xAuWdqsCJxlQbWo9l0lujPxpFADpqVKcpvCQfPfYFJAuba
oAjNpR8ypnApsAoz5RoyKcXMPAEGE9xw7euqu1BDbKGUEUL+X7Zm/9acv4V7uaMv
1fBcqolDncboQqYmW/Dp+fRpU1ZVVezsBQE5+Vy7jwowMWL6XE78PW2fXBUqvLqL
TPut1yjGhDAfSloP2on8yb9geRLqbWKdpIo2ovCN0ebUFdM5JZdKBZYM94yJwveE
KTpZIBGpyS57MKCVI3wbPSDB8qzHNuDCZ2OdNcbL8OvFP72TV75P9tDkr5LMdF+J
rSsF88ds8qOzAz7lU7bmBIS2WuKU+dpLThw+/kgcvb40j12hGA4=
=MRCF
-----END PGP SIGNATURE-----

--swltbkbSHetuPsfS--