Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 15 Aug 2022 09:51:54 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@lists.01.org, Antonio Borneo <antonio.borneo@foss.st.com>
Cc:     lkp@intel.com, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org, Marc Zyngier <maz@kernel.org>
Subject: drivers/irqchip/irq-stm32-exti.c:719 stm32_exti_h_domain_alloc()
 warn: variable dereferenced before check 'host_data->drv_data' (see line
 707)
Message-ID: <202208131739.gJvcs9ls-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EsKugH/sSzN+8/SsTuN6AfWzgNXj6tLDldSKgJEajJ0TbJwuH/l/ur4bNSJ3?=
 =?us-ascii?Q?yyhfaJB4aX/4daqs1UH917g4wMc1KHx1qZlnoTOjN9hPlKP3YMG92/g+/aeC?=
 =?us-ascii?Q?ACVeFBzrIHtD3ZhwnHGuxrw8pTto05f1AcqrEVm3xZC22UDoMj34z4I6Rlyu?=
 =?us-ascii?Q?AWXlMKb/01lbXapKk2gaWF8eALaI0NDTwGkFhbZCYSkBR9oFuxeO55tmH/rx?=
 =?us-ascii?Q?qk48GnEONvRH8rSCplJgYGqsvoA+H+jtjuUrCdAAjkkY7j6MJ5ABvRJia1Co?=
 =?us-ascii?Q?UFO2nMr1ZU2uvJ+W1zzyfexEaWLdbQdG7hOEgyVQY0JyB/TnG/0LuXLlwpUK?=
 =?us-ascii?Q?+kTA+5j0itwhy8cjwIK8rs/m5i2Ez1MxA9gnAquWLjW+QNGS7h58CiumNm1B?=
 =?us-ascii?Q?diA9YwF5hW4QS+iMYWVijtpvYMbYawsqmAHfzV/C/mccNmcgdeTI8pDWaHK9?=
 =?us-ascii?Q?3TJiOwH9rVqtgfQdmZH15koHCP2pukX4OaNVviXvYY40R7lUMDSBKqIKr7+k?=
 =?us-ascii?Q?e2PBWqOajVg5u84OOY6pv4oBTj2mQja8qP1fEjQ3l+GUQXZVgBYRdhi1HKsw?=
 =?us-ascii?Q?j6oDYzhkKWZNyA1ydvs3CU/b0QoV/cxUbBigoZmIOQAcuj59H6cvoYckm/RL?=
 =?us-ascii?Q?mH49iIfcdmv1Ti14LHPaTcGPzp2M9eEFb6RMw1PBy4Rpj1eloZbxbDVu5uQV?=
 =?us-ascii?Q?mQXwOV+pMWrmHwTfkYnEZsaliCQ7z7BeUS+8z3mZGMWlyJwycT126hXaFQK4?=
 =?us-ascii?Q?j31AQlYR08kE2ggSRov2YmBYa65K8TFE6mb0jkpbVUqH0/l/MxDiMUo6HqUL?=
 =?us-ascii?Q?Ia6JhWrZdz3osoP3N3l8gFZntSxrM5JABSOUz5QEH3HVD3Wjr8K5c67gK+Ob?=
 =?us-ascii?Q?2KrSXJhalhoTxrSPUbRguMgDuGZMLh+7SA//DBRbf8BLg7+b4kOmhjEA5qRq?=
 =?us-ascii?Q?2/vui9W76K+PtTK1mTJMZJ6zcorTpkBbLo4ZjlKw3Av8W2AftjKLOOKo9h7B?=
 =?us-ascii?Q?A6mnb8lf/M9eguupbO4hFBrEaMgDTn55fGjtHeDc3ScluFhrKCA0DmdJ/jIU?=
 =?us-ascii?Q?Ec3PI5thvZZH5HzDArnjwVQc00bpIzvbNiauZE/uAWijIgQVxpm6q7NFJltt?=
 =?us-ascii?Q?JORNofYIeaq0a470D5XPgGqc3cnJxOgq8r6PuuKlmcjlDRxr7m3eY97MPG9T?=
 =?us-ascii?Q?3+XiH4dQ2KIjiVPX902vvFL+lK+Uwjm7WEal5EDx1oWOFRaiCJhdiUDCYUGJ?=
 =?us-ascii?Q?s1ZJ/IVlEPOeitMI3oth+zYW2cjqfXWyWJxXjc1KQPhuM/YFa9NMf2MUkQzC?=
 =?us-ascii?Q?bExJdtsXQ0M8+o1gDx85QGfAhf3mzILrQ6s3HGPfvhwv1uRy9UOHykiAe0P0?=
 =?us-ascii?Q?KdVcAJWJ2B4GNnJeFZRqHD2M+9piHsA8joW9ZzENXRUCGF4izNyUM8vO6uE6?=
 =?us-ascii?Q?QUtyjAC3d/iLLYkuPiDD9/XPb6Lb5ocmyd1IadpROaC3acJkjrnDddHizjWI?=
 =?us-ascii?Q?GWCOIF6l7r9Pc1eo2S45ygdoCxc2H+zN5TJF10JAeSRdCF9i1SHVhhlD8eWU?=
 =?us-ascii?Q?rxKDLNsZse1/7K6KWx6+2vbvv1uL1YjQD2oLGkiZ?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?qy2XLB48INODdNT6NnF45feuiaXIzWpwCaiSv2YzffNMR4bK2Bx94QOQg0Hj?=
 =?us-ascii?Q?gR3wF8nFAtaMjur8KAPQ50hypST5Isr4acGrUw4YLqcahiDiUZeADl6O2dsB?=
 =?us-ascii?Q?Ku/DFMb6sJ2BIGeHTOr1zRhZMAiarZa/Wy52UUdDl5ecybyYSMjCc2zgUyh+?=
 =?us-ascii?Q?muh9/IZ9od2kmVmlCeOv8cDzif6ck7Hy3H2QfJLFizwR+SKYCo2GOtwTxkyZ?=
 =?us-ascii?Q?+bbQFY+29SuqlFAlXywBgHvCIGBmXFPPVYfn7XSbqtHYz30yO3bSGDOPPd7s?=
 =?us-ascii?Q?5DSK/IL6+BBY96qmbupINqDUx2IM5HBUN1znftA3Fgn5WhS2rO8rweunQpU1?=
 =?us-ascii?Q?UXFs1x0oiqjRMxKOhmShJYqBcS7hpxEPXB9I7IPdLqaktaX5v3srycxZ8Ktq?=
 =?us-ascii?Q?gE0Kxys8pDsTICtKbzuRmZEnekiUG+2FH+pxXiMXg3K5ofA6PzvthormRf2h?=
 =?us-ascii?Q?TlmyMJUmkJpe9kFjIEe0ktz6nSL+aVu2v+karpBgajMc2mVgKP2T4wg6GTnC?=
 =?us-ascii?Q?su9LyeYuMuNbeQTlNZV2aNncUsAT14GajSXPLiB6PTN95SaYihrFc7/L4eTn?=
 =?us-ascii?Q?DuUvoxlZkuX9/vqh07R0AsS5JAQ0bvRcCW+Ul53h2zd/rqGi27atuo+bH6+d?=
 =?us-ascii?Q?G3bhzApfLmHUBxtR9jxQYYrY73tF6pYdBK74+9NhBJiNUomI50FSpw4a11nN?=
 =?us-ascii?Q?RvsEUCB+ja/VL6gokdShwIgjY/A1b2iPX/0O87JkSLrlH7di9RcfMhPt5OGv?=
 =?us-ascii?Q?OtqNfyjv2eSq9OTI+p+1ik8hCdfwXMHFSO39hajZ/W/7Uwav1o73LfUjvF9k?=
 =?us-ascii?Q?sY53nNJxT7oemEbEy5U7Ue6j1Lc2sjGJAjhXypNCeR5nK3NWL57HaTCeXw0p?=
 =?us-ascii?Q?1uxsgI6wAVrUXOFA7Lhiza0RLip4tl8mOztcEAKZjXvXMDae7amHUV3oP2r2?=
 =?us-ascii?Q?zNf7YrrNMj0twWp6Mil2W2qPvs/lM1e1JIme6ayW2NM=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1569a902-bd4a-496f-a308-08da7e8aaa0e
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Aug 2022 06:52:05.2050
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AyyAoHWoTkITGpcQv618ow1d+tKPI1IUr06EQnAW2qHFCfo5aUaSXhviO6M37/5He0OAggKLcnuBXkctYJ5n+JrZDyHfFsWrLtwwROgYSVQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2488
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-15_04,2022-08-11_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 mlxscore=0
 adultscore=0 mlxlogscore=999 bulkscore=0 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000
 definitions=main-2208150024
X-Proofpoint-GUID: 2Z9PR8uYfb2IQxnlIT1nNkaHYZR5aggQ
X-Proofpoint-ORIG-GUID: 2Z9PR8uYfb2IQxnlIT1nNkaHYZR5aggQ
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   69dac8e431af26173ca0a1ebc87054e01c585bcc
commit: c297493336b7bc0c12ced484a9e61d04ec2d9403 irqchip/stm32-exti: Simplify irq description table
config: arm-randconfig-m041-20220812 (https://download.01.org/0day-ci/archive/20220813/202208131739.gJvcs9ls-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/irqchip/irq-stm32-exti.c:719 stm32_exti_h_domain_alloc() warn: variable dereferenced before check 'host_data->drv_data' (see line 707)

vim +719 drivers/irqchip/irq-stm32-exti.c

927abfc4461e7fd7 Ludovic Barre    2018-04-26  692  static int stm32_exti_h_domain_alloc(struct irq_domain *dm,
927abfc4461e7fd7 Ludovic Barre    2018-04-26  693  				     unsigned int virq,
927abfc4461e7fd7 Ludovic Barre    2018-04-26  694  				     unsigned int nr_irqs, void *data)
927abfc4461e7fd7 Ludovic Barre    2018-04-26  695  {
927abfc4461e7fd7 Ludovic Barre    2018-04-26  696  	struct stm32_exti_host_data *host_data = dm->host_data;
927abfc4461e7fd7 Ludovic Barre    2018-04-26  697  	struct stm32_exti_chip_data *chip_data;
c297493336b7bc0c Antonio Borneo   2022-06-06  698  	u8 desc_irq;
927abfc4461e7fd7 Ludovic Barre    2018-04-26  699  	struct irq_fwspec *fwspec = data;
927abfc4461e7fd7 Ludovic Barre    2018-04-26  700  	struct irq_fwspec p_fwspec;
927abfc4461e7fd7 Ludovic Barre    2018-04-26  701  	irq_hw_number_t hwirq;
9d6a5fe1757cbbd9 Alexandre Torgue 2020-07-17  702  	int bank;
ce4ef8f9f2abcf10 Antonio Borneo   2022-06-06  703  	u32 event_trg;
ce4ef8f9f2abcf10 Antonio Borneo   2022-06-06  704  	struct irq_chip *chip;
927abfc4461e7fd7 Ludovic Barre    2018-04-26  705  
927abfc4461e7fd7 Ludovic Barre    2018-04-26  706  	hwirq = fwspec->param[0];
c16ae609214e8356 Antonio Borneo   2022-06-06 @707  	if (hwirq >= host_data->drv_data->bank_nr * IRQS_PER_BANK)
                                                                     ^^^^^^^^^^^^^^^^^^^^^
derefernce

c16ae609214e8356 Antonio Borneo   2022-06-06  708  		return -EINVAL;
c16ae609214e8356 Antonio Borneo   2022-06-06  709  
927abfc4461e7fd7 Ludovic Barre    2018-04-26  710  	bank  = hwirq / IRQS_PER_BANK;
927abfc4461e7fd7 Ludovic Barre    2018-04-26  711  	chip_data = &host_data->chips_data[bank];
927abfc4461e7fd7 Ludovic Barre    2018-04-26  712  
ce4ef8f9f2abcf10 Antonio Borneo   2022-06-06  713  	event_trg = readl_relaxed(host_data->base + chip_data->reg_bank->trg_ofst);
ce4ef8f9f2abcf10 Antonio Borneo   2022-06-06  714  	chip = (event_trg & BIT(hwirq % IRQS_PER_BANK)) ?
ce4ef8f9f2abcf10 Antonio Borneo   2022-06-06  715  	       &stm32_exti_h_chip : &stm32_exti_h_chip_direct;
ce4ef8f9f2abcf10 Antonio Borneo   2022-06-06  716  
ce4ef8f9f2abcf10 Antonio Borneo   2022-06-06  717  	irq_domain_set_hwirq_and_chip(dm, virq, hwirq, chip, chip_data);
c297493336b7bc0c Antonio Borneo   2022-06-06  718  
c297493336b7bc0c Antonio Borneo   2022-06-06 @719  	if (!host_data->drv_data || !host_data->drv_data->desc_irqs)
                                                             ^^^^^^^^^^^^^^^^^^^
checked too late

c297493336b7bc0c Antonio Borneo   2022-06-06  720  		return -EINVAL;
c297493336b7bc0c Antonio Borneo   2022-06-06  721  
c297493336b7bc0c Antonio Borneo   2022-06-06  722  	desc_irq = host_data->drv_data->desc_irqs[hwirq];
c297493336b7bc0c Antonio Borneo   2022-06-06  723  	if (desc_irq != EXTI_INVALID_IRQ) {
927abfc4461e7fd7 Ludovic Barre    2018-04-26  724  		p_fwspec.fwnode = dm->parent->fwnode;
927abfc4461e7fd7 Ludovic Barre    2018-04-26  725  		p_fwspec.param_count = 3;
927abfc4461e7fd7 Ludovic Barre    2018-04-26  726  		p_fwspec.param[0] = GIC_SPI;
c297493336b7bc0c Antonio Borneo   2022-06-06  727  		p_fwspec.param[1] = desc_irq;
927abfc4461e7fd7 Ludovic Barre    2018-04-26  728  		p_fwspec.param[2] = IRQ_TYPE_LEVEL_HIGH;
927abfc4461e7fd7 Ludovic Barre    2018-04-26  729  
927abfc4461e7fd7 Ludovic Barre    2018-04-26  730  		return irq_domain_alloc_irqs_parent(dm, virq, 1, &p_fwspec);
927abfc4461e7fd7 Ludovic Barre    2018-04-26  731  	}
927abfc4461e7fd7 Ludovic Barre    2018-04-26  732  
927abfc4461e7fd7 Ludovic Barre    2018-04-26  733  	return 0;
927abfc4461e7fd7 Ludovic Barre    2018-04-26  734  }

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp