Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <df52247f-3b53-c570-8229-f123305de7d0@windriver.com>
Date:   Mon, 15 Aug 2022 15:45:02 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] ARM: uaccess: Disable KASAN for uaccess_with_memcpy.c
Content-Language: en-US
To:     linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, nathan@kernel.org,
        ndesaulniers@google.com, trix@redhat.com
References: <20220711094859.4769-1-zhe.he@windriver.com>
From:   He Zhe <zhe.he@windriver.com>
In-Reply-To: <20220711094859.4769-1-zhe.he@windriver.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZFRzOXZQVXhLOHlHV3JvZTM1RFBqbmNkVi8zRUlWUFQ4QVVRS1htbmhJV0Z5?=
 =?utf-8?B?NmIvcjR0Wm5PalFtNTZJdlJ3b29JK0hPelo3dXlTM0UxREJFMHRVeUhjQjJU?=
 =?utf-8?B?QnkzUzF5MmRwQjhYRHE1S25GaU9zUk9IaGUycngzemxQZy9VWE5kbE94L3J3?=
 =?utf-8?B?ejk0cXh6ODNveVBxWVdQUkJxWm5zVFU3eWVWYmNHTDJ4ckxjZkFYbGxkWVFB?=
 =?utf-8?B?OWhlOVlHbEs3d05PaXdMckdmRFNkK0M1YUtDSTlQREEweEkyQ3Rma2MwRDFa?=
 =?utf-8?B?Um5tcUxKNTVJQjREeVYvS2FXSktjaU55UmlFRUsxQlkxN2duTys2NlRSbWU4?=
 =?utf-8?B?bk9FZlV5blhsY2NWTkJJT1pETVhJK1pDQ003S1l1VjFxcitDcG1YRzJPS3Zn?=
 =?utf-8?B?RXQ1VVlXbkRBWmFEaDhtUnR3cEhUZVgrSlUvRGl5b2hQSVgrOEREVnpHQjJp?=
 =?utf-8?B?eDdyUzlSN05KdmlJNHp3aXA3bGgzbml4emVtYTZqTTdQZzJYQXo1YVJDTTFj?=
 =?utf-8?B?bFIxeUVlRUtaRXZ0LzJWYUpJYm5UZnNHMC81UTBLcTVmUkxlZTZvL1ZHbFNT?=
 =?utf-8?B?VUpTb1o3T2lDdWtTWEVpYUYzY0R4MzV4VER2YVNrVTFQTjc0UURITG9hSkU1?=
 =?utf-8?B?L1JVY0hqVm5SanBvQjRHRDRkamFjL2hGUXJmK25neS9EL1l2S01jczdUTXJy?=
 =?utf-8?B?ZldxVEU4aEo5SWp4UmdkMTFlQXVtMC9jTFdKVU1lUUxXb01BczZqdGJyZzVU?=
 =?utf-8?B?Mis2WWFwRXF2UUwxTFI1b2Z1eTk3ZHYzTkFvRHR5VVcrYjlvRTVkaFM0dDNl?=
 =?utf-8?B?VklwdXNzdHpkd0FBNDlvSy9LVk5Qd1NMYVBpekRTWEJzVi93ZVY3emFXeW9G?=
 =?utf-8?B?MWdNSnN6M05ETjh5NnhVcXFoTTdab1hSV2JGbkp6ZEl6QklGdmNLb3U5c28x?=
 =?utf-8?B?dWw1V25oN0xJZ1k1OG5ndHFGT3ZTWjkwdHF5R2dqT1hFSXJKTGZ0cDBuWTc4?=
 =?utf-8?B?aEdJZkh3WHMzaVNXaWN4Wk1oakl2VlZuNTRrQ3JrT3gzM2FidEF1SG04RkE3?=
 =?utf-8?B?YmRvdlYzNGZ1eWRGbzVoTXZ4TkpJYVkwbFFURGhobDcxdW1VOTFlQ2xUbnMr?=
 =?utf-8?B?cHErTnpoYThvRHMxMkV3NWI2U0hsUWc4bFpJbnRzVkk3Q2VvY3lsUWVxRFVE?=
 =?utf-8?B?MWcyQU5kT1RpYXhpb2FyRUxRNXgvM2J4UmNkY1VDS0VtdDg1Rmp6MEJCUWdY?=
 =?utf-8?B?NXV4c0NWaG4vaFNDU203cUx3Q0JmYUw0c2lpQzlMRy9tSEhDVXcvd2lTU3ZD?=
 =?utf-8?B?eFBKRHBMZEpuRDdEUThta2FxM3NuYjdDTWgrL3pPeFF4eldwSzd5MWtxWU5o?=
 =?utf-8?B?WFJQZlp1WEt3RzRuMmlMK3Erc3h5WVJwd2hBYldPNTFqcm9IdFdQZkgwd1VV?=
 =?utf-8?B?ZC9VbEpaTDhhaWFYK1VrZmVwcW5MTTFzRzl3ZU80Szc3cnRGVTd3Q1RnTlVJ?=
 =?utf-8?B?aEdUK0xIeVNSVUV2V0hlYUFGUXB2bXVKYUozSHlaRVB1MXZyRjd1QUtVV0J3?=
 =?utf-8?B?Q2Y4eGdrUDNNRzJndnEvUElXUVZKUWlHbjJhZFFGakdoN254T1JEeXpnRnJo?=
 =?utf-8?B?ZDJwVXBwT25hVWdheGJiMFNVRU9IaFkxUTRBc3U5MnpNMmlYWkUzVlE0cHUv?=
 =?utf-8?B?TG9VREprYTdhbEJoWTI3REV4U253WXJWTkwyQkd0amxWcFNMT1lqcndVd1hX?=
 =?utf-8?B?N2w1cnpHZHo4T1JmSG5WaGZzaGJ0UlpHTDNTY25TbzFXb0lGaFJKZEhWM2JH?=
 =?utf-8?B?cVFRRExyZ2wwY2VrblNTZmlBYTg0cmxWbmdvS2dIUU1MMmd3ZWE3eHpabDBk?=
 =?utf-8?B?MjdKclI4ZlhVb1QvR2ZrTG5kOEpEYmpqZnJHdjdtdk9jd29mVy81Q2Z4eWsx?=
 =?utf-8?B?WjE4SThBY01sYjN0aUxIUmpXcHZyYzRBTThzZ2xocTd1dXRnWjFrQ1Qyc0h6?=
 =?utf-8?B?VmQybXJ6L0Mza0ZRNnp0TVZyVGxkaTFyY240TXV4VzBTeEF2eUZIbkZQWTRk?=
 =?utf-8?B?N1dWQmdjdzVjOG1OM2R0bTIxVzdBdU9EUFcwN2FOMU5sYnFOWkNUOWJockdm?=
 =?utf-8?Q?cTlu7Tykrohmt0s/EKS40HcXS?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 81464afd-a67a-4bff-c84a-08da7e921527
X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1358.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Aug 2022 07:45:11.5350
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jlTwrugVWCBw/xNcZ8yIG89YFwispDiJTjn34wNKLFxjPUnHTzlY0vSC+Nw1mOZnc6O3DbAzUM8+G1S15ciEQA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2751
X-Proofpoint-GUID: dD7tMM9S8m6Pq3txtLYtdZ0teQlBV2UX
X-Proofpoint-ORIG-GUID: dD7tMM9S8m6Pq3txtLYtdZ0teQlBV2UX
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-15_04,2022-08-11_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0
 mlxlogscore=527 clxscore=1011 phishscore=0 bulkscore=0 priorityscore=1501
 impostorscore=0 spamscore=0 lowpriorityscore=0 mlxscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000
 definitions=main-2208150026
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Oops, some reviewers were missing at first.

Zhe

On 7/11/22 17:48, He Zhe wrote:
> uaccess_with_memcpy.c accesses user-space address on purpose. We should
> disable KASAN instrumentation for it, otherwise we would have call traces
> like the following.
>
> BUG: KASAN: user-memory-access in __clear_user_memset+0x154/0x21c
> Write of size 4032 at addr 00501040 by task init/1
>
> CPU: 1 PID: 1 Comm: init Not tainted 5.15.52-yocto-standard #1
> Hardware name: Xilinx Zynq Platform
> [<80116be8>] (unwind_backtrace) from [<8010ea3c>] (show_stack+0x18/0x1c)
> [<8010ea3c>] (show_stack) from [<80fc287c>] (dump_stack_lvl+0x40/0x4c)
> [<80fc287c>] (dump_stack_lvl) from [<80391148>] (kasan_report+0x19c/0x1cc)
> [<80391148>] (kasan_report) from [<80391b78>] (kasan_check_range+0x20/0x174)
> [<80391b78>] (kasan_check_range) from [<8039230c>] (memset+0x20/0x3c)
> [<8039230c>] (memset) from [<808112f0>] (__clear_user_memset+0x154/0x21c)
> [<808112f0>] (__clear_user_memset) from [<8044a9d4>] (clear_user+0x44/0x5c)
> [<8044a9d4>] (clear_user) from [<8044aa0c>] (padzero+0x20/0x38)
> [<8044aa0c>] (padzero) from [<8044ca00>] (load_elf_binary+0x994/0x1740)
> [<8044ca00>] (load_elf_binary) from [<803b4ed0>] (bprm_execve+0x420/0x8ec)
> [<803b4ed0>] (bprm_execve) from [<803b5bc0>] (kernel_execve+0x15c/0x190)
> [<803b5bc0>] (kernel_execve) from [<80fb9bf0>] (try_to_run_init_process+0x14/0x40)
> [<80fb9bf0>] (try_to_run_init_process) from [<80fccd3c>] (kernel_init+0xc8/0x148)
> [<80fccd3c>] (kernel_init) from [<80100130>] (ret_from_fork+0x14/0x24)
>
> Signed-off-by: He Zhe <zhe.he@windriver.com>
> ---
>  arch/arm/lib/Makefile | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/lib/Makefile b/arch/arm/lib/Makefile
> index 6d2ba454f25b..ddeb46efed80 100644
> --- a/arch/arm/lib/Makefile
> +++ b/arch/arm/lib/Makefile
> @@ -27,6 +27,7 @@ endif
>  
>  # using lib_ here won't override already available weak symbols
>  obj-$(CONFIG_UACCESS_WITH_MEMCPY) += uaccess_with_memcpy.o
> +KASAN_SANITIZE_uaccess_with_memcpy.o := n
>  
>  lib-$(CONFIG_MMU) += $(mmu-y)
>