Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1660225318-4063-1-git-send-email-u0084500@gmail.com>
 <1660225318-4063-3-git-send-email-u0084500@gmail.com> <CANhJrGMnjSu3MMQ2PgvSWztNgG1r-PdyLBdsT3JVqZZSfqky-w@mail.gmail.com>
 <CADiBU39c4P-ZNwjrqm-VxSZOLiobEu--y=iH+Si7a+dwUdmeaA@mail.gmail.com>
In-Reply-To: <CADiBU39c4P-ZNwjrqm-VxSZOLiobEu--y=iH+Si7a+dwUdmeaA@mail.gmail.com>
From:   Matti Vaittinen <mazziesaccount@gmail.com>
Date:   Mon, 15 Aug 2022 10:24:32 +0300
Message-ID: <CANhJrGP_99rU6nGfKmEmvZP_QAW5eqgBuCFmjE4fRwu-Rk5j=w@mail.gmail.com>
Subject: Re: [PATCH 2/2] power: supply: rt9471: Add Richtek RT9471 charger driver
To:     ChiYuan Huang <u0084500@gmail.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Sebastian Reichel <sre@kernel.org>,
        =?UTF-8?B?5ri45a2Q6aao?= <alina_yu@richtek.com>,
        ChiYuan Huang <cy_huang@richtek.com>, alinayu829@gmail.com,
        Linux PM list <linux-pm@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

ma 15. elok. 2022 klo 9.11 ChiYuan Huang (u0084500@gmail.com) kirjoitti:
>
> Matti Vaittinen <mazziesaccount@gmail.com> =E6=96=BC 2022=E5=B9=B48=E6=9C=
=8815=E6=97=A5 =E9=80=B1=E4=B8=80 =E4=B8=8B=E5=8D=881:53=E5=AF=AB=E9=81=93=
=EF=BC=9A
> >
> > Hi ChiYuan,
> >
> > Thanks for the patch :)
> >
> > to 11. elok. 2022 klo 16.43 cy_huang (u0084500@gmail.com) kirjoitti:
> > >
> > > From: ChiYuan Huang <cy_huang@richtek.com>
> > >
> > > Add support for the RT9471 3A 1-Cell Li+ battery charger.
> > >
> > > The RT9471 is a highly-integrated 3A switch mode battery charger with
> > > low impedance power path to better optimize the charging efficiency.
> > >
> > > Co-developed-by: Alina Yu <alina_yu@richtek.com>
> > > Signed-off-by: Alina Yu <alina_yu@richtek.com>
> > > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> > > ---
> >

> > While skimming through the rest of the patch... This may just be my
> > personal preference but wrapper functions with just one line are
> > rarely beneficial. In the worst case they just add more lines AND hide
> > the details of what actually is done without any clear benefits. Well,
> > this is just my view so please ignore this comment if wrappers like
> > this are a "subsystem standard"
> >
> I'm not sure what the 'subsystem standard' is.
> I declare it as 'inline' function and the  function name to tell the
> user what I'm doing.
> This may be silly. But from my aspect, it makes each property set/get
> more clear.

I guess this is Ok if the maintainer does not complain. And if he does
- then we at least know the "subsystem standard" ;)

Yours
  -- Matti
--=20

Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~