Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 15 Aug 2022 11:23:56 +0300
From:   Abel Vesa <abel.vesa@linaro.org>
To:     Peng Fan <peng.fan@nxp.com>
Cc:     "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
        Stephen Boyd <sboyd@kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "abelvesa@kernel.org" <abelvesa@kernel.org>,
        "mturquette@baylibre.com" <mturquette@baylibre.com>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
        kernel test robot <lkp@intel.com>
Subject: Re: [PATCH V2 2/8] clk: imx93: guard imx93_clk_of_match with
 CONFIG_OF
Message-ID: <YvoCnLb1azLr4bno@linaro.org>
References: <20220815013039.474970-1-peng.fan@oss.nxp.com>
 <20220815013039.474970-3-peng.fan@oss.nxp.com>
 <YvoAwL9qhmE03kgi@linaro.org>
 <DU0PR04MB941789A6D3600233D878BBCB88689@DU0PR04MB9417.eurprd04.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <DU0PR04MB941789A6D3600233D878BBCB88689@DU0PR04MB9417.eurprd04.prod.outlook.com>
Precedence: bulk

On 22-08-15 08:19:52, Peng Fan wrote:
> > Subject: Re: [PATCH V2 2/8] clk: imx93: guard imx93_clk_of_match with
> > CONFIG_OF
> > 
> > On 22-08-15 09:30:33, Peng Fan (OSS) wrote:
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > There is build warning when CONFIG_OF is not selected.
> > > >> drivers/clk/imx/clk-imx93.c:324:34: warning: 'imx93_clk_of_match'
> > > >> defined but not used [-Wunused-const-variable=]
> > >      324 | static const struct of_device_id imx93_clk_of_match[] = {
> > >          |                                  ^~~~~~~~~~~~~~~~~~
> > >
> > > Use CONFIG_OF to guard imx93_clk_of_match to avoid build warning.
> > >
> > > Fixes: 24defbe194b6 ("clk: imx: add i.MX93 clk")
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > ---
> > >  drivers/clk/imx/clk-imx93.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/clk/imx/clk-imx93.c b/drivers/clk/imx/clk-imx93.c
> > > index f5c9fa40491c..5099048b7916 100644
> > > --- a/drivers/clk/imx/clk-imx93.c
> > > +++ b/drivers/clk/imx/clk-imx93.c
> > > @@ -321,11 +321,13 @@ static int imx93_clocks_probe(struct
> > platform_device *pdev)
> > >  	return ret;
> > >  }
> > >
> > > +#ifdef CONFIG_OF
> > 
> > Hmm, I'm not sure if we should do this or rather should we make this driver
> > depend somehow on CONFIG_OF in Kconfig.
> > 
> > Looking at the other i.MX clock drivers, it would seem we need this for all
> > them too.
> 
> No. It is i.MX93 use of_match_ptr, I could drop it as i.MX8M.
> 
> Thanks,
> Peng.

Right. Thanks for pointing that out.

> 
> > 
> > I fairly OK with this, but maybe Stephen suggests something different.
> > 
> > Reviewed-by: Abel Vesa <abel.vesa@nxp.com>
> > 

Oups, wrong address here too.

Reviewed-by: Abel Vesa <abel.vesa@linaro.org>

> > >  static const struct of_device_id imx93_clk_of_match[] = {
> > >  	{ .compatible = "fsl,imx93-ccm" },
> > >  	{ /* Sentinel */ },
> > >  };
> > >  MODULE_DEVICE_TABLE(of, imx93_clk_of_match);
> > > +#endif
> > >
> > >  static struct platform_driver imx93_clk_driver = {
> > >  	.probe = imx93_clocks_probe,
> > > --
> > > 2.37.1
> > >