Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: id4a34324:Fastmail
Date:   Mon, 15 Aug 2022 01:34:41 -0700
From:   Andres Freund <andres@anarazel.de>
To:     "Michael S. Tsirkin" <mst@redhat.com>
CC:     Linus Torvalds <torvalds@linux-foundation.org>,
        Jens Axboe <axboe@kernel.dk>,
        James Bottomley <James.Bottomley@hansenpartnership.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Guenter Roeck <linux@roeck-us.net>,
        linux-kernel@vger.kernel.org, Greg KH <gregkh@linuxfoundation.org>
Subject: Re: upstream kernel crashes
User-Agent: K-9 Mail for Android
In-Reply-To: <20220815042623-mutt-send-email-mst@kernel.org>
References: <20220814212610.GA3690074@roeck-us.net> <CAHk-=wgf2EfLHui6A5NbWoaVBB2f8t-XBUiOMkyjN2NU41t6eA@mail.gmail.com> <20220814223743.26ebsbnrvrjien4f@awork3.anarazel.de> <CAHk-=wi6raoJE-1cyRU0YxJ+9ReO1eXmOAq0FwKAyZS7nhvk9w@mail.gmail.com> <1c057afa-92df-ee3c-5978-3731d3db9345@kernel.dk> <20220815013651.mrm7qgklk6sgpkbb@awork3.anarazel.de> <CAHk-=wikzU4402P-FpJRK_QwfVOS+t-3p1Wx5awGHTvr-s_0Ew@mail.gmail.com> <20220815071143.n2t5xsmifnigttq2@awork3.anarazel.de> <20220815034532-mutt-send-email-mst@kernel.org> <20220815081527.soikyi365azh5qpu@awork3.anarazel.de> <20220815042623-mutt-send-email-mst@kernel.org>
Message-ID: <FCDC5DDE-3CDD-4B8A-916F-CA7D87B547CE@anarazel.de>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,=20

On August 15, 2022 1:28:29 AM PDT, "Michael S=2E Tsirkin" <mst@redhat=2Eco=
m> wrote:
>On Mon, Aug 15, 2022 at 01:15:27AM -0700, Andres Freund wrote:
>> Hi,
>>=20
>> On 2022-08-15 03:51:34 -0400, Michael S=2E Tsirkin wrote:
>> > It is possible that GCP gets confused if ring size is smaller than th=
e
>> > device maximum simply because no one did it in the past=2E
>> >=20
>> > So I pushed just the revert of 762faee5a267 to the test branch=2E
>> > Could you give it a spin?
>>=20
>> Seems to fix the issue, at least to the extent I can determine at 1am=
=2E=2E=2E :)
>>=20
>> Greetings,
>>=20
>> Andres Freund
>
>So you tested this:
>
>commit 13df5a7eaeb22561d39354b576bc98a7e2c389f9 (HEAD, kernel=2Eorg/test)
>Author: Michael S=2E Tsirkin <mst@redhat=2Ecom>
>Date:   Mon Aug 15 03:44:38 2022 -0400
>
>    Revert "virtio_net: set the default max ring size by find_vqs()"
>   =20
>    This reverts commit 762faee5a2678559d3dc09d95f8f2c54cd0466a7=2E
>   =20
>    Signed-off-by: Michael S=2E Tsirkin <mst@redhat=2Ecom>
>
>and it fixes both issues right? No crashes no networking issue?

Correct=2E I only did limited testing, but it's survived far longer / more=
 reboots than anything since the commit=2E

Andres
--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E