Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Peng Fan <peng.fan@nxp.com>
To:     Abel Vesa <abel.vesa@linaro.org>,
        "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
        Stephen Boyd <sboyd@kernel.org>
CC:     "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "abelvesa@kernel.org" <abelvesa@kernel.org>,
        "mturquette@baylibre.com" <mturquette@baylibre.com>,
        "sboyd@kernel.org" <sboyd@kernel.org>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
        kernel test robot <lkp@intel.com>
Subject: RE: [PATCH V2 2/8] clk: imx93: guard imx93_clk_of_match with
 CONFIG_OF
Thread-Topic: [PATCH V2 2/8] clk: imx93: guard imx93_clk_of_match with
 CONFIG_OF
Thread-Index: AQHYsEZuYWbH17PgG0WYVC/rOZFd7a2vnfQAgAAAYhA=
Date:   Mon, 15 Aug 2022 08:19:52 +0000
Message-ID: <DU0PR04MB941789A6D3600233D878BBCB88689@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20220815013039.474970-1-peng.fan@oss.nxp.com>
 <20220815013039.474970-3-peng.fan@oss.nxp.com> <YvoAwL9qhmE03kgi@linaro.org>
In-Reply-To: <YvoAwL9qhmE03kgi@linaro.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6IM3LFxF6gEUxQsmf63FqRSgz2QCyF4Lz0kDLDr2tT4yWMzzvBQuHFCD55a4?=
 =?us-ascii?Q?CDZS2SOzzR+ribO9O1TTymF/mIjZOvr8aBs6qSpUPy3pFeg7x5vz8P7lOmnU?=
 =?us-ascii?Q?USGJOj8ej7Y3R9z2F0ZtGnDGbbdTAJ2sKNZ2ix2rzflmWH4Fdelqv/iXibHg?=
 =?us-ascii?Q?UXHejBEX4Rj6Zukl6BvJCiQ3tA92zZ5mGQTS9Nw4UQnzv3w0d6DZscUxfnSw?=
 =?us-ascii?Q?QNBiWjkjYDzmbnC4PWgN9JO0pBzuR16sfUdhmrluvIJl8TGHbmQEUXUEKp67?=
 =?us-ascii?Q?pJ2MM086HnP4IlnX9kIs3iJ1Nl9crvVWtRWNkqRc9sHvR5/iPFJW3qA6aFRT?=
 =?us-ascii?Q?fO854sHc3z0hprWlwTfo5Gs1QL8Uuog62olz/gaAV3UDq435BXUamlK2E4Eg?=
 =?us-ascii?Q?Ke7bY2EXAd6yE1OViD1Fynftf03obvVnWTfHJpxkJDrXtaI6iUdBk/yOxWrb?=
 =?us-ascii?Q?Ky1/21+LkJ9Toybpy6Da+68hkj7+nmlijg32Qawkr4W/WKvINTy+Hx9C704p?=
 =?us-ascii?Q?win3SjUGQFxN0j7/9ZRzYa4gLNbV6t98I39yGPw5zCqokR6kRTxPXyfLvJ3D?=
 =?us-ascii?Q?YXNI6kevO6dMnZPGNej8K4MuwNrNB4l4BQFd4DDyc3ZKiwrNXzbJ7+PO4i+q?=
 =?us-ascii?Q?IaWXRl57YwfA511qTq1QlqYqiqT5Hhp8OkfwNj+YdO+577H9QpBbHjFgXnjK?=
 =?us-ascii?Q?GAEtqJHrF+GYjKQ9q1cccp/N+8QdwCuc+WhMd59vUZ13QXbMTw0/2wg7PaVd?=
 =?us-ascii?Q?XPVxugbk0N+3Sgq25ebumkhKqajxnTKU2JcsmnChgFvmAGlAMy6aUlzAWlWA?=
 =?us-ascii?Q?YgLVcmoFhHv4nWVc8GKJJiUFk93pjk/g7h8qItpnwHDgSZf7ZDYewLjG86B/?=
 =?us-ascii?Q?/afcTfFFu1MeYhtaANwNLXoo1//YOOa1NXLVMWLoJ8YX9D55jyw0OykOsYBq?=
 =?us-ascii?Q?txeoj6eemYkiW/562/D1QnpONmv5R7RUDNIPCH04jZQV4MtUJVQWYjYiLpE+?=
 =?us-ascii?Q?mabZ8j845evQhZ/O/xH8NTdgS8lj+t7bLioIU/eMGoFpnDVYAukvQXPgG8Bq?=
 =?us-ascii?Q?ey7X80goChHwJPlsU67dWuP7ETWV81c4FpQN2WYSI6YGzJmwRZBKWzuw52DQ?=
 =?us-ascii?Q?RXwzhhDNSVfhmj13T2ZPEpNl5WGekLVXA6lZvDZco/HlSS+dIC43mD4r6Rwz?=
 =?us-ascii?Q?J0wi58QNV2bnl2QYloAoggPK3ni8QUq5JM5VA9Y4FBQnAcCU541MNA/GIo2i?=
 =?us-ascii?Q?KgLaE5oIZAOtGlLhSV5485bJhPNrVFePsigsFGaxqNX8usNHNYZJYkCEzldM?=
 =?us-ascii?Q?8j4ZTtFWcAL/XGZDo87b5oqn4TmIcCf3gyZBIhUb7FMV23bekyarkZCWDabv?=
 =?us-ascii?Q?k9Wq0+Z/2K+SJts5cq+rhDy57BaeJepErCIv/c/phKpKuFos8ZdIoY/uZ+aV?=
 =?us-ascii?Q?xa2jU9LK/lYyvp7uBnujwIxwQ0SYjobHFlqJF+DOwqsI14bCeODzvc7hhNUx?=
 =?us-ascii?Q?aqEcLS23lg2utnrlrMjP2RNM82B9IB9LJU2WU4v7CK7osGNZ16cC+j40Kwi6?=
 =?us-ascii?Q?bG2I7nF9g8H2vN1YEJo=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 213da0e2-8f69-4c6f-1257-08da7e96eda7
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Aug 2022 08:19:52.3221
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0nBFVawp5/M9bSFIPIAwNLFgGar47zNi22k/H+wLZ3TnghCQWEtaru7PDJGkZfn2wILLl53VAlnsil2MmjpKUA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8177
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: Re: [PATCH V2 2/8] clk: imx93: guard imx93_clk_of_match with
> CONFIG_OF
>=20
> On 22-08-15 09:30:33, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > There is build warning when CONFIG_OF is not selected.
> > >> drivers/clk/imx/clk-imx93.c:324:34: warning: 'imx93_clk_of_match'
> > >> defined but not used [-Wunused-const-variable=3D]
> >      324 | static const struct of_device_id imx93_clk_of_match[] =3D {
> >          |                                  ^~~~~~~~~~~~~~~~~~
> >
> > Use CONFIG_OF to guard imx93_clk_of_match to avoid build warning.
> >
> > Fixes: 24defbe194b6 ("clk: imx: add i.MX93 clk")
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  drivers/clk/imx/clk-imx93.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/clk/imx/clk-imx93.c b/drivers/clk/imx/clk-imx93.c
> > index f5c9fa40491c..5099048b7916 100644
> > --- a/drivers/clk/imx/clk-imx93.c
> > +++ b/drivers/clk/imx/clk-imx93.c
> > @@ -321,11 +321,13 @@ static int imx93_clocks_probe(struct
> platform_device *pdev)
> >  	return ret;
> >  }
> >
> > +#ifdef CONFIG_OF
>=20
> Hmm, I'm not sure if we should do this or rather should we make this driv=
er
> depend somehow on CONFIG_OF in Kconfig.
>=20
> Looking at the other i.MX clock drivers, it would seem we need this for a=
ll
> them too.

No. It is i.MX93 use of_match_ptr, I could drop it as i.MX8M.

Thanks,
Peng.

>=20
> I fairly OK with this, but maybe Stephen suggests something different.
>=20
> Reviewed-by: Abel Vesa <abel.vesa@nxp.com>
>=20
> >  static const struct of_device_id imx93_clk_of_match[] =3D {
> >  	{ .compatible =3D "fsl,imx93-ccm" },
> >  	{ /* Sentinel */ },
> >  };
> >  MODULE_DEVICE_TABLE(of, imx93_clk_of_match);
> > +#endif
> >
> >  static struct platform_driver imx93_clk_driver =3D {
> >  	.probe =3D imx93_clocks_probe,
> > --
> > 2.37.1
> >