Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <37ba5dec-e313-635c-3b9e-25ab131833d9@intel.com>
Date:   Mon, 15 Aug 2022 16:59:06 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.12.0
Subject: Re: [PATCH 2/8] memblock tests: update zeroed memory check for
 memblock_alloc_* tests
Content-Language: en-US
To:     Rebecca Mckeever <remckee0@gmail.com>,
        Mike Rapoport <rppt@kernel.org>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>
CC:     David Hildenbrand <david@redhat.com>
References: <cover.1660454730.git.remckee0@gmail.com>
 <02cad26bef7bc8c7271bba20deac0e5f0bf081c2.1660454730.git.remckee0@gmail.com>
From:   "Huang, Shaoqin" <shaoqin.huang@intel.com>
In-Reply-To: <02cad26bef7bc8c7271bba20deac0e5f0bf081c2.1660454730.git.remckee0@gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?am93NzRZTXFEUEVOVGVCV1Z0RGxFRWRnUjFGNzFrUWlYdFVsZWk0Wmt5UVpH?=
 =?utf-8?B?V1REb2huZDBUUzVYcUpGdm9ZeTd2VXMxR0dTeTc2WEFkVDZYbWxvUk1Mb3BH?=
 =?utf-8?B?T0RCL1hIaUVRUmJhZTZyWFVhOW05M2sxeXNtb1JsMUlFeGFhbFBUNFRtWDdG?=
 =?utf-8?B?dmtVbWZzQy9KU2VJemdPdjhEOEtSN3NocHlTV3JFR29OcytmMW8yeWM1cFNN?=
 =?utf-8?B?SFEvNThkWlQ3TTEzTTNTZVA4aFd5STBQWk9OL3pJVlJ1K3k2b2Rmcjk4bDcw?=
 =?utf-8?B?QUNBbm4rOVB5cUFNVDFDYnlqalRPdENFK1FhU1JBTkZlQW1jR3M3eGxmWmps?=
 =?utf-8?B?RC90Wk5USEprMlBEamF5bHYxcDBYOTQvOXpKUGR0Y0hQRTBkeCtZVVovVjRx?=
 =?utf-8?B?Wit0TVJEQWYxVlZSbkRiNGdtSTlJZG9pMmhMSFE0WnljU21qcXh1eGY3NVh0?=
 =?utf-8?B?YWtCWVVqNi83a0xHcFFEUFpPK3Nlam93TFFqU01LQXltcHB4TGNKVzFiYmhw?=
 =?utf-8?B?M3BNanRISkQyd3BOeUxzZXhjanF6YXpJT2R0UFBoYnk5QnY4RVRYNVYvWk1E?=
 =?utf-8?B?cHVFcnkzcittOU1Fd1pyS29VdjVYVmR1NUdkMk93TE0rYXI5OTJiS0YvcFI1?=
 =?utf-8?B?YndmdzVobVBQUDl4cWxXRzc5MFNFbjZSditRMGZyd29CZENpSkpWdjBaYVRq?=
 =?utf-8?B?cjE2c0tPTGt5dnNKMFVJNDZ3eFdaQitwa01HWTc0dGIwaHNJakRGK3o3VVVN?=
 =?utf-8?B?dDVUbFRyV3puMHc1S3lkLzRTcHg4Y1JORFJDNmhIZHg0Qmh1aFE2UDBDdWJm?=
 =?utf-8?B?eWtxK2t4b1pqZXZXZ3JoWWlJa2REcmZZWkdpbWx2a2cyTFJpOVQzRXU5bkht?=
 =?utf-8?B?Q1kwSjNoZnJEcmltbzB4bFBmWUVrWHlmcmJmSmpFN2kwdzBFWWhpRmVteUhE?=
 =?utf-8?B?NEZNZUJ1UUtNNStvcjZLYUtzVlNTUGF6MDQzekpGTGRxd21IeEZna2d6T3d6?=
 =?utf-8?B?aW1ncWdoZi9IUXB5bnI2MWRnMjI0cDAxSjI3VThBc3RPOW1VdWJFVko4SWJU?=
 =?utf-8?B?RHE1dkpjbHk4UFpSL3FXSjN3cHhybVZLYkRGWmJIRnU3QUhPekhsM3EvRFM1?=
 =?utf-8?B?TGNIZitrcml4dnFQKzMxaTA4MmpPdy9NREFsVm0vWWFBdVdzVXpWaUpFYUlM?=
 =?utf-8?B?dmFyd29BaWp4SG9sU1gweWdSRnNoMWhZT1orREJvdVZTNDgzVGxKM0NXLzJY?=
 =?utf-8?B?ZTBsdzlTcktFNVdDMmFxeVQxWWxNNGlETVN3aUlnaG5hdXp2dkREYkk3azV1?=
 =?utf-8?B?VDU0ZW1XV25DVDN5blFjOFBkOGJDSDBYV05tRW13T01PN21HVTNqMDR0Nzlo?=
 =?utf-8?B?SnRKM2pEelBSbmljQWRVcDMxNDFKcHlvRkZpeWhlTEM2bHp6UzBDdW9VM3Z2?=
 =?utf-8?B?U3dJTzRqdG5ZUUQvc1NLYjdKVDNEYXVVdUdyYVlsS05IRlhORHNPYUxPSHUw?=
 =?utf-8?B?QVJxbkRFYlQ0SUwxTGFZMzhKWjZ1Z3E1OTB1dHIxQS9VNzhlQmtCZFhvK3Bm?=
 =?utf-8?B?a1c0aTU5SC9GMERWZnRaMGVhNG8weDRRUmhsRTBOT2tGaExFVFlGdnBoeEVN?=
 =?utf-8?B?dFQ2MTNrbHowMktPMWZJVjkxdDFNOXRSYWdURjdPZXJlNnZIMWQxYk12Y3Rw?=
 =?utf-8?B?UVRPMW5FWDQzclhBdkdkMnY5SGFVdWNhcllTSGJ2M3ZhZktCN2t6TTJTaVE4?=
 =?utf-8?B?NnpaMU1BUmZtY3R2Zjhibm5HU2FCVmgrRVdpbVlSYnNXZnhFV2RhRHIzUzhz?=
 =?utf-8?B?Nk9XV01NMnIvdmdMVkY0eE54bzZyb3JqTUF1MGZyeWNWelVISlEwa1FvVUpS?=
 =?utf-8?B?TVNkMWNkaTNUTDVUalRNSWdaQzVhbFpHbUJVU1VnQ2NwSGRERlBkemFYY0oy?=
 =?utf-8?B?d2RoSzRvK1pmSlBud092SlVqamwvS3pYTTNzUDVPeGEyV25IMVdMczFUaHZn?=
 =?utf-8?B?K21BM3Zub1F2SndoS2hyTkl4cC91WHJDeGpCMEtNcXBIdEZRRVFMK3I0bzlr?=
 =?utf-8?B?VWMxMnFHcDE5K0tXbGpLYjl3aUFoWkpVNTJWWExEYXRCNmo5S0FKajNwcmVB?=
 =?utf-8?B?WEFsMUhwc2Y4bXBySkE4elpvNHcyUkpSR1J2TTA1M240UmNEQ1pFdlN2UGNZ?=
 =?utf-8?B?Qmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bd736f81-dd48-4dce-2745-08da7e9c6f06
X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3870.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Aug 2022 08:59:17.2612
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wE9YUORfmmiKQi0f+irlIcSi2Q3HJVccFQoNxCDB181In/LDgm9zX0zihnmjjmqMgFA53hssLnr2qx2LGcXP4A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2686
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

LGTM.

Reviewed-by: Shaoqin Huang <shaoqin.huang@intel.com>

On 8/14/2022 1:53 PM, Rebecca Mckeever wrote:
> Update the assert in memblock_alloc_try_nid() and memblock_alloc_from()
> tests that checks whether the memory is cleared so that it checks the
> entire chunk of allocated memory instead of just the first byte.
> 
> Reviewed-by: David Hildenbrand <david@redhat.com>
> Signed-off-by: Rebecca Mckeever <remckee0@gmail.com>
> ---
>   .../memblock/tests/alloc_helpers_api.c        |  8 +--
>   tools/testing/memblock/tests/alloc_nid_api.c  | 72 +++++--------------
>   2 files changed, 20 insertions(+), 60 deletions(-)
> 
> diff --git a/tools/testing/memblock/tests/alloc_helpers_api.c b/tools/testing/memblock/tests/alloc_helpers_api.c
> index 1069b4bdd5fd..796527cf3bd2 100644
> --- a/tools/testing/memblock/tests/alloc_helpers_api.c
> +++ b/tools/testing/memblock/tests/alloc_helpers_api.c
> @@ -19,7 +19,6 @@ static int alloc_from_simple_generic_check(void)
>   {
>   	struct memblock_region *rgn = &memblock.reserved.regions[0];
>   	void *allocated_ptr = NULL;
> -	char *b;
>   
>   	PREFIX_PUSH();
>   
> @@ -31,10 +30,9 @@ static int alloc_from_simple_generic_check(void)
>   	min_addr = memblock_end_of_DRAM() - SMP_CACHE_BYTES;
>   
>   	allocated_ptr = memblock_alloc_from(size, SMP_CACHE_BYTES, min_addr);
> -	b = (char *)allocated_ptr;
>   
>   	ASSERT_NE(allocated_ptr, NULL);
> -	ASSERT_EQ(*b, 0);
> +	ASSERT_MEM_EQ((char *)allocated_ptr, 0, size);
>   
>   	ASSERT_EQ(rgn->size, size);
>   	ASSERT_EQ(rgn->base, min_addr);
> @@ -66,7 +64,6 @@ static int alloc_from_misaligned_generic_check(void)
>   {
>   	struct memblock_region *rgn = &memblock.reserved.regions[0];
>   	void *allocated_ptr = NULL;
> -	char *b;
>   
>   	PREFIX_PUSH();
>   
> @@ -79,10 +76,9 @@ static int alloc_from_misaligned_generic_check(void)
>   	min_addr = memblock_end_of_DRAM() - (SMP_CACHE_BYTES * 2 - 1);
>   
>   	allocated_ptr = memblock_alloc_from(size, SMP_CACHE_BYTES, min_addr);
> -	b = (char *)allocated_ptr;
>   
>   	ASSERT_NE(allocated_ptr, NULL);
> -	ASSERT_EQ(*b, 0);
> +	ASSERT_MEM_EQ((char *)allocated_ptr, 0, size);
>   
>   	ASSERT_EQ(rgn->size, size);
>   	ASSERT_EQ(rgn->base, memblock_end_of_DRAM() - SMP_CACHE_BYTES);
> diff --git a/tools/testing/memblock/tests/alloc_nid_api.c b/tools/testing/memblock/tests/alloc_nid_api.c
> index 255fd514e9f5..71b7beb35526 100644
> --- a/tools/testing/memblock/tests/alloc_nid_api.c
> +++ b/tools/testing/memblock/tests/alloc_nid_api.c
> @@ -19,7 +19,6 @@ static int alloc_try_nid_top_down_simple_check(void)
>   {
>   	struct memblock_region *rgn = &memblock.reserved.regions[0];
>   	void *allocated_ptr = NULL;
> -	char *b;
>   
>   	PREFIX_PUSH();
>   
> @@ -35,11 +34,10 @@ static int alloc_try_nid_top_down_simple_check(void)
>   
>   	allocated_ptr = memblock_alloc_try_nid(size, SMP_CACHE_BYTES,
>   					       min_addr, max_addr, NUMA_NO_NODE);
> -	b = (char *)allocated_ptr;
>   	rgn_end = rgn->base + rgn->size;
>   
>   	ASSERT_NE(allocated_ptr, NULL);
> -	ASSERT_EQ(*b, 0);
> +	ASSERT_MEM_EQ((char *)allocated_ptr, 0, size);
>   
>   	ASSERT_EQ(rgn->size, size);
>   	ASSERT_EQ(rgn->base, max_addr - size);
> @@ -74,7 +72,6 @@ static int alloc_try_nid_top_down_end_misaligned_check(void)
>   {
>   	struct memblock_region *rgn = &memblock.reserved.regions[0];
>   	void *allocated_ptr = NULL;
> -	char *b;
>   
>   	PREFIX_PUSH();
>   
> @@ -91,11 +88,10 @@ static int alloc_try_nid_top_down_end_misaligned_check(void)
>   
>   	allocated_ptr = memblock_alloc_try_nid(size, SMP_CACHE_BYTES,
>   					       min_addr, max_addr, NUMA_NO_NODE);
> -	b = (char *)allocated_ptr;
>   	rgn_end = rgn->base + rgn->size;
>   
>   	ASSERT_NE(allocated_ptr, NULL);
> -	ASSERT_EQ(*b, 0);
> +	ASSERT_MEM_EQ((char *)allocated_ptr, 0, size);
>   
>   	ASSERT_EQ(rgn->size, size);
>   	ASSERT_EQ(rgn->base, max_addr - size - misalign);
> @@ -128,7 +124,6 @@ static int alloc_try_nid_exact_address_generic_check(void)
>   {
>   	struct memblock_region *rgn = &memblock.reserved.regions[0];
>   	void *allocated_ptr = NULL;
> -	char *b;
>   
>   	PREFIX_PUSH();
>   
> @@ -144,11 +139,10 @@ static int alloc_try_nid_exact_address_generic_check(void)
>   
>   	allocated_ptr = memblock_alloc_try_nid(size, SMP_CACHE_BYTES,
>   					       min_addr, max_addr, NUMA_NO_NODE);
> -	b = (char *)allocated_ptr;
>   	rgn_end = rgn->base + rgn->size;
>   
>   	ASSERT_NE(allocated_ptr, NULL);
> -	ASSERT_EQ(*b, 0);
> +	ASSERT_MEM_EQ((char *)allocated_ptr, 0, size);
>   
>   	ASSERT_EQ(rgn->size, size);
>   	ASSERT_EQ(rgn->base, min_addr);
> @@ -183,7 +177,6 @@ static int alloc_try_nid_top_down_narrow_range_check(void)
>   {
>   	struct memblock_region *rgn = &memblock.reserved.regions[0];
>   	void *allocated_ptr = NULL;
> -	char *b;
>   
>   	PREFIX_PUSH();
>   
> @@ -198,10 +191,9 @@ static int alloc_try_nid_top_down_narrow_range_check(void)
>   
>   	allocated_ptr = memblock_alloc_try_nid(size, SMP_CACHE_BYTES,
>   					       min_addr, max_addr, NUMA_NO_NODE);
> -	b = (char *)allocated_ptr;
>   
>   	ASSERT_NE(allocated_ptr, NULL);
> -	ASSERT_EQ(*b, 0);
> +	ASSERT_MEM_EQ((char *)allocated_ptr, 0, size);
>   
>   	ASSERT_EQ(rgn->size, size);
>   	ASSERT_EQ(rgn->base, max_addr - size);
> @@ -277,7 +269,6 @@ static int alloc_try_nid_min_reserved_generic_check(void)
>   {
>   	struct memblock_region *rgn = &memblock.reserved.regions[0];
>   	void *allocated_ptr = NULL;
> -	char *b;
>   
>   	PREFIX_PUSH();
>   
> @@ -298,10 +289,9 @@ static int alloc_try_nid_min_reserved_generic_check(void)
>   
>   	allocated_ptr = memblock_alloc_try_nid(r2_size, SMP_CACHE_BYTES,
>   					       min_addr, max_addr, NUMA_NO_NODE);
> -	b = (char *)allocated_ptr;
>   
>   	ASSERT_NE(allocated_ptr, NULL);
> -	ASSERT_EQ(*b, 0);
> +	ASSERT_MEM_EQ((char *)allocated_ptr, 0, r2_size);
>   
>   	ASSERT_EQ(rgn->size, total_size);
>   	ASSERT_EQ(rgn->base, reserved_base);
> @@ -332,7 +322,6 @@ static int alloc_try_nid_max_reserved_generic_check(void)
>   {
>   	struct memblock_region *rgn = &memblock.reserved.regions[0];
>   	void *allocated_ptr = NULL;
> -	char *b;
>   
>   	PREFIX_PUSH();
>   
> @@ -351,10 +340,9 @@ static int alloc_try_nid_max_reserved_generic_check(void)
>   
>   	allocated_ptr = memblock_alloc_try_nid(r2_size, SMP_CACHE_BYTES,
>   					       min_addr, max_addr, NUMA_NO_NODE);
> -	b = (char *)allocated_ptr;
>   
>   	ASSERT_NE(allocated_ptr, NULL);
> -	ASSERT_EQ(*b, 0);
> +	ASSERT_MEM_EQ((char *)allocated_ptr, 0, r2_size);
>   
>   	ASSERT_EQ(rgn->size, total_size);
>   	ASSERT_EQ(rgn->base, min_addr);
> @@ -389,7 +377,6 @@ static int alloc_try_nid_top_down_reserved_with_space_check(void)
>   	struct memblock_region *rgn1 = &memblock.reserved.regions[1];
>   	struct memblock_region *rgn2 = &memblock.reserved.regions[0];
>   	void *allocated_ptr = NULL;
> -	char *b;
>   	struct region r1, r2;
>   
>   	PREFIX_PUSH();
> @@ -417,10 +404,9 @@ static int alloc_try_nid_top_down_reserved_with_space_check(void)
>   
>   	allocated_ptr = memblock_alloc_try_nid(r3_size, SMP_CACHE_BYTES,
>   					       min_addr, max_addr, NUMA_NO_NODE);
> -	b = (char *)allocated_ptr;
>   
>   	ASSERT_NE(allocated_ptr, NULL);
> -	ASSERT_EQ(*b, 0);
> +	ASSERT_MEM_EQ((char *)allocated_ptr, 0, r3_size);
>   
>   	ASSERT_EQ(rgn1->size, r1.size + r3_size);
>   	ASSERT_EQ(rgn1->base, max_addr - r3_size);
> @@ -456,7 +442,6 @@ static int alloc_try_nid_reserved_full_merge_generic_check(void)
>   {
>   	struct memblock_region *rgn = &memblock.reserved.regions[0];
>   	void *allocated_ptr = NULL;
> -	char *b;
>   	struct region r1, r2;
>   
>   	PREFIX_PUSH();
> @@ -483,10 +468,9 @@ static int alloc_try_nid_reserved_full_merge_generic_check(void)
>   
>   	allocated_ptr = memblock_alloc_try_nid(r3_size, SMP_CACHE_BYTES,
>   					       min_addr, max_addr, NUMA_NO_NODE);
> -	b = (char *)allocated_ptr;
>   
>   	ASSERT_NE(allocated_ptr, NULL);
> -	ASSERT_EQ(*b, 0);
> +	ASSERT_MEM_EQ((char *)allocated_ptr, 0, r3_size);
>   
>   	ASSERT_EQ(rgn->size, total_size);
>   	ASSERT_EQ(rgn->base, r2.base);
> @@ -522,7 +506,6 @@ static int alloc_try_nid_top_down_reserved_no_space_check(void)
>   	struct memblock_region *rgn1 = &memblock.reserved.regions[1];
>   	struct memblock_region *rgn2 = &memblock.reserved.regions[0];
>   	void *allocated_ptr = NULL;
> -	char *b;
>   	struct region r1, r2;
>   
>   	PREFIX_PUSH();
> @@ -550,10 +533,9 @@ static int alloc_try_nid_top_down_reserved_no_space_check(void)
>   
>   	allocated_ptr = memblock_alloc_try_nid(r3_size, SMP_CACHE_BYTES,
>   					       min_addr, max_addr, NUMA_NO_NODE);
> -	b = (char *)allocated_ptr;
>   
>   	ASSERT_NE(allocated_ptr, NULL);
> -	ASSERT_EQ(*b, 0);
> +	ASSERT_MEM_EQ((char *)allocated_ptr, 0, r3_size);
>   
>   	ASSERT_EQ(rgn1->size, r1.size);
>   	ASSERT_EQ(rgn1->base, r1.base);
> @@ -634,7 +616,6 @@ static int alloc_try_nid_top_down_cap_max_check(void)
>   {
>   	struct memblock_region *rgn = &memblock.reserved.regions[0];
>   	void *allocated_ptr = NULL;
> -	char *b;
>   
>   	PREFIX_PUSH();
>   
> @@ -649,10 +630,9 @@ static int alloc_try_nid_top_down_cap_max_check(void)
>   
>   	allocated_ptr = memblock_alloc_try_nid(size, SMP_CACHE_BYTES,
>   					       min_addr, max_addr, NUMA_NO_NODE);
> -	b = (char *)allocated_ptr;
>   
>   	ASSERT_NE(allocated_ptr, NULL);
> -	ASSERT_EQ(*b, 0);
> +	ASSERT_MEM_EQ((char *)allocated_ptr, 0, size);
>   
>   	ASSERT_EQ(rgn->size, size);
>   	ASSERT_EQ(rgn->base, memblock_end_of_DRAM() - size);
> @@ -674,7 +654,6 @@ static int alloc_try_nid_top_down_cap_min_check(void)
>   {
>   	struct memblock_region *rgn = &memblock.reserved.regions[0];
>   	void *allocated_ptr = NULL;
> -	char *b;
>   
>   	PREFIX_PUSH();
>   
> @@ -689,10 +668,9 @@ static int alloc_try_nid_top_down_cap_min_check(void)
>   
>   	allocated_ptr = memblock_alloc_try_nid(size, SMP_CACHE_BYTES,
>   					       min_addr, max_addr, NUMA_NO_NODE);
> -	b = (char *)allocated_ptr;
>   
>   	ASSERT_NE(allocated_ptr, NULL);
> -	ASSERT_EQ(*b, 0);
> +	ASSERT_MEM_EQ((char *)allocated_ptr, 0, size);
>   
>   	ASSERT_EQ(rgn->size, size);
>   	ASSERT_EQ(rgn->base, memblock_end_of_DRAM() - size);
> @@ -723,7 +701,6 @@ static int alloc_try_nid_bottom_up_simple_check(void)
>   {
>   	struct memblock_region *rgn = &memblock.reserved.regions[0];
>   	void *allocated_ptr = NULL;
> -	char *b;
>   
>   	PREFIX_PUSH();
>   
> @@ -740,11 +717,10 @@ static int alloc_try_nid_bottom_up_simple_check(void)
>   	allocated_ptr = memblock_alloc_try_nid(size, SMP_CACHE_BYTES,
>   					       min_addr, max_addr,
>   					       NUMA_NO_NODE);
> -	b = (char *)allocated_ptr;
>   	rgn_end = rgn->base + rgn->size;
>   
>   	ASSERT_NE(allocated_ptr, NULL);
> -	ASSERT_EQ(*b, 0);
> +	ASSERT_MEM_EQ((char *)allocated_ptr, 0, size);
>   
>   	ASSERT_EQ(rgn->size, size);
>   	ASSERT_EQ(rgn->base, min_addr);
> @@ -779,7 +755,6 @@ static int alloc_try_nid_bottom_up_start_misaligned_check(void)
>   {
>   	struct memblock_region *rgn = &memblock.reserved.regions[0];
>   	void *allocated_ptr = NULL;
> -	char *b;
>   
>   	PREFIX_PUSH();
>   
> @@ -797,11 +772,10 @@ static int alloc_try_nid_bottom_up_start_misaligned_check(void)
>   	allocated_ptr = memblock_alloc_try_nid(size, SMP_CACHE_BYTES,
>   					       min_addr, max_addr,
>   					       NUMA_NO_NODE);
> -	b = (char *)allocated_ptr;
>   	rgn_end = rgn->base + rgn->size;
>   
>   	ASSERT_NE(allocated_ptr, NULL);
> -	ASSERT_EQ(*b, 0);
> +	ASSERT_MEM_EQ((char *)allocated_ptr, 0, size);
>   
>   	ASSERT_EQ(rgn->size, size);
>   	ASSERT_EQ(rgn->base, min_addr + (SMP_CACHE_BYTES - misalign));
> @@ -836,7 +810,6 @@ static int alloc_try_nid_bottom_up_narrow_range_check(void)
>   {
>   	struct memblock_region *rgn = &memblock.reserved.regions[0];
>   	void *allocated_ptr = NULL;
> -	char *b;
>   
>   	PREFIX_PUSH();
>   
> @@ -852,10 +825,9 @@ static int alloc_try_nid_bottom_up_narrow_range_check(void)
>   	allocated_ptr = memblock_alloc_try_nid(size, SMP_CACHE_BYTES,
>   					       min_addr, max_addr,
>   					       NUMA_NO_NODE);
> -	b = (char *)allocated_ptr;
>   
>   	ASSERT_NE(allocated_ptr, NULL);
> -	ASSERT_EQ(*b, 0);
> +	ASSERT_MEM_EQ((char *)allocated_ptr, 0, size);
>   
>   	ASSERT_EQ(rgn->size, size);
>   	ASSERT_EQ(rgn->base, memblock_start_of_DRAM());
> @@ -890,7 +862,6 @@ static int alloc_try_nid_bottom_up_reserved_with_space_check(void)
>   	struct memblock_region *rgn1 = &memblock.reserved.regions[1];
>   	struct memblock_region *rgn2 = &memblock.reserved.regions[0];
>   	void *allocated_ptr = NULL;
> -	char *b;
>   	struct region r1, r2;
>   
>   	PREFIX_PUSH();
> @@ -919,10 +890,9 @@ static int alloc_try_nid_bottom_up_reserved_with_space_check(void)
>   	allocated_ptr = memblock_alloc_try_nid(r3_size, SMP_CACHE_BYTES,
>   					       min_addr, max_addr,
>   					       NUMA_NO_NODE);
> -	b = (char *)allocated_ptr;
>   
>   	ASSERT_NE(allocated_ptr, NULL);
> -	ASSERT_EQ(*b, 0);
> +	ASSERT_MEM_EQ((char *)allocated_ptr, 0, r3_size);
>   
>   	ASSERT_EQ(rgn1->size, r1.size);
>   	ASSERT_EQ(rgn1->base, max_addr);
> @@ -964,7 +934,6 @@ static int alloc_try_nid_bottom_up_reserved_no_space_check(void)
>   	struct memblock_region *rgn2 = &memblock.reserved.regions[1];
>   	struct memblock_region *rgn3 = &memblock.reserved.regions[0];
>   	void *allocated_ptr = NULL;
> -	char *b;
>   	struct region r1, r2;
>   
>   	PREFIX_PUSH();
> @@ -993,10 +962,9 @@ static int alloc_try_nid_bottom_up_reserved_no_space_check(void)
>   	allocated_ptr = memblock_alloc_try_nid(r3_size, SMP_CACHE_BYTES,
>   					       min_addr, max_addr,
>   					       NUMA_NO_NODE);
> -	b = (char *)allocated_ptr;
>   
>   	ASSERT_NE(allocated_ptr, NULL);
> -	ASSERT_EQ(*b, 0);
> +	ASSERT_MEM_EQ((char *)allocated_ptr, 0, r3_size);
>   
>   	ASSERT_EQ(rgn3->size, r3_size);
>   	ASSERT_EQ(rgn3->base, memblock_start_of_DRAM());
> @@ -1024,7 +992,6 @@ static int alloc_try_nid_bottom_up_cap_max_check(void)
>   {
>   	struct memblock_region *rgn = &memblock.reserved.regions[0];
>   	void *allocated_ptr = NULL;
> -	char *b;
>   
>   	PREFIX_PUSH();
>   
> @@ -1040,10 +1007,9 @@ static int alloc_try_nid_bottom_up_cap_max_check(void)
>   	allocated_ptr = memblock_alloc_try_nid(size, SMP_CACHE_BYTES,
>   					       min_addr, max_addr,
>   					       NUMA_NO_NODE);
> -	b = (char *)allocated_ptr;
>   
>   	ASSERT_NE(allocated_ptr, NULL);
> -	ASSERT_EQ(*b, 0);
> +	ASSERT_MEM_EQ((char *)allocated_ptr, 0, size);
>   
>   	ASSERT_EQ(rgn->size, size);
>   	ASSERT_EQ(rgn->base, min_addr);
> @@ -1065,7 +1031,6 @@ static int alloc_try_nid_bottom_up_cap_min_check(void)
>   {
>   	struct memblock_region *rgn = &memblock.reserved.regions[0];
>   	void *allocated_ptr = NULL;
> -	char *b;
>   
>   	PREFIX_PUSH();
>   
> @@ -1081,10 +1046,9 @@ static int alloc_try_nid_bottom_up_cap_min_check(void)
>   	allocated_ptr = memblock_alloc_try_nid(size, SMP_CACHE_BYTES,
>   					       min_addr, max_addr,
>   					       NUMA_NO_NODE);
> -	b = (char *)allocated_ptr;
>   
>   	ASSERT_NE(allocated_ptr, NULL);
> -	ASSERT_EQ(*b, 0);
> +	ASSERT_MEM_EQ((char *)allocated_ptr, 0, size);
>   
>   	ASSERT_EQ(rgn->size, size);
>   	ASSERT_EQ(rgn->base, memblock_start_of_DRAM());