Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp2297204rwb; Mon, 15 Aug 2022 02:47:02 -0700 (PDT) X-Google-Smtp-Source: AA6agR47NgyNAuPrJ9th8a2mWcY8BiOw+VEALs1AV8hULbkMZgSYlXIukxYyIVKF8OUrPrWJ2QfR X-Received: by 2002:a17:907:2c4a:b0:730:87ff:b69 with SMTP id hf10-20020a1709072c4a00b0073087ff0b69mr9969346ejc.116.1660556821748; Mon, 15 Aug 2022 02:47:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660556821; cv=none; d=google.com; s=arc-20160816; b=MeOyfCBbt2QbXjyZbcE+PhDRGInIfR2640Ps09wd8k/E8dcrz92bRtSLBSK/XGGdaK QU4Pnai2IHhb9dS8yODZ5MHiyd6WDeiSIGaqnbIJHDY1CizGW0CyPTJcw614XS01MsHO TWfHP0PaYWjeoe+lZW8YLmb4D1jE2IgUXrsz3mYRlBGwe/4EhmtjMLFsar7KEhcI9l5w 1i1Bmtt+Fd8COo7uxU0UqBU7B526s5jpj0FDyCpZCneSMLow8l2rLYw2VK91QKho7Kni uDaMS2iLiMMm26OeuTnjY8ZH/TJUOcurma6OiJG9Z1K921S/s1jMKR31/zJ5eWToXOD+ 9FCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=7MIhZhyQf1iiQaCJxYZieUdU7Z/6XeeU6tWciUhQM70=; b=plBFT0v95ChlboEvytSWdXZzDZzdBDw/Wnl6tUaRtaWik2E3Y5aY4IvEbVf+wwC8Dg Okwz0nL9rhqmuweO483+aCMYFNeaB5sTZeVXPdzWXq+s+KpZ8qo3l6SXK3csedkT609j EltEHW1013KdMp9TEBZ/HXDozY3WPydnD8Noq2HLhVXbngEF3oYCt439P9E68eaMy0fN QMJzN5PqEBUz8lPcCaaKvUdmnPfm2olmWUQvADwjG2cUdu4SuCr7gK4kPaeJaZUCNnyb MS6DayaaljK7Uhfh2//Z8K23fq0jNgzoM9/xS6Wdje40Xg8L9XQFMRkfJ5bznw8JzOwX b/pA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=fzPUmgMp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z9-20020aa7d409000000b00440367fe313si6464017edq.305.2022.08.15.02.46.35; Mon, 15 Aug 2022 02:47:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=fzPUmgMp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242043AbiHOJj6 (ORCPT + 99 others); Mon, 15 Aug 2022 05:39:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230153AbiHOJj4 (ORCPT ); Mon, 15 Aug 2022 05:39:56 -0400 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F0531F2C3 for ; Mon, 15 Aug 2022 02:39:55 -0700 (PDT) Received: by mail-pg1-x530.google.com with SMTP id s206so6103726pgs.3 for ; Mon, 15 Aug 2022 02:39:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc; bh=7MIhZhyQf1iiQaCJxYZieUdU7Z/6XeeU6tWciUhQM70=; b=fzPUmgMpRnKlkWNT2SrLzEDGj/tEkFn6IsZGf4kObHoFSetYoZZ+gve2wb+vqt6Yne OHdEFNN01Xvdem3BkWhN+IbLrgtd42m93B15vSfNaEHSOb5+RNhSk5fLRm1Oj2ymoVT4 kPNrFYfG6JFMOe07OcKituyuGM7hP5eMWDij4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc; bh=7MIhZhyQf1iiQaCJxYZieUdU7Z/6XeeU6tWciUhQM70=; b=V1IEIQGYht9yqaqCtdXKqsVUNi59JPl4jyOyaoOn0G6BkgyocYlgtvptkqO1GecCGN 3m5AAKv7IIal5idQpWhJjXaL9ZwJPY8T6mXh+PuYL91AGzrDIvoRy7B9noF7sVH2u2et Mz8JE/nEqpIPdODodkOmzC5OMNCL0DzJgb8TTZcgZcH1uFmhd7/CQUc3LGib8yUXE61y OwFVMbzPE0HP77brxI7KCPZi7XcvpczyZNCE6fjUEEn6S+nFDZR94pPfGumcpmwZ8CUq ffYZH7xTqaWYI3WtGYNFTTFcJOwJ98Yu3mpChe8KmOr7MXFiWQ+FF2axFKLRtZmGwj/9 wYmA== X-Gm-Message-State: ACgBeo0H/XK8Lva9Oa/EKVKiAqeLPsnyAwHGWW6PID3UhlhZ/DaTDfBf RzPOVssf/Hm8N/ow9aGikUDBqkRUDPj+hyf5 X-Received: by 2002:a65:6c10:0:b0:41b:ab8f:ff71 with SMTP id y16-20020a656c10000000b0041bab8fff71mr12969588pgu.308.1660556383875; Mon, 15 Aug 2022 02:39:43 -0700 (PDT) Received: from hsinyi-z840.tpe.corp.google.com ([2401:fa00:1:10:6fc6:4170:be4b:587]) by smtp.gmail.com with ESMTPSA id b13-20020a170903228d00b001714fa07b74sm6680020plh.108.2022.08.15.02.39.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Aug 2022 02:39:43 -0700 (PDT) From: Hsin-Yi Wang To: Douglas Anderson Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rock.chiu@paradetech.corp-partner.google.com Subject: [PATCH] drm/bridge: ps8640: Add double reset T4 and T5 to power-on sequence Date: Mon, 15 Aug 2022 17:39:07 +0800 Message-Id: <20220815093905.134164-1-hsinyi@chromium.org> X-Mailer: git-send-email 2.37.1.595.g718a3a8f04-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The double reset power-on sequence is a workaround for the hardware flaw in some chip that SPI Clock output glitch and cause internal MPU unable to read firmware correctly. The sequence is suggested in ps8640 application note. Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/bridge/parade-ps8640.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c index 49107a6cdac18..d7483c13c569b 100644 --- a/drivers/gpu/drm/bridge/parade-ps8640.c +++ b/drivers/gpu/drm/bridge/parade-ps8640.c @@ -375,6 +375,11 @@ static int __maybe_unused ps8640_resume(struct device *dev) gpiod_set_value(ps_bridge->gpio_reset, 1); usleep_range(2000, 2500); gpiod_set_value(ps_bridge->gpio_reset, 0); + /* Double reset for T4 and T5 */ + msleep(50); + gpiod_set_value(ps_bridge->gpio_reset, 1); + msleep(50); + gpiod_set_value(ps_bridge->gpio_reset, 0); /* * Mystery 200 ms delay for the "MCU to be ready". It's unclear if -- 2.37.1.595.g718a3a8f04-goog