Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp2334712rwb; Mon, 15 Aug 2022 03:39:35 -0700 (PDT) X-Google-Smtp-Source: AA6agR5GyIdFzDw+11hadpPn4Ci0RJ1RjIxZ8lByoiyiMAk1/23EGVd43oc3cRah3WbPgAsK61jx X-Received: by 2002:a05:6402:2386:b0:43d:a74:cd44 with SMTP id j6-20020a056402238600b0043d0a74cd44mr13672272eda.280.1660559975540; Mon, 15 Aug 2022 03:39:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660559975; cv=none; d=google.com; s=arc-20160816; b=L6hafe/rEZ27AeDdeiZhfZdO0cDRhgFxHkpOoc9SJ/eBxZ4WkXXcMlvV+oFhQJwjIt o6+q0I2QvLoKtaHIc46lyJnbFFlXl6GMJkADGfXS5XFhmCvkB514e9L1NJLVyTL79J/Y tKfpb/WgFIPMgqL4I7wx7pWMWjGOsRCnQ8m2KPm8PxboF2wbkoCcSbw269BghQAIiVbC OwIof+5i3YL4RaDgsBwNT2spfSQLdOfTPifc+rBQux97XqVndGNDbWekqYvD0/EqfIib 4q1bbAeITYGNPznDw1pkf0m04gRxfgTeuV6JeIdQ/3RDBw0BMsd1/vBouMSXKC9Gp383 596w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=lsCtyoJst0y6igAhNKtZzd9Wf3Mi9HXJ47UnqiGz/dY=; b=pCQbmmcEzOGLm5b0xOvjWQa/2wSBkRjGslchH3IsAF11TvUvH8o/gFzFzpHGdmcgNW 7fo5T8z/AObjrsd56nkaiYzBHzQMScSNeLe1vBCVyrTu6nZxxe7Bnx7YOsJCKHw0I0A1 oOukhSqV/lj010hUGwXEJbHBHVCTNdnznSAoUTGrn+8T/ISxC1M/Q/TdxTEcWkjzl4xL wC4nY8Ehqhu2F7idlpuplWyt293ELc8n3JfRgRW1mZy5Fwiuk7ID/sNLvl1SlMfrpkTj yPSDUfb0vigrH9fhi2lhwhxGKFkcf4p5xDfvQcH6oFTGSipYLjD3jTsYB8YRDmPquDPJ Gxgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=Es8b23DG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nb21-20020a1709071c9500b007313013c1adsi7492666ejc.259.2022.08.15.03.39.09; Mon, 15 Aug 2022 03:39:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=Es8b23DG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232024AbiHOJbZ (ORCPT + 99 others); Mon, 15 Aug 2022 05:31:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230431AbiHOJbV (ORCPT ); Mon, 15 Aug 2022 05:31:21 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 985BBE011; Mon, 15 Aug 2022 02:31:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=lsCtyoJst0y6igAhNKtZzd9Wf3Mi9HXJ47UnqiGz/dY=; b=Es8b23DGOno0sq+qAcTDpP28cE eICM+0KvmeHXtIXGFX7EnCbk5lY1jxvAZhsD5Evze7Asya4tbcAc1OZL+AdF87g69P1xjQh12gE+/ c224yJOKia0znaba31tJ6pbPlkSuZ2w3qjgg7ISWuoAWYoVWbZJrDCdb9vJxN2muMW34nPE0iHCdd FTOu5rJf+vcsGRk3TFuYMHZokvPWBU7FFvBBsf/3mbdMdLvlW6WfRxad91rLbenDMQMFNetifOSnw cBFYjvVwyBGuzj2mPedq6tTe9RgE45nnYkV0vr/W0MqcOxP9fcRyHfUmTlZIEYNxilCqURo7YLnwU fKcMM+QA==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=worktop.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNWRF-002dQM-HZ; Mon, 15 Aug 2022 09:31:13 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id F0CF3980153; Mon, 15 Aug 2022 11:31:11 +0200 (CEST) Date: Mon, 15 Aug 2022 11:31:11 +0200 From: Peter Zijlstra To: Paolo Bonzini Cc: Like Xu , Sean Christopherson , Jim Mattson , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Kan Liang Subject: Re: [PATCH v2 1/7] perf/x86/core: Update x86_pmu.pebs_capable for ICELAKE_{X,D} Message-ID: References: <20220721103549.49543-1-likexu@tencent.com> <20220721103549.49543-2-likexu@tencent.com> <959fedce-aada-50e4-ce8d-a842d18439fa@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <959fedce-aada-50e4-ce8d-a842d18439fa@redhat.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 12, 2022 at 09:52:13AM +0200, Paolo Bonzini wrote: > On 7/21/22 12:35, Like Xu wrote: > > From: Like Xu > > > > Ice Lake microarchitecture with EPT-Friendly PEBS capability also support > > the Extended feature, which means that all counters (both fixed function > > and general purpose counters) can be used for PEBS events. > > > > Update x86_pmu.pebs_capable like SPR to apply PEBS_ALL semantics. > > > > Cc: Kan Liang > > Fixes: fb358e0b811e ("perf/x86/intel: Add EPT-Friendly PEBS for Ice Lake Server") > > Signed-off-by: Like Xu > > --- > > arch/x86/events/intel/core.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/x86/events/intel/core.c b/arch/x86/events/intel/core.c > > index 4e9b7af9cc45..e46fd496187b 100644 > > --- a/arch/x86/events/intel/core.c > > +++ b/arch/x86/events/intel/core.c > > @@ -6239,6 +6239,7 @@ __init int intel_pmu_init(void) > > case INTEL_FAM6_ICELAKE_X: > > case INTEL_FAM6_ICELAKE_D: > > x86_pmu.pebs_ept = 1; > > + x86_pmu.pebs_capable = ~0ULL; > > pmem = true; > > fallthrough; > > case INTEL_FAM6_ICELAKE_L: > > Peter, can you please ack this (you were not CCed on this KVM series but > this patch is really perf core)? I would much rather see something like this; except I don't know if it is fully correct. I can never find what models support what... Kan do you know? diff --git a/arch/x86/events/intel/core.c b/arch/x86/events/intel/core.c index 2db93498ff71..b42c1beb9924 100644 --- a/arch/x86/events/intel/core.c +++ b/arch/x86/events/intel/core.c @@ -5933,7 +5933,6 @@ __init int intel_pmu_init(void) x86_pmu.pebs_aliases = NULL; x86_pmu.pebs_prec_dist = true; x86_pmu.lbr_pt_coexist = true; - x86_pmu.pebs_capable = ~0ULL; x86_pmu.flags |= PMU_FL_HAS_RSP_1; x86_pmu.flags |= PMU_FL_PEBS_ALL; x86_pmu.get_event_constraints = glp_get_event_constraints; @@ -6291,7 +6290,6 @@ __init int intel_pmu_init(void) x86_pmu.pebs_aliases = NULL; x86_pmu.pebs_prec_dist = true; x86_pmu.pebs_block = true; - x86_pmu.pebs_capable = ~0ULL; x86_pmu.flags |= PMU_FL_HAS_RSP_1; x86_pmu.flags |= PMU_FL_NO_HT_SHARING; x86_pmu.flags |= PMU_FL_PEBS_ALL; @@ -6337,7 +6335,6 @@ __init int intel_pmu_init(void) x86_pmu.pebs_aliases = NULL; x86_pmu.pebs_prec_dist = true; x86_pmu.pebs_block = true; - x86_pmu.pebs_capable = ~0ULL; x86_pmu.flags |= PMU_FL_HAS_RSP_1; x86_pmu.flags |= PMU_FL_NO_HT_SHARING; x86_pmu.flags |= PMU_FL_PEBS_ALL; diff --git a/arch/x86/events/intel/ds.c b/arch/x86/events/intel/ds.c index ba60427caa6d..e2da643632b9 100644 --- a/arch/x86/events/intel/ds.c +++ b/arch/x86/events/intel/ds.c @@ -2258,6 +2258,7 @@ void __init intel_ds_init(void) x86_pmu.drain_pebs = intel_pmu_drain_pebs_icl; x86_pmu.pebs_record_size = sizeof(struct pebs_basic); if (x86_pmu.intel_cap.pebs_baseline) { + x86_pmu.pebs_capable = ~0ULL; x86_pmu.large_pebs_flags |= PERF_SAMPLE_BRANCH_STACK | PERF_SAMPLE_TIME;