Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] spi: lpspi: Simplify some error message
From:   Alexander Stein <alexander.stein@ew.tq-group.com>
To:     Mark Brown <broonie@kernel.org>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        linux-spi@vger.kernel.org
Date:   Mon, 15 Aug 2022 13:06:34 +0200
Message-ID: <2796602.mvXUDI8C0e@steina-w>
Organization: TQ-Systems GmbH
In-Reply-To: <253543c462b765eca40ba54c66f4e3fdf4acdeb7.1659735546.git.christophe.jaillet@wanadoo.fr>
References: <253543c462b765eca40ba54c66f4e3fdf4acdeb7.1659735546.git.christophe.jaillet@wanadoo.fr>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Precedence: bulk

Am Freitag, 5. August 2022, 23:39:19 CEST schrieb Christophe JAILLET:
> dev_err_probe() already prints the error code in a human readable way, so
> there is no need to duplicate it as a numerical value at the end of the
> message.
> 
> Fixes: 12f62a857c83 ("spi: lpspi: Silence error message upon deferred
> probe") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/spi/spi-fsl-lpspi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c
> index 19b1f3d881b0..cbbe8bbef90a 100644
> --- a/drivers/spi/spi-fsl-lpspi.c
> +++ b/drivers/spi/spi-fsl-lpspi.c
> @@ -912,7 +912,7 @@ static int fsl_lpspi_probe(struct platform_device *pdev)
> 
>  	ret = devm_spi_register_controller(&pdev->dev, controller);
>  	if (ret < 0) {
> -		dev_err_probe(&pdev->dev, ret, "spi_register_controller 
error: %i\n",
> ret); +		dev_err_probe(&pdev->dev, ret, "spi_register_controller 
error\n");
> goto free_dma;
>  	}

Acked-By: Alexander Stein <alexander.stein@ew.tq-group.com>