Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Aleksey Romanov <AVRomanov@sberdevices.ru>
To:     Sergey Senozhatsky <senozhatsky@chromium.org>
CC:     "minchan@kernel.org" <minchan@kernel.org>,
        "ngupta@vflare.org" <ngupta@vflare.org>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        kernel <kernel@sberdevices.ru>
Subject: Re: [PATCH v1 1/2] zsmalloc: zs_object_copy: add clarifying comment
Thread-Topic: [PATCH v1 1/2] zsmalloc: zs_object_copy: add clarifying comment
Thread-Index: AQHYrZhN9rSILS75Fk6VO/msHKj5a62vFreAgACiEIA=
Date:   Mon, 15 Aug 2022 12:32:03 +0000
Message-ID: <20220815123249.tls7lsykendsfxts@CAB-WSD-0003100.sigma.sbrf.ru>
References: <20220811153755.16102-1-avromanov@sberdevices.ru>
 <20220811153755.16102-2-avromanov@sberdevices.ru>
 <Yvm0//iPcvbW1M55@google.com>
In-Reply-To: <Yvm0//iPcvbW1M55@google.com>
Accept-Language: ru-RU, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <76ECBCEBE8AB1541B0F52BDFDE212327@sberdevices.ru>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Precedence: bulk

Hi, Sergey.

On Mon, Aug 15, 2022 at 11:52:47AM +0900, Sergey Senozhatsky wrote:
> On (22/08/11 18:37), Alexey Romanov wrote:
> > @@ -1564,6 +1564,12 @@ static void zs_object_copy(struct size_class *cl=
ass, unsigned long dst,
> >  		d_off +=3D size;
> >  		d_size -=3D size;
> > =20
> > +		/* Calling kunmap_atomic(d_addr) is necessary. kunmap_atomic() calls
> > +		 * must occurs in reverse order of calls to kmap_atomic().
> > +		 * So, to call kunmap_atomic(s_addr) we should first call kunmap_ato=
mic(d_addr).
> > +		 * For more details see:
> > +		 * https://lore.kernel.org/linux-mm/5512421D.4000603@samsung.com/
> > +		 */
>=20
> I'd drop the link part, Emails are not documentation, kmap_atomic
> is documented in Documentation/mm/highmem

I'll fix it in v2 patchset, but Andrew has already merged v1 patchset
into the mm-unstable branch.

--=20
Thank you,
Alexey=