Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Dmitry Rokosov <DDRokosov@sberdevices.ru>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
CC:     "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "jic23@kernel.org" <jic23@kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "andriy.shevchenko@linux.intel.com" 
        <andriy.shevchenko@linux.intel.com>,
        "christophe.jaillet@wanadoo.fr" <christophe.jaillet@wanadoo.fr>,
        "stano.jakubek@gmail.com" <stano.jakubek@gmail.com>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "stephan@gerhold.net" <stephan@gerhold.net>,
        "daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
        "wsa@kernel.org" <wsa@kernel.org>,
        "lars@metafoo.de" <lars@metafoo.de>,
        "Michael.Hennerich@analog.com" <Michael.Hennerich@analog.com>,
        "jbhayana@google.com" <jbhayana@google.com>,
        "lucas.demarchi@intel.com" <lucas.demarchi@intel.com>,
        "jani.nikula@intel.com" <jani.nikula@intel.com>,
        "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        kernel <kernel@sberdevices.ru>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 6/7] iio: add MEMSensing MSA311 3-axis accelerometer
 driver
Thread-Topic: [PATCH v5 6/7] iio: add MEMSensing MSA311 3-axis accelerometer
 driver
Thread-Index: AQHYrmvoIVWL45TwmUSMsw+zEhPYFa2rqEkAgAQnwoA=
Date:   Mon, 15 Aug 2022 14:01:13 +0000
Message-ID: <20220815140201.5dpjpk35tdewcpvu@CAB-WSD-L081021.sigma.sbrf.ru>
References: <20220812165243.22177-1-ddrokosov@sberdevices.ru>
 <20220812165243.22177-7-ddrokosov@sberdevices.ru>
 <CAHp75Ve8VtwGX6YeuGvhUat5UfoLXB4RdkW4vc1kQUk71+_aCA@mail.gmail.com>
In-Reply-To: <CAHp75Ve8VtwGX6YeuGvhUat5UfoLXB4RdkW4vc1kQUk71+_aCA@mail.gmail.com>
Accept-Language: ru-RU, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <987B2D9B23A0EB4184D532ADE9321F15@sberdevices.ru>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Precedence: bulk

On Sat, Aug 13, 2022 at 01:34:40AM +0300, Andy Shevchenko wrote:

[...]

> > Spec: https://cdn-shop.adafruit.com/product-files/5309/MSA311-V1.1-ENG.=
pdf
>=20
> Can you use Datasheet: tag below (just before your SoB tag)?

Sure, I can move it on the previous line beforce SoB tag.
But with Datasheet: tag this line will be over the commit msg line limit.
If you don't mind I will stay with Spec: tag instead of Datasheet:

[...]

> > +static const struct {
> > +       int val;
> > +       int val2;
> > +} msa311_fs_table[] =3D {
> > +       {0, 9580}, {0, 19160}, {0, 38320}, {0, 76641}
> > +};
>=20
> At least you may deduplicate the type definition for these data structure=
s, like
>=20
> struct iio_float {
>   int integer;
>   int fract;
> };

Agreed. I will make deduplication of this type inside msa311 driver
only.

[...]

> > +               dev_err(dev,
> > +                       "cannot set odr %u.%luHz, not available in %s m=
ode\n",
> > +                       msa311_odr_table[odr].val,
> > +                       msa311_odr_table[odr].val2 / MILLIHZ_PER_HZ,
>=20
> Logically it's MICROHZ_PER_MILLIHZ.
>=20

You are right. But I think it would be better to print the original val2
value with zero-padding.

[...]

> > +       freq_uhz =3D msa311_odr_table[odr].val * MICROHZ_PER_HZ +
> > +                  msa311_odr_table[odr].val2;
> > +       wait_ms =3D (MICROHZ_PER_HZ / freq_uhz) * MSEC_PER_SEC;
>=20
> On the contrary this seems correct.

Good

> > +       err =3D iio_device_claim_direct_mode(indio_dev);
> > +       if (err)
> > +               return err;
> > +
> > +       mutex_lock(&msa311->lock);
> > +       err =3D msa311_get_axis(msa311, chan, &axis);
> > +       mutex_unlock(&msa311->lock);
> > +
> > +       iio_device_release_direct_mode(indio_dev);
> > +
> > +       if (err) {
> > +               dev_err(dev, "cannot get axis %s (%pe)\n",
> > +                       chan->datasheet_name, ERR_PTR(err));
> > +               return err;
> > +       }
> > +
> > +       pm_runtime_mark_last_busy(dev);
> > +       pm_runtime_put_autosuspend(dev);
>=20
> All error cases above miss the PM restoration. Is it on purpose?
> Otherwise fix it here and check everywhere else.

Nice catch! This is a bug. I'll fix it in v6

> > +       used =3D scnprintf(msa311->chip_name, sizeof(msa311->chip_name)=
,
> > +                        "msa311-%hhx", partid);
>=20
> > +       msa311->chip_name[used] =3D '\0';
>=20
> What is this for exactly?
>=20

Ah, you are right, scnprintf() makes null terminating inside.

> > +       /* Disable all interrupts by default */
> > +       err =3D regmap_write(msa311->regs, MSA311_INT_SET_0_REG, 0);
> > +       if (err)
> > +               return dev_err_probe(dev, err,
> > +                                    "cannot disable set0 interrupts\n"=
);
> > +
> > +       err =3D regmap_write(msa311->regs, MSA311_INT_SET_1_REG, 0);
> > +       if (err)
> > +               return dev_err_probe(dev, err,
> > +                                    "cannot disable set1 interrupts\n"=
);
>=20
> Wondering if the above can be combined to bulk write.
>=20

I will try and rework this place if it's workable.

> > +       /* Unmap all INT1 interrupts by default */
> > +       err =3D regmap_write(msa311->regs, MSA311_INT_MAP_0_REG, 0);
> > +       if (err)
> > +               return dev_err_probe(dev, err,
> > +                                    "failed to unmap map0 interrupts\n=
");
> > +
> > +       err =3D regmap_write(msa311->regs, MSA311_INT_MAP_1_REG, 0);
> > +       if (err)
> > +               return dev_err_probe(dev, err,
> > +                                    "failed to unmap map1 interrupts\n=
");
>=20
> Ditto.

The same as above.

[...]

--=20
Thank you,
Dmitry=