Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp2570601rwb; Mon, 15 Aug 2022 07:35:45 -0700 (PDT) X-Google-Smtp-Source: AA6agR4Vtyj+BXMcA/hbcays1rRLQIaNKT/VI/XG602BfU5A1irTeMwzhftd1cL+cSz4S3SkZWzJ X-Received: by 2002:a17:907:761b:b0:738:4c1c:7dd with SMTP id jx27-20020a170907761b00b007384c1c07ddmr3581809ejc.563.1660574145032; Mon, 15 Aug 2022 07:35:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660574145; cv=none; d=google.com; s=arc-20160816; b=Y9THOKfs+IAYuT+IpF1McBislO1p7Y+Yrrt/IJ3NZXTdAQm+HghQIe/QCIOr/18bmv ScgO6gn63UvOxnDDArnwdcZgSSkPBM/6DrYiyQWRCY+oLU6SVBMUpWecBcMov6ZQhRaL ENMNGRl/krfXYDZAAYPOS4kXL9x+YJt7ANgbXTn/BYxlIAtjdYY+GIGUJ+3U5UodvZNO f168cf27FGtBg9tn7QW+U+0STmVSQciO9ngV5yHqrPmo+VQi8N6zf1pdKK2SOYyGsziF 2r7zGRlLm7fYePq8Fd7l0Y2QDHK4WPqFxhMN5tneWykovt+CKhsPJzYNcJCfCRLx6P3G kGrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=bRXt4bW44m9/UkTOv2HejE0QpMPchFfmA0YLq1fgjpk=; b=RCpoy9hCgztDG8ouSVbCYkNEDE7yl0cKF7yXqgPk42evv4wzo7ryYrukDwX4mMM1EM hnDIwRgtF1MsiOrIMc0flmmsAkK3P6urBPqFtWnwxYGJVtVOW7gRCunY4yc5AZTq5CCH IzP4s/VhrkiubuFT8Zol4dpg6IN0qMeTpT12UXVMYgnWdDP/7dN0PDxLle+YZYv5vHMA WdFBA0hBMjjYAy+WmF/BXUn3shJh+uA8dGK5v+uhhLsQ9ARO4NFH4odkHAQEA8Qxg5mJ 8tVWgav06DXxuFMXpB+lHoAqhEvfY3J5u2W3jM70ex0ZIM3f2Agao1TLlVzGTeEUDtTI nW7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=orG6YehB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o13-20020a056402438d00b0043e14ec047bsi8680745edc.6.2022.08.15.07.35.14; Mon, 15 Aug 2022 07:35:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=orG6YehB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243154AbiHOOag (ORCPT + 99 others); Mon, 15 Aug 2022 10:30:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243106AbiHOOaM (ORCPT ); Mon, 15 Aug 2022 10:30:12 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5405323BE9; Mon, 15 Aug 2022 07:30:11 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id v3so9308599wrp.0; Mon, 15 Aug 2022 07:30:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=bRXt4bW44m9/UkTOv2HejE0QpMPchFfmA0YLq1fgjpk=; b=orG6YehBCcf6F/FyXIAUhX+NBrAuEgBIn63FFDCQI/a/xg8UbUa4BThx4Dy1y1Vqdg cZQ7MlTdsDUE8VeuUpAaRzJOwm+3K/XWpiQ9gDCE8/QY/6eyI0ZnZVVq7lXIxkpUuDCG liSCliT2Dv60f/ZcR8E+5+aaRTDZD3Xk2hoLdeBax3WgtKVSuA7PjBHhSwgaTMeZmOLr yuHmhMdWUaZZVo83xmVoVt/Zp8aKjlGkNZ+jQqX0OHvivq6slluBQBAU2Ge+YU3M6ICJ Np7fCzkhLgsnF0RE2PnNDS5eaqKlPAm2fxDhaxHCNSAb6cObvXU+qdXtFBbBjDsnt3qq ZhrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=bRXt4bW44m9/UkTOv2HejE0QpMPchFfmA0YLq1fgjpk=; b=2ivRczWhpiwWTd4ukkUq67/USqxDDOoQSuzh0KwjtGTr/QX4czOHQc2UEXSR/6fnY9 gnct+1cJHuN0fc7/Kew8hO1iHRF38CbHh1PDKwH6xzm3xcBkivqUghPLCeDLg+HKKSQU JTgA6xp6ri3t0TavaaMQkNqpT3SAVzKWsF9C1Q3vAYoo/f+Q/aZp/itcxydMMep2VIq4 2fjOTUuoYlgWVmK3IreDtPH2GzgiTWEjYfW+F1D9vq8xTveacmP0dVefstBJTeyNksnU SKHZoKUIObIYxVYJUW/KkQGKY8iVIV/0/7xWWOB0YA8tg/Bena0LtEayzohSHsQ/bC3C fegQ== X-Gm-Message-State: ACgBeo3LW/DCBNKLKDYxm2jmYuho6YT43mACMyfpAbVoV+Cll5WnP6/T ydy7AsKP2ghTRQNs6n5hgZQ= X-Received: by 2002:a5d:5343:0:b0:220:6203:ed4a with SMTP id t3-20020a5d5343000000b002206203ed4amr8528635wrv.146.1660573809911; Mon, 15 Aug 2022 07:30:09 -0700 (PDT) Received: from localhost.localdomain ([94.73.32.249]) by smtp.gmail.com with ESMTPSA id m7-20020a056000008700b00224f895d620sm5456894wrx.48.2022.08.15.07.30.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Aug 2022 07:30:09 -0700 (PDT) From: =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= To: jikos@kernel.org Cc: benjamin.tissoires@redhat.com, spbnick@gmail.com, j.witteveen@gmail.com, nathan@kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com, =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= Subject: [PATCH v4 7/8] HID: uclogic: Add support for XP-PEN Deco Pro S Date: Mon, 15 Aug 2022 16:29:55 +0200 Message-Id: <20220815142956.19180-8-jose.exposito89@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220815142956.19180-1-jose.exposito89@gmail.com> References: <20220815142956.19180-1-jose.exposito89@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The XP-PEN Deco Pro S is a UGEE v2 device with a frame with 8 buttons, a bitmap dial and a mouse. Its pen has 2 buttons, supports tilt and pressure. All the pieces to support it are already in place. Add its ID in order to support the device. The required Wireshark traces were captured by Jouke Witteveen. For more information check [1]. Link: https://gitlab.freedesktop.org/libinput/libinput/-/issues/738 [1] Tested-by: Jouke Witteveen Signed-off-by: José Expósito --- drivers/hid/hid-ids.h | 1 + drivers/hid/hid-uclogic-core.c | 2 ++ drivers/hid/hid-uclogic-params.c | 2 ++ 3 files changed, 5 insertions(+) diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index 0fb720a96399..ecf1468404b3 100644 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h @@ -1280,6 +1280,7 @@ #define USB_DEVICE_ID_UGEE_XPPEN_TABLET_G640 0x0094 #define USB_DEVICE_ID_UGEE_XPPEN_TABLET_DECO01 0x0042 #define USB_DEVICE_ID_UGEE_XPPEN_TABLET_DECO_L 0x0935 +#define USB_DEVICE_ID_UGEE_XPPEN_TABLET_DECO_PRO_S 0x0909 #define USB_DEVICE_ID_UGEE_XPPEN_TABLET_STAR06 0x0078 #define USB_DEVICE_ID_UGEE_TABLET_G5 0x0074 #define USB_DEVICE_ID_UGEE_TABLET_EX07S 0x0071 diff --git a/drivers/hid/hid-uclogic-core.c b/drivers/hid/hid-uclogic-core.c index 47a17375c7fc..6fcdb141acec 100644 --- a/drivers/hid/hid-uclogic-core.c +++ b/drivers/hid/hid-uclogic-core.c @@ -523,6 +523,8 @@ static const struct hid_device_id uclogic_devices[] = { USB_DEVICE_ID_UGEE_XPPEN_TABLET_DECO01) }, { HID_USB_DEVICE(USB_VENDOR_ID_UGEE, USB_DEVICE_ID_UGEE_XPPEN_TABLET_DECO_L) }, + { HID_USB_DEVICE(USB_VENDOR_ID_UGEE, + USB_DEVICE_ID_UGEE_XPPEN_TABLET_DECO_PRO_S) }, { HID_USB_DEVICE(USB_VENDOR_ID_UGEE, USB_DEVICE_ID_UGEE_XPPEN_TABLET_STAR06) }, { } diff --git a/drivers/hid/hid-uclogic-params.c b/drivers/hid/hid-uclogic-params.c index 648abda13a73..60ed94981a55 100644 --- a/drivers/hid/hid-uclogic-params.c +++ b/drivers/hid/hid-uclogic-params.c @@ -1582,6 +1582,8 @@ int uclogic_params_init(struct uclogic_params *params, break; case VID_PID(USB_VENDOR_ID_UGEE, USB_DEVICE_ID_UGEE_XPPEN_TABLET_DECO_L): + case VID_PID(USB_VENDOR_ID_UGEE, + USB_DEVICE_ID_UGEE_XPPEN_TABLET_DECO_PRO_S): rc = uclogic_params_ugee_v2_init(&p, hdev); if (rc != 0) goto cleanup; -- 2.25.1