Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <99b85bdb-3366-a266-35d8-f856c2677008@quicinc.com>
Date:   Mon, 15 Aug 2022 20:23:16 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH] remoteproc: imx_dsp_rproc: fix argument 2 of
 rproc_mem_entry_init
Content-Language: en-US
To:     Shengjiu Wang <shengjiu.wang@nxp.com>,
        <bjorn.andersson@linaro.org>, <mathieu.poirier@linaro.org>,
        <shawnguo@kernel.org>, <s.hauer@pengutronix.de>,
        <kernel@pengutronix.de>, <festevam@gmail.com>, <linux-imx@nxp.com>,
        <linux-remoteproc@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
References: <1660567398-24495-1-git-send-email-shengjiu.wang@nxp.com>
From:   Mukesh Ojha <quic_mojha@quicinc.com>
In-Reply-To: <1660567398-24495-1-git-send-email-shengjiu.wang@nxp.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 8/15/2022 6:13 PM, Shengjiu Wang wrote:
> There are sparse warning:
> drivers/remoteproc/imx_dsp_rproc.c:602:49: sparse: sparse: incorrect type in argument 2 (different address spaces) @@     expected void *va @@     got void [noderef] __iomem *[assigned] cpu_addr @@
> drivers/remoteproc/imx_dsp_rproc.c:602:49: sparse:     expected void *va
> drivers/remoteproc/imx_dsp_rproc.c:602:49: sparse:     got void [noderef] __iomem *[assigned] cpu_addr
> drivers/remoteproc/imx_dsp_rproc.c:638:49: sparse: sparse: incorrect type in argument 2 (different address spaces) @@     expected void *va @@     got void [noderef] __iomem *[assigned] cpu_addr @@
> drivers/remoteproc/imx_dsp_rproc.c:638:49: sparse:     expected void *va
> drivers/remoteproc/imx_dsp_rproc.c:638:49: sparse:     got void [noderef] __iomem *[assigned] cpu_addr
> 
> Fixes: ec0e5549f358 ("remoteproc: imx_dsp_rproc: Add remoteproc driver for DSP on i.MX")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
>   drivers/remoteproc/imx_dsp_rproc.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_dsp_rproc.c
> index ca0817f8e41e..899aa8dd12f0 100644
> --- a/drivers/remoteproc/imx_dsp_rproc.c
> +++ b/drivers/remoteproc/imx_dsp_rproc.c
> @@ -599,7 +599,7 @@ static int imx_dsp_rproc_add_carveout(struct imx_dsp_rproc *priv)
>   		}
>   
>   		/* Register memory region */
> -		mem = rproc_mem_entry_init(dev, cpu_addr, (dma_addr_t)att->sa,
> +		mem = rproc_mem_entry_init(dev, (void __force *)cpu_addr, (dma_addr_t)att->sa,
>   					   att->size, da, NULL, NULL, "dsp_mem");
>   
>   		if (mem)
> @@ -635,7 +635,7 @@ static int imx_dsp_rproc_add_carveout(struct imx_dsp_rproc *priv)
>   		}
>   
>   		/* Register memory region */
> -		mem = rproc_mem_entry_init(dev, cpu_addr, (dma_addr_t)rmem->base,
> +		mem = rproc_mem_entry_init(dev, (void __force *)cpu_addr, (dma_addr_t)rmem->base,
>   					   rmem->size, da, NULL, NULL, it.node->name);
>   
>   		if (mem)

Acked-by: Mukesh Ojha <quic_mojha@quicinc.com>

-Mukesh