Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 15 Aug 2022 07:59:12 -0700
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Ido Schimmel <idosch@idosch.org>
Cc:     linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, Terry Bowman <terry.bowman@amd.com>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Wolfram Sang <wsa@kernel.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        UNGLinuxDriver@microchip.com,
        Steen Hegelund <Steen.Hegelund@microchip.com>,
        Lars Povlsen <lars.povlsen@microchip.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Russell King <linux@armlinux.org.uk>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Lee Jones <lee.jones@linaro.org>,
        katie.morris@in-advantage.com,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Lee Jones <lee@kernel.org>
Subject: Re: [PATCH v16 mfd 8/8] mfd: ocelot: add support for the vsc7512
 chip via spi
Message-ID: <YvpfQCM0kJg4k5Zd@euler>
References: <20220815005553.1450359-1-colin.foster@in-advantage.com>
 <20220815005553.1450359-9-colin.foster@in-advantage.com>
 <YvpV4cvwE0IQOax7@euler>
 <YvpZoIN+5htY9Z1o@shredder>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YvpZoIN+5htY9Z1o@shredder>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?z7pcBthLj6Ay17tIXEpcUO+fr7uHdeui9QDqtofgiaNbukwHoBEYS3+5kYoH?=
 =?us-ascii?Q?TWXOJR2gCiqFix9PMOhnznWzSWizMo8Ud7LlYusHm/amkO2Yep7Qtrv7ZIJ4?=
 =?us-ascii?Q?x9zF0osOzYU7flgb4mU2LB4jVUXnltuvnVwlD9IuFB3ZFYC1dWhdKA/1+TRO?=
 =?us-ascii?Q?1zgaJf+Pki4PtKs1HVUuMBDt3FPWCT1OcTHX6VVklLwDBfmMnIlrPRcmSR/I?=
 =?us-ascii?Q?eUGxLw/1h0OdVb6lo+ofJfPEPnpdj87tqQKPGvwP+GZzyioM+DhmzuxUE9kK?=
 =?us-ascii?Q?/zyXb0155uKgQe+0BINuSW0S1d42eobQPq65f6cRf2gJMzj7Cvk2pM8Mhm4t?=
 =?us-ascii?Q?eEd2SM1qIMxYXffSJiVv5F9Wberx0cTUzfRV6bPlkcNRa20c/OBBjTtv2tk7?=
 =?us-ascii?Q?5QYAA1Eg+Wj3xDuPFl2YR3V3IQfI9Amd2gahFRNhQhO0yqWEGZh+Qa+c+sjX?=
 =?us-ascii?Q?pvof9bP3R45vrCj2/r6//D4tabbjPmFB/2E6KydH8RiW+jYkUftBTxcE3MH0?=
 =?us-ascii?Q?g1yKR6BFlhF5sbUQKqWi9hydQHr7otj+Km3gxdZRdQu5xq6tFBYdXEp6Zi2w?=
 =?us-ascii?Q?vo4R8yhBc6J9j5wN1+2qG5pe99pBSgg1cbuA7P5Q0/Ww2lTotdvirp8F929F?=
 =?us-ascii?Q?CoVsd0c31z58+K3GWIQQiTi2Lskf377l25SGfu9hQ5PMC/hc2YDOtKKnTFdn?=
 =?us-ascii?Q?aMwxNWs0C2HnsAup2kevFRdBKDpWIfgLg/9mUvmKNcYJtTPLhEHX7wL1mqLD?=
 =?us-ascii?Q?tfPv6wqGfG0m0mXx+pFh1dtdbnP2h7F4gVeM8ODntOp9JdTCSDbtdR7phDVh?=
 =?us-ascii?Q?Sx0o8/FqZE+1tonbqczJOKVCq6rN4a66xS71PcrsaRjtGvSblR51tCQCTy4+?=
 =?us-ascii?Q?wuGSt7OI5EOUTxeRA+YHeWFbJKc1FaZ1fKvHO+c3mMac3QPfNiwNKoOebJjH?=
 =?us-ascii?Q?rIMlxWChahiEP3WJi+nMljxOSG6A1mjumCaBDl+xN4ZY6I+7cLoAaNj+yF1H?=
 =?us-ascii?Q?cYZWUB3wvBzJOanAI4fgIVCV327mVZMS+WEX4KA6yxC1WrDIgENOhSI8S8pS?=
 =?us-ascii?Q?Xy1iSko724aYgySWwdXOWrBRgj1FNdUtbXELNtk5p6y3Ekc6yHmF3BDrvAN+?=
 =?us-ascii?Q?pjJfaevsp8oQEhAktgeUD4HtN9jNdwiXslnBdVYzzPiiyWONVsRfcvT3Pqka?=
 =?us-ascii?Q?t3Lmzgp7BDYgfA6yue7m/6na4VTx5MsDSeA6n4OAuiwOWt1LhYBILA8wKzk6?=
 =?us-ascii?Q?XNd0fpRabyq6abPO/vD1eWsp6BXHE1NoYmHzNKN24x8VaaQf7BDB3RQv2x1+?=
 =?us-ascii?Q?JYx8VYqxxh79PLD/oP7JvP1yZ3vTWfjdnccOvFsxH/hSfKhxZGAM9rQnxTqX?=
 =?us-ascii?Q?960V4Kni1IMp/smrvkyCo6r15sMFb0vqae4PewP1wq9txO0S+ecB7GzWelf+?=
 =?us-ascii?Q?BbPLGyBVQN2SciuF/Tpsx7OW9dPVakIzzRwyoJB4osVJiuhhbmczpItOS/xD?=
 =?us-ascii?Q?Wq/ZIvJGhkGEjNER0tNww4D9e9yFqlRFTP1OHk8Q4Sm+EP/DSzOxfSHXOZYb?=
 =?us-ascii?Q?Hh7GPniLrlHH5JN0/sbjF+S+Xd/qx7jwmhQNu9m5eRkNMdVb6FEyU8lUzaJj?=
 =?us-ascii?Q?I7K6OJ915t66uGzDjIMAJAw=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f8a6a6d7-8e5d-4683-f050-08da7eceb9dc
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Aug 2022 14:59:17.5629
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nLmYF6ROGjCzqME+0WOmntwDdEfh5kaqCpw9Q7y5ks0GX4wehCL/jlyZMMfPwAYHM1ss0o3xx+vis9xUNP9IrG6q3GmrHHMyjNfyIJ2s0R0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4267
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 15, 2022 at 05:35:12PM +0300, Ido Schimmel wrote:
> On Mon, Aug 15, 2022 at 07:19:13AM -0700, Colin Foster wrote:
> > Something is going on that I don't fully understand with <asm/byteorder.h>.
> > I don't quite see how ocelot-core is throwing all sorts of errors in x86
> > builds now:
> > 
> > https://patchwork.hopto.org/static/nipa/667471/12942993/build_allmodconfig_warn/stderr
> > 
> > Snippet from there:
> > 
> > /home/nipa/nipa/tests/patch/build_32bit/build_32bit.sh: line 21: ccache gcc: command not found
> > ../drivers/mfd/ocelot-spi.c: note: in included file (through ../include/linux/bitops.h, ../include/linux/kernel.h, ../arch/x86/include/asm/percpu.h, ../arch/x86/include/asm/current.h, ../include/linux/sched.h, ...):
> > ../arch/x86/include/asm/bitops.h:66:1: warning: unreplaced symbol 'return'
> > ../drivers/mfd/ocelot-spi.c: note: in included file (through ../include/linux/bitops.h, ../include/linux/kernel.h, ../arch/x86/include/asm/percpu.h, ../arch/x86/include/asm/current.h, ../include/linux/sched.h, ...):
> > ../include/asm-generic/bitops/generic-non-atomic.h:29:9: warning: unreplaced symbol 'mask'
> > ../include/asm-generic/bitops/generic-non-atomic.h:30:9: warning: unreplaced symbol 'p'
> > ../include/asm-generic/bitops/generic-non-atomic.h:32:10: warning: unreplaced symbol 'p'
> > ../include/asm-generic/bitops/generic-non-atomic.h:32:16: warning: unreplaced symbol 'mask'
> > ../include/asm-generic/bitops/generic-non-atomic.h:27:1: warning: unreplaced symbol 'return'
> > ../drivers/mfd/ocelot-spi.c: note: in included file (through ../arch/x86/include/asm/bitops.h, ../include/linux/bitops.h, ../include/linux/kernel.h, ../arch/x86/include/asm/percpu.h, ../arch/x86/include/asm/current.h, ...):
> > ../include/asm-generic/bitops/instrumented-non-atomic.h:26:1: warning: unreplaced symbol 'return'
> > 
> > 
> > <asm/byteorder.h> was included in both drivers/mfd/ocelot-spi.c and
> > drivers/mfd/ocelot.h previously, though Andy pointed out there didn't
> > seem to be any users... and I didn't either. I'm sure there's something
> > I must be missing.
> 
> I got similar errors in our internal CI yesterday. Fixed by compiling
> sparse from git:
> https://git.kernel.org/pub/scm/devel/sparse/sparse.git/commit/?id=0e1aae55e49cad7ea43848af5b58ff0f57e7af99
> 
> The update is also available in the "testing" repo in case you are
> running Fedora 35 / 36:
> https://bodhi.fedoraproject.org/updates/FEDORA-2022-c58b53730f
> https://bodhi.fedoraproject.org/updates/FEDORA-2022-2bc333ccac

Thanks for the info! I haven't been able to fully recreate the issue
locally, those are from kernel test robot. I'll give this a shot if I
run into it locally though.