Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 15 Aug 2022 18:12:52 +0200
Message-ID: <87fshxzdrv.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Stefan Binding <sbinding@opensource.cirrus.com>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
        <patches@opensource.cirrus.com>
Subject: Re: [PATCH v1] ALSA: hda: cs35l41: Clarify support for CSC3551 without _DSD Properties
In-Reply-To: <20220815152844.462229-1-sbinding@opensource.cirrus.com>
References: <20220815152844.462229-1-sbinding@opensource.cirrus.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Mon, 15 Aug 2022 17:28:44 +0200,
Stefan Binding wrote:
> 
> For devices which use HID CSC3551, correct ACPI _DSD properties are
> required to be able support those systems.
> Add error message to clarify this.
> 
> Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
> ---
>  sound/pci/hda/cs35l41_hda.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c
> index 129bffb431c2..b9d94f3a5b99 100644
> --- a/sound/pci/hda/cs35l41_hda.c
> +++ b/sound/pci/hda/cs35l41_hda.c
> @@ -1163,6 +1163,11 @@ static int cs35l41_no_acpi_dsd(struct cs35l41_hda *cs35l41, struct device *physd
>  		hw_cfg->gpio1.func = CS35l41_VSPK_SWITCH;
>  		hw_cfg->gpio1.valid = true;
>  	} else {
> +		/*
> +		 * Note: CLSA010(0/1) are special cases which use a slightly different design.
> +		 * All other HIDs e.g. CSC3551 require valid ACPI _DSD properties to be supported.
> +		 */
> +		dev_err(cs35l41->dev, "Error: ACPI _DSD Properties are missing for HID %s.", hid);

A newline is missing at the end of the string?


Takashi